[jitsi-dev] [jitsi/jitsi-videobridge] Don't use Map<>.containsKey before Map<>.get (#216)


#1

if the key doesn't exist Map<>.get return null,
and we are not putting null as value, so use that.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/216

-- Commit Summary --

  * Don't use Map<>.containsKey before Map<>.get

-- File Changes --

    M src/main/java/org/jitsi/videobridge/pubsub/PubSubPublisher.java (9)
    M src/main/java/org/jitsi/videobridge/simulcast/sendmodes/RewritingSendMode.java (4)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/216.patch
https://github.com/jitsi/jitsi-videobridge/pull/216.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/216


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/216#issuecomment-209826990


#3

Jenkins, it's ok to test this.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/216#issuecomment-209936135


#4

Jenkins, test this please.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/216#issuecomment-209946778


#5

The first automatic PR test failed because of a known Jenkins failure condition related to an SSH library. The second automatic PR test failed because of known test failures.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/216#issuecomment-209952979


#6

Merged #216.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/216#event-627388352