[jitsi-dev] [jitsi/jitsi-videobridge] Config to turn on/off /colibri/* REST API endpoints (#351)


#1

This PR adds a new config (`org.jitsi.videobridge.ENABLE_REST_COLIBRI`) to turn on/off the `/colibri/*` REST API endpoints.
The default value for this Config is `true`, therefore the current behavior is maintained.

When setting `org.jitsi.videobridge.ENABLE_REST_COLIBRI` to `false`, it is possible to have the JVB to serve HTTP content without exposing the Colibri REST API endpoints.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/351

-- Commit Summary --

  * Config to turn on/off /colibri/* REST API endpoints

-- File Changes --

    M doc/http.md (6)
    M src/main/java/org/jitsi/videobridge/rest/HandlerImpl.java (23)
    M src/main/java/org/jitsi/videobridge/rest/RESTBundleActivator.java (10)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/351.patch
https://github.com/jitsi/jitsi-videobridge/pull/351.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#issuecomment-257287496


#3

bgrozev approved this pull request.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#pullrequestreview-6455439


#4

This looks good to me!
Note however, that health checks (/about/health) are still allowed.

@trustlix Have you signed the CLA already?

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#issuecomment-257323137


#5

Hi @bgrozev,

Yup. `/about/health`, `/about/version` and all the other HTTP content configured on Jetty are still open.

I signed the CLA yesterday as an individual contributor.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#issuecomment-257542435


#6

Got the CLA earlier today (there is some delay here)

jenkins: ok to test

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#issuecomment-258214352


#7

Merged #351.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#event-846798378


#8

Thank you for the contribution!

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/351#issuecomment-258220754