[jitsi-dev] [jitsi/jitsi-videobridge] Allow the stream direction to be changed before connected if using ICE. (#265)


#1

if we're using ice, don't block setting the direction if the connection isn't made yet.

@emcho here's a sample of what some checks for this around the code may look like (and this is a place where we've commented out the check altogether since we're not using latching). if it looks good, we can start taking a look at other places where checks like this would be useful.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/265

-- Commit Summary --

  * Allow the stream direction to be changed before connected if using ICE.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/RtpChannel.java (9)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/265.patch
https://github.com/jitsi/jitsi-videobridge/pull/265.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/265


#2

wanted to add that the 'if' condition here could probably be a bit more concise, but i thought this best communicated the situation. open to something more terse though if you guys think it'd be better.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/265#issuecomment-229741236