[jitsi-dev] [jitsi/jitsi-videobridge] Addressing various Openfire plugin issues (#328)


#1

The changes in this pull request address various issues (including, but not limited to #178) with the Openfire plugin, that is part of the Jitsi-videobridge project.

I've tried to address each issue (which range from bugs to minor improvement) in separate and concise commits.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/328

-- Commit Summary --

  * Openfire plugin should compile
  * Initialize OSGI context
  * Class should not have unused fields.
  * Be prepared for file-system based errors
  * Prevent NullPointerException when OS is not recognized.
  * Should not silently ignore exceptions.
  * Use Openfire logging framework instead of std-out/err
  * Don't bundle libraries that are already provided.
  * Bring UI in line with Openfire admin console.
  * Increase Openfire plugin version number.

-- File Changes --

    M build.xml (13)
    M openfire/changelog.html (5)
    M openfire/plugin.xml (3)
    M openfire/src/i18n/jitsivideobridge_i18n.properties (6)
    A openfire/src/java/org/jitsi/videobridge/openfire/JvbOpenfireBundleConfig.java (37)
    M openfire/src/java/org/jitsi/videobridge/openfire/PluginImpl.java (112)
    M openfire/src/web/jitsi-videobridge.jsp (39)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/328.patch
https://github.com/jitsi/jitsi-videobridge/pull/328.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/328


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/328#issuecomment-254232815


#3

damencho commented on this pull request.

@@ -347,8 +347,19 @@

         <copy todir="${dist}/openfire/jitsiVideobridge/lib">
             <fileset dir="lib">
                 <exclude name="native/**"/>
- <exclude name="bouncycastle.jar"/>
+ <exclude name="bc*.jar"/>

I think this will also exclude bccontrib-....jar which is needed when running jitsi videobridge.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/328#pullrequestreview-4507903


#4

Jenkins, add to whitelist.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/328#issuecomment-254257434


#5

guusdk commented on this pull request.

@@ -347,8 +347,19 @@

         <copy todir="${dist}/openfire/jitsiVideobridge/lib">
             <fileset dir="lib">
                 <exclude name="native/**"/>
- <exclude name="bouncycastle.jar"/>
+ <exclude name="bc*.jar"/>

Hmm, that was unintentional. I ment to exclude these three dependencies that are provided by Openfire:

- bcpg-jdk15on.jar
- bcpkix-jdk15on.jar
- bcprov-jdk15on.jar

I will commit and squash a fix in a moment.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/328


#6

Merged #328.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/328#event-826269043