[jitsi-dev] [jitsi] Introduce SmackProxy for abstracting different Smack implementations (3 and 4) (#183)


#1

- base class for abstracting Smack
- implementation for SmackV3
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi/pull/183

-- Commit Summary --

  * Introduce SmackProxy for abstracting different Smack implementations (3 and 4)

-- File Changes --

    M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderFactoryJabberImpl.java (8)
    A src/net/java/sip/communicator/impl/protocol/jabber/SmackV3Proxy.java (91)
    M src/net/java/sip/communicator/impl/protocol/jabber/extensions/AbstractPacketExtension.java (1)
    M src/net/java/sip/communicator/impl/protocol/jabber/extensions/DefaultPacketExtensionProvider.java (10)
    M src/net/java/sip/communicator/impl/protocol/jabber/extensions/colibri/ColibriIQProvider.java (83)
    M src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/JingleIQ.java (25)
    M src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/JingleIQProvider.java (195)
    A src/net/java/sip/communicator/service/protocol/jabber/AbstractSmackProxy.java (135)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/183.patch
https://github.com/jitsi/jitsi/pull/183.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183


#2

Merged #183.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183#event-462597725


#3

Would someone mind explaining to me what this is good for?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183#issuecomment-156152780


#4

Ingo, we are adding BOSH support to jitsi-hammer, which uses the smack extensions from the Jitsi bundle. For this we updated jitsi-hammer's smack to version 4, and @mksh created an abstraction layer, so we can reuse the code and facilitate the potential future migration for Jitsi. A smack4 implementation of the layer will be added to jitsi-hammer soon.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183#issuecomment-156155628


#5

Thanks Boris. I never really looked into it and thus cannot estimate the amount of work required. But wouldn't it make more sense to upgrade Jitsi to Smack V4 for the benefit of all involved projects instead of writing abstraction layers and procrastinating the inevitable?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183#issuecomment-156156436


#6

I can't estimate the effort accurately either, but I would tend to think it would be substantial. I also suspect it would introduce bugs, which we wouldn't have the time to fix. In any case, I don't think adding this layer is procrastination -- rather, it is an actual step towards migrating, since part of the code is now v4-ready (or at least v4.0.7-ready).

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183#issuecomment-156159945


#7

I just wanted to check which of our patches had been integrated there, I suspect most of them, but I can spent some time on this and report it.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/183#issuecomment-156180514