[jitsi-dev] [jitsi] Improve add contact dialog (#15)


#1

This pull request contains some commits discussed in pull request #13. It contains only those changes to the "Add contact" dialog were most people could agree on. Three changes were made: 1. Group field has been moved to bottom 2. Tool tips have been added and 3. example prompts have been added to the input fields. This is how the dialog now looks like:

![jitsi_improved_add_contact_dialog](https://f.cloud.github.com/assets/112226/1937942/b87f961e-7f36-11e3-8138-51654c33754b.png)

All other changes from #13 remain there for discussion.
You can merge this Pull Request by running:

  git pull https://github.com/tomka/jitsi improve-add-contact-dialog

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi/pull/15

-- Commit Summary --

  * Add contact dialog: move group field to bottom
  * Add contact dialog: add tool tips
  * Add contact dialog: support prompts in text fields
  * Add contact dialog: have prompts in name and contact fields

-- File Changes --

    M resources/languages/resources.properties (6)
    M src/net/java/sip/communicator/impl/gui/main/contactlist/AddContactDialog.java (86)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/15.patch
https://github.com/jitsi/jitsi/pull/15.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15


#2

Here is a related bug report:
http://lists.jitsi.org/pipermail/users/2014-April/007020.html

Thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15#issuecomment-41228988


#3

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15#issuecomment-218829003


#4

Thanks for getting back to this pull request! In case there is still interest in merging this: I signed your CLA back in 2014. Let me know if I should send it again.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15#issuecomment-218838701


#5

@tomka there is a new CLA in effect since BlueJimp was acquired by Atlassian in spring '15. Everyone has/had to sign the new one (see links above and sorry for the confusion).

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15#issuecomment-218890833


#6

Oh I see, thanks for the clarification. I will send a signed copy of the new CLA then.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15#issuecomment-218892882


#7

Closed #15 via 5ee630fc20852a00e2837415d9c75a9a56344987.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/15#event-663552574