[jitsi-dev] [jitsi] Implements arbitrary packet logging configuration. (#171)


#1

This PR complements https://github.com/jitsi/libjitsi/pull/64
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi/pull/171

-- Commit Summary --

  * Adds configuration for logging arbitrary packets.
  * Uses an EvictingQueue instead of an ArrayList in the PacketLoggingServiceImpl.

-- File Changes --

    M lib/installer-exclude/libjitsi-1.0-SNAPSHOT.jar (0)
    M src/net/java/sip/communicator/impl/packetlogging/PacketLoggingConfigurationImpl.java (4)
    M src/net/java/sip/communicator/impl/packetlogging/PacketLoggingServiceImpl.java (7)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/171.patch
https://github.com/jitsi/jitsi/pull/171.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/171


#2

Could you please try doing a sip call before you merge this? I'm a bit afraid that the bundle-plugin somehow sometimes doesn't catch all necessary imports from fmj.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/171#issuecomment-148822811


#3

I will, thanks for thinking about this Ingo. I'm trying to understand why you're referring to fmj, since there's no dependency between fmj and the packet logging service implementation. Could you please elaborate a little bit further on this?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/171#issuecomment-148836127


#4

Oh, sorry, that was about updating the libjitsi binary. The last time I updated it, I think I got an outdated fmj-snapshot from our github-mvn-repo and thus maven-bundle-plugin didn't catch all necessary OSGi imports that needed to be put into the libjitsi manifest.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/171#issuecomment-148894650


#5

Merged #171.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/171#event-454711276