[jitsi-dev] [jitsi] Fixes the contacts 'message button' disappearing on offline contacts (#184)


#1

This is a fixup to https://github.com/jitsi/jitsi/pull/161 This introduced a bug in which a contact which just went offline to not have *messaging capabilities*. This is needed for opening the chat window to send offline messages. One clause was missing, causing the new behavior to check offline contacts for their capabilities. More specifically it checked their online resources and this will always be a null set on an offline contact. With this it now uses the old behavior for offline contacts, which returns a preset set of capabilities (e.g. messaging).
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi/pull/184

-- Commit Summary --

  * Fixes offline messaging to contact which just went offline

-- File Changes --

    M src/net/java/sip/communicator/impl/protocol/jabber/OperationSetContactCapabilitiesJabberImpl.java (5)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/184.patch
https://github.com/jitsi/jitsi/pull/184.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/184


#2

I'm aware that those two statements are actually identical, but negated. There is no intention behind this. Should I reorder this or leave it for now?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/184#issuecomment-155492252


#3

Merged #184.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/184#event-460735059


#4

Thanks. The condition doesn't matter.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/184#issuecomment-155600391


#5

My pleasure! So you want me to send an email to the dev list in which I explain what this new option does?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/184#issuecomment-155611324