[jitsi-dev] [jitsi] Directimage fix (#204)


#1

I had problems with some image URLs not being replaced correctly on Windows.

Our internal XMPP server uses URLs of the form
   https://im.example.org:12345/abc/def/ghi/img.jpg
which weren't replaced. Other URLs worked fine though.

Tried the fix on Linux and it works perfectly fine.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi/pull/204

-- Commit Summary --

  * Changed URL pattern for direct image links
  * Fix the replacement for direct image links

-- File Changes --

    M src/net/java/sip/communicator/impl/replacement/directimage/ReplacementServiceDirectImageImpl.java (2)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/204.patch
https://github.com/jitsi/jitsi/pull/204.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/204


#2

If you haven't already done so, could you please sign the [CLA](https://jitsi.org/icla)?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/204#issuecomment-171831063


#3

Already did yesterday, in case it's somehow not submitted pls drop me a line.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/204#issuecomment-171985296


#4

Merged #204.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/204#event-516576784