[jitsi-dev] jitsi-default-overrides doesn't seem to override much


#1

I was under the impression that putting a setting in
lib/jitsi-default-overrides.properties would override that setting, even if
its set in defaults.properties . Therefore I put in:

impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true

With hopes that the ZRTP confirmation panel wouldn't be shown any longer.
However when I later tried a call with someone, I still got the dreaded
ZRTP panel.

I did some debugging, and added the following statement to the tools ->
options window
(src/net/java/sip/communicator/impl/gui/main/account/AccountsConfigurationPanel.java
) :

boolean isSecurityLowPriority =
Boolean.parseBoolean(GuiActivator.getResources().getSettingsString("impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY"));

System.out.println("Security: " + isSecurityLowPriority);

When I tested this, the output was always 'false' even when I had this
setting being set to true in jitsi-default-overrides.properties , and even
when I removed the line setting this to false in defaults.properties. I
only got this to say 'true' when I put

impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true

into defaults.properties itself.

So, what's the story here? Do I need to move all the other settings I set
in overrides back to defaults.properties if they're going to have no effect?


#2

I was under the impression that putting a setting in lib/jitsi-default-
overrides.properties would override that setting, even if its set in
defaults.properties . Therefore I put in:

impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true

With hopes that the ZRTP confirmation panel wouldn't be shown any
longer. However when I later tried a call with someone, I still got the
dreaded ZRTP panel.

Which part of disabling ZRTP in the account properties does not work?

I did some debugging, and added the following statement to the tools ->
options window
(src/net/java/sip/communicator/impl/gui/main/account/AccountsConfiguratio
nPan el.java ) :

boolean isSecurityLowPriority =
Boolean.parseBoolean(GuiActivator.getResources().getSettingsString("impl.
gui. I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY"));

System.out.println("Security: " + isSecurityLowPriority);

When I tested this, the output was always 'false' even when I had this
setting being set to true in jitsi-default-overrides.properties , and even
when I removed the line setting this to false in defaults.properties. I only
got this to say 'true' when I put

impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true

into defaults.properties itself.

So, what's the story here? Do I need to move all the other settings I set in
overrides back to defaults.properties if they're going to have no effect?

defaults.properties is a legacy file and the settings in there must be changed before compiling/packing the .jars. And if you'd have done just a little bit of research you'd have the answer to that in earlier posts on this list.

Ingo


#3

Which part of disabling ZRTP in the account properties does not work?

The issue at the moment is, when I
set I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true in overrides, that doesn't
seem to take effect as shown by the debugging. This value remains false
unless I set it in defaults.properties

So I'm just wondering, is that the case only for this property, or do I
need to move all my settings back from overrides.properties to
defaults.properties themselves?

defaults.properties is a legacy file and the settings in there must be

changed before compiling/packing the .jars.

Which settings in there need to be changed?

ยทยทยท

On Sun, Jan 25, 2015 at 10:09 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

> I was under the impression that putting a setting in lib/jitsi-default-
> overrides.properties would override that setting, even if its set in
> defaults.properties . Therefore I put in:
>
> impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true
>
> With hopes that the ZRTP confirmation panel wouldn't be shown any
> longer. However when I later tried a call with someone, I still got the
> dreaded ZRTP panel.

Which part of disabling ZRTP in the account properties does not work?

> I did some debugging, and added the following statement to the tools ->
> options window
> (src/net/java/sip/communicator/impl/gui/main/account/AccountsConfiguratio
> nPan el.java ) :
>
>
> boolean isSecurityLowPriority =
> Boolean.parseBoolean(GuiActivator.getResources().getSettingsString("impl.
> gui. I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY"));
>
> System.out.println("Security: " + isSecurityLowPriority);
>
> When I tested this, the output was always 'false' even when I had this
> setting being set to true in jitsi-default-overrides.properties , and
even
> when I removed the line setting this to false in defaults.properties. I
only
> got this to say 'true' when I put
>
> impl.gui.I_DONT_CARE_THAT_MUCH_ABOUT_SECURITY=true
>
>
> into defaults.properties itself.
>
> So, what's the story here? Do I need to move all the other settings I
set in
> overrides back to defaults.properties if they're going to have no effect?

defaults.properties is a legacy file and the settings in there must be
changed before compiling/packing the .jars. And if you'd have done just a
little bit of research you'd have the answer to that in earlier posts on
this list.

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev