[jitsi-dev] [jitsi] Correction of some warnings (#17)


#1

I am not used to contribute to big projects. So there might be some errors or wrong things, please check.
You can merge this Pull Request by running:

  git pull https://github.com/RyDroid/jitsi master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi/pull/17

-- Commit Summary --

  * Correction of some warnings.

-- File Changes --

    M README.md (2)
    M src/net/java/sip/communicator/impl/gui/customcontrols/SIPCommSmartComboBox.java (2)
    M src/net/java/sip/communicator/impl/gui/main/chat/conference/ChatConferenceCallsListModels.java (4)
    M src/net/java/sip/communicator/impl/gui/main/chat/conference/ChatContactListModel.java (2)
    M src/net/java/sip/communicator/impl/gui/main/contactlist/ContactListModel.java (3)
    M src/net/java/sip/communicator/impl/neomedia/CallRecordingConfigForm.java (1)
    M src/net/java/sip/communicator/impl/neomedia/DeviceConfigurationComboBoxModel.java (1)
    M src/net/java/sip/communicator/plugin/advancedconfig/AdvancedConfigurationPanel.java (6)
    M src/net/java/sip/communicator/plugin/contactsourceconfig/ContactSourceConfigForm.java (4)
    M src/net/java/sip/communicator/plugin/dictaccregwizz/StrategiesList.java (4)
    M src/net/java/sip/communicator/plugin/generalconfig/GeneralConfigurationPanel.java (16)
    M src/net/java/sip/communicator/plugin/ldap/configform/DirectorySettingsForm.java (4)
    M src/net/java/sip/communicator/plugin/otr/authdialog/FingerprintAuthenticationPanel.java (11)
    M src/net/java/sip/communicator/plugin/sipaccregwizz/ConnectionPanel.java (14)
    M src/net/java/sip/communicator/plugin/spellcheck/LanguageMenuBar.java (4)
    M src/net/java/sip/communicator/plugin/spellcheck/SpellCheckerConfigDialog.java (7)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/17.patch
https://github.com/jitsi/jitsi/pull/17.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/17


#2

We need to stay compatible with Java 6 for the time being and hence cannot use the generic versions of JComboBox, JList, etc.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/17#issuecomment-36388892


#3

Closed #17.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/17


#4

@@ -173,7 +173,7 @@ public int getSize()
          */
         public int indexOf(String strategyCode)
         {
- for (int i = 0, size = data.size(); i < size; i++)
+ for (int i = 0, size = data.size(); i < size; ++i)

I don't think this change is required - the behaviour should be the same both ways

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/17/files#r10244815


#5

@@ -673,10 +673,10 @@ public int compareTo(LocaleItem o)
         public LanguageDropDownRenderer()
         {
             setLayout(new GridLayout(0, 3));
- for (int i = 0; i < labels.length; i++)
+ for (JLabel label : labels)

I believe this change will cause a bug - the earlier code initializes the array elements, the new code does not.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/17/files#r10244995