[jitsi-dev] [jitsi-commits] master: Removes jdic dependency used for java 1.5 campatibility. Removes duplicate lib commons-logging. Update deb-src build target to fix clean procedure to run building package twice, updates the use of the debian povided bou


#1

Hey

I'm sorry if this mail sounds pedantic or rude, but:

Subject: [jitsi-commits] master: Removes jdic dependency used for java 1.5
campatibility. Removes duplicate lib commons-logging. Update deb-src build
target to fix clean procedure to run building package twice, updates the

use

of the debian povided bouncycastle...

As git allows us to commit locally and modify any commits that went wrong
before pushing them out to the public, huge commits that do multiple things
at once are not necessary. I find them hard to review, ugly and difficult
for research when viewing the history. E.g. this single commit could have
been one for each sentence which would have result in a, small, clean,
contained unit of work.

Sorry again, but I wanted to say this for a long time...

A comment to the actual commit:

diff --git a/.classpath b/.classpath
+ <classpathentry kind="lib" path="lib/installer-exclude/libjitsi.jar"

diff --git a/build.xml b/build.xml
- <srcroot url="file://$MODULE_DIR$/../ice4j/src"/>
+ <srcroot url="file://../ice4j/src"/>
- <srcroot url="file:///libjitsi"/>

Mac specifics?

Regards,
Ingo


#2

Hi,

removing jdic and updating deb-src was supposed to be one change. The
commit is big just because this lib have a lot of files.
Well and all this work is supposed to be one change and is concerning the
current work on the debian package.

What you mean with:
Mac specifics?

Regards
damencho

···

On Tue, Jun 11, 2013 at 4:21 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Hey

I'm sorry if this mail sounds pedantic or rude, but:

> Subject: [jitsi-commits] master: Removes jdic dependency used for java
1.5
> campatibility. Removes duplicate lib commons-logging. Update deb-src
build
> target to fix clean procedure to run building package twice, updates the
use
> of the debian povided bouncycastle...

As git allows us to commit locally and modify any commits that went wrong
before pushing them out to the public, huge commits that do multiple things
at once are not necessary. I find them hard to review, ugly and difficult
for research when viewing the history. E.g. this single commit could have
been one for each sentence which would have result in a, small, clean,
contained unit of work.

Sorry again, but I wanted to say this for a long time...

A comment to the actual commit:

> diff --git a/.classpath b/.classpath
> + <classpathentry kind="lib"
path="lib/installer-exclude/libjitsi.jar"
>
> diff --git a/build.xml b/build.xml
> - <srcroot url="file://$MODULE_DIR$/../ice4j/src"/>
> + <srcroot url="file://../ice4j/src"/>
> - <srcroot url="file:///libjitsi"/>

Mac specifics?

Regards,
Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hey,

you are not rude of course. Sorry.
Just wanted to mention that this whole change started long before the git
era ... :slight_smile:

Regards
damencho

···

On Tue, Jun 11, 2013 at 4:32 PM, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

removing jdic and updating deb-src was supposed to be one change. The
commit is big just because this lib have a lot of files.
Well and all this work is supposed to be one change and is concerning the
current work on the debian package.

What you mean with:
Mac specifics?

Regards
damencho

On Tue, Jun 11, 2013 at 4:21 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Hey

I'm sorry if this mail sounds pedantic or rude, but:

> Subject: [jitsi-commits] master: Removes jdic dependency used for java
1.5
> campatibility. Removes duplicate lib commons-logging. Update deb-src
build
> target to fix clean procedure to run building package twice, updates the
use
> of the debian povided bouncycastle...

As git allows us to commit locally and modify any commits that went wrong
before pushing them out to the public, huge commits that do multiple
things
at once are not necessary. I find them hard to review, ugly and difficult
for research when viewing the history. E.g. this single commit could have
been one for each sentence which would have result in a, small, clean,
contained unit of work.

Sorry again, but I wanted to say this for a long time...

A comment to the actual commit:

> diff --git a/.classpath b/.classpath
> + <classpathentry kind="lib"
path="lib/installer-exclude/libjitsi.jar"
>
> diff --git a/build.xml b/build.xml
> - <srcroot url="file://$MODULE_DIR$/../ice4j/src"/>
> + <srcroot url="file://../ice4j/src"/>
> - <srcroot url="file:///libjitsi"/>

Mac specifics?

Regards,
Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

you are not rude of course. Sorry.
Just wanted to mention that this whole change started long before the git

era

... :slight_smile:

  removing jdic and updating deb-src was supposed to be one change.

The

commit is big just because this lib have a lot of files.
  Well and all this work is supposed to be one change and is

concerning

the current work on the debian package.

Okay then.
I hold my breath for the future commits :wink:

  What you mean with:
  Mac specifics?

Something you accidentally commited? The paths don't make sense on non-Macs
(at least for .classpath, I don't know what $MODULE_DIR$ is, something from
IJ Idea I guess).

  Regards
  damencho

Ingo


#5

Hey,

> you are not rude of course. Sorry.
> Just wanted to mention that this whole change started long before the git
era
> ... :slight_smile:
>
> removing jdic and updating deb-src was supposed to be one change.
The
> commit is big just because this lib have a lot of files.
> Well and all this work is supposed to be one change and is
concerning
> the current work on the debian package.

Okay then.
I hold my breath for the future commits :wink:

Please don't hold, when you see something suspicious or something we can
improve you are of course welcome. Personally I will try to use the local
commits, but sometimes changes are very complicated and as I still don't
fill so comfortable with git, commit at once is the only safe way.

> What you mean with:
> Mac specifics?

Something you accidentally commited? The paths don't make sense on non-Macs
(at least for .classpath, I don't know what $MODULE_DIR$ is, something from
IJ Idea I guess).

Hum, yeah I had some modified files from Idea and I reverted some of the
changes ... but there seems something has went out in public sorry, fixing
it shortly.

Regards
damencho

···

On Tue, Jun 11, 2013 at 4:52 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

> Regards
> damencho

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev