[jitsi-dev] [jitsi-commits] master: Open chat windows minimized when they should not get the focus (ac704e5)


#1

Hmm .... I am a bit nervous about this one. How do others find it? I don't
mind trying it at least for a while though.

Emil

--sent from my mobile

···

On Aug 2, 2013 8:05 PM, <ingo@jitsi.org> wrote:

Repository : ssh://lists.jitsi.org/jitsi

On branch : master
Link :
https://github.com/jitsi/jitsi/compare/f6992df6b806fd36cc9a1f97ad08014a519559c4...ac704e52ae6b94df4c59261aaa487c61dda931bd

>---------------------------------------------------------------

commit ac704e52ae6b94df4c59261aaa487c61dda931bd
Author: Ingo Bauersachs <ingo@jitsi.org>
Date: Fri Aug 2 20:04:47 2013 +0200

    Open chat windows minimized when they should not get the focus

>---------------------------------------------------------------

ac704e52ae6b94df4c59261aaa487c61dda931bd
.../impl/gui/main/chat/ChatWindow.java | 1 +
1 file changed, 1 insertion(+)

diff --git
a/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
b/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
index ac37049..0b99c1d 100644
--- a/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
+++ b/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
@@ -1148,6 +1148,7 @@ public class ChatWindow
             else if (!isWindowVisible)
             {
                 setFocusableWindowState(false);
+ setState(Frame.ICONIFIED);
                 setVisible(true);
                 setFocusableWindowState(true);
             }

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#2

What exactly makes you nervous? Weird window managers?

If it happens to be problematic we can rip it out again or make it optional. And after all, I thought trying things is la raison d'être of two distinct build lines...

Ingo

···

On 02.08.2013, at 22:13, "Emil Ivov" <emcho@jitsi.org> wrote:

Hmm .... I am a bit nervous about this one. How do others find it? I don't mind trying it at least for a while though.

Emil

--sent from my mobile

On Aug 2, 2013 8:05 PM, <ingo@jitsi.org> wrote:

Repository : ssh://lists.jitsi.org/jitsi

On branch : master
Link : https://github.com/jitsi/jitsi/compare/f6992df6b806fd36cc9a1f97ad08014a519559c4...ac704e52ae6b94df4c59261aaa487c61dda931bd

>---------------------------------------------------------------

commit ac704e52ae6b94df4c59261aaa487c61dda931bd
Author: Ingo Bauersachs <ingo@jitsi.org>
Date: Fri Aug 2 20:04:47 2013 +0200

    Open chat windows minimized when they should not get the focus

>---------------------------------------------------------------

ac704e52ae6b94df4c59261aaa487c61dda931bd
.../impl/gui/main/chat/ChatWindow.java | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java b/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
index ac37049..0b99c1d 100644
--- a/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
+++ b/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
@@ -1148,6 +1148,7 @@ public class ChatWindow
             else if (!isWindowVisible)
             {
                 setFocusableWindowState(false);
+ setState(Frame.ICONIFIED);
                 setVisible(true);
                 setFocusableWindowState(true);
             }

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#3

Again, I don't mind trying it and yes, that is indeed why we have the
stables.

I was simply sharing my initial personal user opinion.

What I am worried about is that in some cases we might be relying on seeing
a new window to know that a message has arrived.

I am speaking as an individual.

Speaking as lead, I am perfectly happy going either way depending on what
the majority prefers.

One final note. Some window managers handle this better and don't have the
focus problem (e.g. OS X). We may want to restrict this to those that do.
(Is it only Linux?)

--sent from my mobile

···

On Aug 3, 2013 9:38 AM, "Ingo Bauersachs" <ingo@jitsi.org> wrote:

What exactly makes you nervous? Weird window managers?

If it happens to be problematic we can rip it out again or make it
optional. And after all, I thought trying things is la raison d'être of two
distinct build lines...

Ingo

On 02.08.2013, at 22:13, "Emil Ivov" <emcho@jitsi.org> wrote:

Hmm .... I am a bit nervous about this one. How do others find it? I don't
mind trying it at least for a while though.

Emil

--sent from my mobile
On Aug 2, 2013 8:05 PM, <ingo@jitsi.org> wrote:

Repository : ssh://lists.jitsi.org/jitsi

On branch : master
Link :
https://github.com/jitsi/jitsi/compare/f6992df6b806fd36cc9a1f97ad08014a519559c4...ac704e52ae6b94df4c59261aaa487c61dda931bd

>---------------------------------------------------------------

commit ac704e52ae6b94df4c59261aaa487c61dda931bd
Author: Ingo Bauersachs <ingo@jitsi.org>
Date: Fri Aug 2 20:04:47 2013 +0200

    Open chat windows minimized when they should not get the focus

>---------------------------------------------------------------

ac704e52ae6b94df4c59261aaa487c61dda931bd
.../impl/gui/main/chat/ChatWindow.java | 1 +
1 file changed, 1 insertion(+)

diff --git
a/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
b/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
index ac37049..0b99c1d 100644
--- a/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
+++ b/src/net/java/sip/communicator/impl/gui/main/chat/ChatWindow.java
@@ -1148,6 +1148,7 @@ public class ChatWindow
             else if (!isWindowVisible)
             {
                 setFocusableWindowState(false);
+ setState(Frame.ICONIFIED);
                 setVisible(true);
                 setFocusableWindowState(true);
             }

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Again, I don't mind trying it and yes, that is indeed why we have the
stables.

I was simply sharing my initial personal user opinion.

What I am worried about is that in some cases we might be relying on

seeing a

new window to know that a message has arrived.

Hm, I can't really imagine this situation, but depending on the WM it could
certainly be true.

I am speaking as an individual.

Speaking as lead, I am perfectly happy going either way depending on what

the

majority prefers.

One final note. Some window managers handle this better and don't have the
focus problem (e.g. OS X). We may want to restrict this to those that do.

(Is

it only Linux?)

It's Windows too to some extent: The window appears in front of all others,
but doesn't steal the focus.

Ingo


#5

Hi,

I missed several messages today. Actually on macosx the window can be
seen being minimized and a notification is shown about typing and the
incoming message and after that no indication of unread messages (no
bouncing icon). So if you are not looking at the computer for 10 sec.
you will miss this message.
And on a subsequent messages again no bouncing icon.

Regards
damencho

···

On Sat, Aug 3, 2013 at 11:50 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Again, I don't mind trying it and yes, that is indeed why we have the
stables.

I was simply sharing my initial personal user opinion.

What I am worried about is that in some cases we might be relying on

seeing a

new window to know that a message has arrived.

Hm, I can't really imagine this situation, but depending on the WM it could
certainly be true.

I am speaking as an individual.

Speaking as lead, I am perfectly happy going either way depending on what

the

majority prefers.

One final note. Some window managers handle this better and don't have the
focus problem (e.g. OS X). We may want to restrict this to those that do.

(Is

it only Linux?)

It's Windows too to some extent: The window appears in front of all others,
but doesn't steal the focus.

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

I missed several messages today. Actually on macosx the window can be
seen being minimized and a notification is shown about typing and the
incoming message and after that no indication of unread messages (no
bouncing icon). So if you are not looking at the computer for 10 sec.
you will miss this message.
And on a subsequent messages again no bouncing icon.

Sorry about the overseen messages!

Is it possible that the ChatAlerter plugin is not doing what it should on
OSX? I tried it with a Mac at work and there's indeed the behavior you
describe, but the exact same setup on Windows bounces...

If it's not the ChatAlerter, then one idea would be to call
setState(Frame.ICONIFIED) only on non-mac platforms.

Regards
damencho

Ingo


#7

Hi,

well in ChatAlerter it is:
            if(OSUtils.IS_MAC)
                com.apple.eawt.Application.getApplication()
                    .requestUserAttention(true);
            else
                Alerter.newInstance().alert(fr);

so it seems that iconified windows doesn't bounce the icon...
I think we can change iconified state only for non-mac platforms.

Regards
damencho

···

On Tue, Aug 6, 2013 at 7:14 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

I missed several messages today. Actually on macosx the window can be
seen being minimized and a notification is shown about typing and the
incoming message and after that no indication of unread messages (no
bouncing icon). So if you are not looking at the computer for 10 sec.
you will miss this message.
And on a subsequent messages again no bouncing icon.

Sorry about the overseen messages!

Is it possible that the ChatAlerter plugin is not doing what it should on
OSX? I tried it with a Mac at work and there's indeed the behavior you
describe, but the exact same setup on Windows bounces...

If it's not the ChatAlerter, then one idea would be to call
setState(Frame.ICONIFIED) only on non-mac platforms.

Regards
damencho

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#8

+1. There was no problem on OS X, so a change there isn't really warranted.

I'd also like to hear from other non-mac users if they find this convenient.

I am still nervous about the change so please reassure me that you feel it's better this way :).

Emil

···

On 06.08.13, 11:41, Damian Minkov wrote:

Hi,

well in ChatAlerter it is:
             if(OSUtils.IS_MAC)
                 com.apple.eawt.Application.getApplication()
                     .requestUserAttention(true);
             else
                 Alerter.newInstance().alert(fr);

so it seems that iconified windows doesn't bounce the icon...
I think we can change iconified state only for non-mac platforms.

Regards
damencho

On Tue, Aug 6, 2013 at 7:14 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

I missed several messages today. Actually on macosx the window can be
seen being minimized and a notification is shown about typing and the
incoming message and after that no indication of unread messages (no
bouncing icon). So if you are not looking at the computer for 10 sec.
you will miss this message.
And on a subsequent messages again no bouncing icon.

Sorry about the overseen messages!

Is it possible that the ChatAlerter plugin is not doing what it should on
OSX? I tried it with a Mac at work and there's indeed the behavior you
describe, but the exact same setup on Windows bounces...

If it's not the ChatAlerter, then one idea would be to call
setState(Frame.ICONIFIED) only on non-mac platforms.

Regards
damencho

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#9

+1. There was no problem on OS X, so a change there isn't really

warranted.

Undone for Macs.

I'd also like to hear from other non-mac users if they find this
convenient.

I am still nervous about the change so please reassure me that you feel
it's better this way :).

I don't know the Linux behavior, but on Windows it's definitely much better.

Emil

Hi,

well in ChatAlerter it is:
             if(OSUtils.IS_MAC)
                 com.apple.eawt.Application.getApplication()
                     .requestUserAttention(true);
             else
                 Alerter.newInstance().alert(fr);
so it seems that iconified windows doesn't bounce the icon...

You all know my opinion about Macs... What's the point of a bouncing
indication if it doesn't work for minimized windows!?

I think we can change iconified state only for non-mac platforms.

Ingo

···

On 06.08.13, 11:41, Damian Minkov wrote: