[jitsi-dev] [jitsi-commits] master: Merge pull request #12 from mdzhigarov/otrJitsi (fa69d4d)


#1

Hey George, Marin,

I have two big problems with this commit. The first one is that if someone writes to me, I can't write back, I get errors for all my messages. The second one is that OTR seems to be enabled by default, so each time I write to someone it's active and hence the first problem also becomes very annoying if the other party is using Jitsi. It has become unusable.

I've discussed this one off-list with Marin. He mentioned that the first problem may be related to the fact that I've been connected with the same account from two different locations. He's currently looking at the problem.

Could you please come back to the list as soon as you have something sorted out? If it would take more time we should may be revert the commit.

Cheers,
Yana

···

On 11 Nov 2013, at 22:49, gp@superpointer.com wrote:

Repository : ssh://lists.jitsi.org/jitsi

On branch : master
Link : https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25

---------------------------------------------------------------

commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
Merge: 8ad5e17 67f1d73
Author: gpolitis <gp@superpointer.com>
Date: Mon Nov 11 13:45:49 2013 -0800

   Merge pull request #12 from mdzhigarov/otrJitsi

   Integrates the latest otr4j library and exposes the Socialist Millionaire Protocol (SMP) functionality in Jitsi.

---------------------------------------------------------------

fa69d4d2e75306cc62c949ac70a2d210ce146f25
lib/installer-exclude/otr4j.jar | Bin 74060 -> 86024 bytes
resources/languages/resources.properties | 35 +-
.../plugin/otr/OtrConfigurationPanel.java | 1 +
.../sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
.../communicator/plugin/otr/ScOtrEngineImpl.java | 339 +++++++++++++++++++-
.../communicator/plugin/otr/ScOtrKeyManager.java | 2 +
.../plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
.../plugin/otr/SwingOtrActionHandler.java | 1 +
.../plugin/otr/authdialog/CustomTextArea.java | 26 ++
.../FingerprintAuthenticationPanel.java} | 307 +++++++-----------
.../{ => authdialog}/KnownFingerprintsPanel.java | 3 +-
.../KnownFingerprintsTableModel.java | 3 +-
.../authdialog/OtrBuddyAuthenticationDialog.java | 200 ++++++++++++
.../SecretQuestionAuthenticationPanel.java | 118 +++++++
.../SharedSecretAuthenticationPanel.java | 90 ++++++
.../otr/authdialog/SmpAuthenticateBuddyDialog.java | 202 ++++++++++++
.../plugin/otr/authdialog/SmpProgressDialog.java | 143 +++++++++
.../sip/communicator/plugin/otr/otr.manifest.mf | 2 +
18 files changed, 1334 insertions(+), 193 deletions(-)

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#2

Hello George, all,

Please correct me if I'm wrong but the problem is with Jitsi's default
global otr policy.

Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT which
basically says "send whitespace tags with every message" and also "as soon
as we receive a whitespace tag we should start an otr session".
The thing is... this functionality was not quite working... until now.
When George and I integrated the latest version of otr4j we fixed some
bugs, addressing the processing of whitespace tags and my guess is that it
finally works as expected (which is good news! :slight_smile: ).

This is the reason why OTR is started automatically. If you look at chat
window -> secure chat -> Automatically initiate private messaging, you will
also notice that this is checked.

In order to fix the issues that Yana mentioned I think we have to options -
either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT to something
that suits us (something that does not start otr autimatically), or set
Jitsi's global otr policy to net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL
which already does that.

The first one is that if someone writes to me, I can't write back, I get

errors for all my messages.

My best guess here is that when we're logged in with the same account in
several different istances of Jitsi & chat window -> secure chat ->
Automatically initiate private messaging is checked, these Jitsi instances
simultaneously start trying to initiate OTR with the remote party and this
creates a mess.

I created a small patch that seems to fix these issues.

George, can you please comment this and possibly commit the patch if you
agree that it is the right solution.

Regards,
Marin

otr.patch (2.54 KB)

···

On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hey George, Marin,

I have two big problems with this commit. The first one is that if someone
writes to me, I can't write back, I get errors for all my messages. The
second one is that OTR seems to be enabled by default, so each time I write
to someone it's active and hence the first problem also becomes very
annoying if the other party is using Jitsi. It has become unusable.

I've discussed this one off-list with Marin. He mentioned that the first
problem may be related to the fact that I've been connected with the same
account from two different locations. He's currently looking at the problem.

Could you please come back to the list as soon as you have something
sorted out? If it would take more time we should may be revert the commit.

Cheers,
Yana

On 11 Nov 2013, at 22:49, gp@superpointer.com wrote:

> Repository : ssh://lists.jitsi.org/jitsi
>
> On branch : master
> Link :
https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
>
>> ---------------------------------------------------------------
>
> commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
> Merge: 8ad5e17 67f1d73
> Author: gpolitis <gp@superpointer.com>
> Date: Mon Nov 11 13:45:49 2013 -0800
>
> Merge pull request #12 from mdzhigarov/otrJitsi
>
> Integrates the latest otr4j library and exposes the Socialist
Millionaire Protocol (SMP) functionality in Jitsi.
>
>
>
>> ---------------------------------------------------------------
>
> fa69d4d2e75306cc62c949ac70a2d210ce146f25
> lib/installer-exclude/otr4j.jar | Bin 74060 -> 86024
bytes
> resources/languages/resources.properties | 35 ±
> …/plugin/otr/OtrConfigurationPanel.java | 1 +
> …/sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
> …/communicator/plugin/otr/ScOtrEngineImpl.java | 339
++++++++++++++++++±
> …/communicator/plugin/otr/ScOtrKeyManager.java | 2 +
> …/plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
> …/plugin/otr/SwingOtrActionHandler.java | 1 +
> …/plugin/otr/authdialog/CustomTextArea.java | 26 ++
> …/FingerprintAuthenticationPanel.java} | 307
++++++±----------
> …/{ => authdialog}/KnownFingerprintsPanel.java | 3 ±
> …/KnownFingerprintsTableModel.java | 3 ±
> …/authdialog/OtrBuddyAuthenticationDialog.java | 200 ++++++++++++
> …/SecretQuestionAuthenticationPanel.java | 118 +++++++
> …/SharedSecretAuthenticationPanel.java | 90 ++++++
> …/otr/authdialog/SmpAuthenticateBuddyDialog.java | 202 ++++++++++++
> …/plugin/otr/authdialog/SmpProgressDialog.java | 143 +++++++++
> …/sip/communicator/plugin/otr/otr.manifest.mf | 2 +
> 18 files changed, 1334 insertions(+), 193 deletions(-)
>
>
>
> _______________________________________________
> commits mailing list
> commits@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hello George, all,

Please correct me if I'm wrong but the problem is with Jitsi's default
global otr policy.

Well ... not exactly. The policy is valid and reasonable so I wouldn't call it a problem in anyway. The problem does seem to be a direct consequence however.

Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT
which basically says "send whitespace tags with every message" and also
"as soon as we receive a whitespace tag we should start an otr session".
The thing is... this functionality was not quite working... until now.
When George and I integrated the latest version of otr4j we fixed some
bugs, addressing the processing of whitespace tags and my guess is that
it finally works as expected (which is good news! :slight_smile: ).

It is indeed.

This is the reason why OTR is started automatically. If you look at chat
window -> secure chat -> Automatically initiate private messaging, you
will also notice that this is checked.

In order to fix the issues that Yana mentioned I think we have to
options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT to
something that suits us (something that does not start otr
autimatically), or set Jitsi's global otr policy to
net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.

The current default does suit us. We just need to make it behave.

    The first one is that if someone writes to me, I can't write back, I
    get errors for all my messages.

  My best guess here is that when we're logged in with the same account
in several different istances of Jitsi

How do we handle OTR sessions in this case without the automatic establishment? That is, what happens if I have an OTR sessions established with one device and then I just move to another device. What do we do in such cases?

& chat window -> secure chat ->
Automatically initiate private messaging is checked, these Jitsi
instances simultaneously start trying to initiate OTR with the remote
party and this creates a mess.

I created a small patch that seems to fix these issues.

George, can you please comment this and possibly commit the patch if you
agree that it is the right solution.

Well, again, I'd like us to keep, at least for now, the current default of automatically establishing OTR when possible. We do need to think of a way to fix the auto establishment though.

It seems that the most decent way of handling this would be to make sure we properly establish two separate contexts in case we happen to be talking to more than one instance. Or does OTR support some sort of context sharing in such situations?

How do Adium and Pidgin handle this by the way?

If the above turns out to be too complicated then we could simply delay auto session establishment at the receiving end until we actually send a response (rather than as soon as we get a message with the whitespace tags).

Cheers,
Emil

···

On 12.11.13, 17:01, Marin Dzhigarov wrote:

Regards,
Marin

On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org > <mailto:yana@jitsi.org>> wrote:

    Hey George, Marin,

    I have two big problems with this commit. The first one is that if
    someone writes to me, I can't write back, I get errors for all my
    messages. The second one is that OTR seems to be enabled by default,
    so each time I write to someone it's active and hence the first
    problem also becomes very annoying if the other party is using
    Jitsi. It has become unusable.

    I've discussed this one off-list with Marin. He mentioned that the
    first problem may be related to the fact that I've been connected
    with the same account from two different locations. He's currently
    looking at the problem.

    Could you please come back to the list as soon as you have something
    sorted out? If it would take more time we should may be revert the
    commit.

    Cheers,
    Yana

    On 11 Nov 2013, at 22:49, gp@superpointer.com > <mailto:gp@superpointer.com> wrote:

     > Repository : ssh://lists.jitsi.org/jitsi
    <http://lists.jitsi.org/jitsi>
     >
     > On branch : master
     > Link :
    https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
     >
     >> ---------------------------------------------------------------
     >
     > commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
     > Merge: 8ad5e17 67f1d73
     > Author: gpolitis <gp@superpointer.com <mailto:gp@superpointer.com>>
     > Date: Mon Nov 11 13:45:49 2013 -0800
     >
     > Merge pull request #12 from mdzhigarov/otrJitsi
     >
     > Integrates the latest otr4j library and exposes the Socialist
    Millionaire Protocol (SMP) functionality in Jitsi.
     >
     >> ---------------------------------------------------------------
     >
     > fa69d4d2e75306cc62c949ac70a2d210ce146f25
     > lib/installer-exclude/otr4j.jar | Bin 74060
    -> 86024 bytes
     > resources/languages/resources.properties | 35 ±
     > …/plugin/otr/OtrConfigurationPanel.java | 1 +
     > …/sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
     > …/communicator/plugin/otr/ScOtrEngineImpl.java | 339
    ++++++++++++++++++±
     > …/communicator/plugin/otr/ScOtrKeyManager.java | 2 +
     > …/plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
     > …/plugin/otr/SwingOtrActionHandler.java | 1 +
     > …/plugin/otr/authdialog/CustomTextArea.java | 26 ++
     > …/FingerprintAuthenticationPanel.java} | 307
    ++++++±----------
     > …/{ => authdialog}/KnownFingerprintsPanel.java | 3 ±
     > …/KnownFingerprintsTableModel.java | 3 ±
     > …/authdialog/OtrBuddyAuthenticationDialog.java | 200
    ++++++++++++
     > …/SecretQuestionAuthenticationPanel.java | 118 +++++++
     > …/SharedSecretAuthenticationPanel.java | 90 ++++++
     > …/otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
    ++++++++++++
     > …/plugin/otr/authdialog/SmpProgressDialog.java | 143 +++++++++
     > …/sip/communicator/plugin/otr/otr.manifest.mf | 2 +
     > 18 files changed, 1334 insertions(+), 193 deletions(-)
     >
     > _______________________________________________
     > commits mailing list
     > commits@jitsi.org <mailto:commits@jitsi.org>
     > Unsubscribe instructions and other list options:
     > http://lists.jitsi.org/mailman/listinfo/commits

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>
    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#4

Hello all,

It turns out that starting private conversations with a buddy who is logged
into the same account at multiple locations is not possible with versions
of OTR earlier than 4.0.0. otr4j is currently at version 2.

Source: https://otr.cypherpunks.ca/help/4.0.0/sessions.php?lang=en

Emil, what should we do?

Regards,
Marin

···

On Wed, Nov 13, 2013 at 6:53 AM, Emil Ivov <emcho@jitsi.org> wrote:

On 12.11.13, 17:01, Marin Dzhigarov wrote:

Hello George, all,

Please correct me if I'm wrong but the problem is with Jitsi's default
global otr policy.

Well ... not exactly. The policy is valid and reasonable so I wouldn't
call it a problem in anyway. The problem does seem to be a direct
consequence however.

Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT

which basically says "send whitespace tags with every message" and also
"as soon as we receive a whitespace tag we should start an otr session".
The thing is... this functionality was not quite working... until now.
When George and I integrated the latest version of otr4j we fixed some
bugs, addressing the processing of whitespace tags and my guess is that
it finally works as expected (which is good news! :slight_smile: ).

It is indeed.

This is the reason why OTR is started automatically. If you look at chat

window -> secure chat -> Automatically initiate private messaging, you
will also notice that this is checked.

In order to fix the issues that Yana mentioned I think we have to
options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT to
something that suits us (something that does not start otr
autimatically), or set Jitsi's global otr policy to
net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.

The current default does suit us. We just need to make it behave.

     The first one is that if someone writes to me, I can't write back, I

    get errors for all my messages.

  My best guess here is that when we're logged in with the same account
in several different istances of Jitsi

How do we handle OTR sessions in this case without the automatic
establishment? That is, what happens if I have an OTR sessions established
with one device and then I just move to another device. What do we do in
such cases?

& chat window -> secure chat ->

Automatically initiate private messaging is checked, these Jitsi
instances simultaneously start trying to initiate OTR with the remote
party and this creates a mess.

I created a small patch that seems to fix these issues.

George, can you please comment this and possibly commit the patch if you
agree that it is the right solution.

Well, again, I'd like us to keep, at least for now, the current default of
automatically establishing OTR when possible. We do need to think of a way
to fix the auto establishment though.

It seems that the most decent way of handling this would be to make sure
we properly establish two separate contexts in case we happen to be talking
to more than one instance. Or does OTR support some sort of context sharing
in such situations?

How do Adium and Pidgin handle this by the way?

If the above turns out to be too complicated then we could simply delay
auto session establishment at the receiving end until we actually send a
response (rather than as soon as we get a message with the whitespace tags).

Cheers,
Emil

Regards,

Marin

On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org >> <mailto:yana@jitsi.org>> wrote:

    Hey George, Marin,

    I have two big problems with this commit. The first one is that if
    someone writes to me, I can't write back, I get errors for all my
    messages. The second one is that OTR seems to be enabled by default,
    so each time I write to someone it's active and hence the first
    problem also becomes very annoying if the other party is using
    Jitsi. It has become unusable.

    I've discussed this one off-list with Marin. He mentioned that the
    first problem may be related to the fact that I've been connected
    with the same account from two different locations. He's currently
    looking at the problem.

    Could you please come back to the list as soon as you have something
    sorted out? If it would take more time we should may be revert the
    commit.

    Cheers,
    Yana

    On 11 Nov 2013, at 22:49, gp@superpointer.com >> <mailto:gp@superpointer.com> wrote:

     > Repository : ssh://lists.jitsi.org/jitsi
    <http://lists.jitsi.org/jitsi>

     >
     > On branch : master
     > Link :
    https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2
d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
     >
     >> ---------------------------------------------------------------
     >
     > commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
     > Merge: 8ad5e17 67f1d73
     > Author: gpolitis <gp@superpointer.com <mailto:gp@superpointer.com
>>

     > Date: Mon Nov 11 13:45:49 2013 -0800
     >
     > Merge pull request #12 from mdzhigarov/otrJitsi
     >
     > Integrates the latest otr4j library and exposes the Socialist
    Millionaire Protocol (SMP) functionality in Jitsi.
     >
     >
     >
     >> ---------------------------------------------------------------
     >
     > fa69d4d2e75306cc62c949ac70a2d210ce146f25
     > lib/installer-exclude/otr4j.jar | Bin 74060
    -> 86024 bytes
     > resources/languages/resources.properties | 35 +-
     > .../plugin/otr/OtrConfigurationPanel.java | 1 +
     > .../sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
     > .../communicator/plugin/otr/ScOtrEngineImpl.java | 339
    +++++++++++++++++++-
     > .../communicator/plugin/otr/ScOtrKeyManager.java | 2 +
     > .../plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
     > .../plugin/otr/SwingOtrActionHandler.java | 1 +
     > .../plugin/otr/authdialog/CustomTextArea.java | 26 ++
     > .../FingerprintAuthenticationPanel.java} | 307
    +++++++-----------
     > .../{ => authdialog}/KnownFingerprintsPanel.java | 3 +-
     > .../KnownFingerprintsTableModel.java | 3 +-
     > .../authdialog/OtrBuddyAuthenticationDialog.java | 200
    ++++++++++++
     > .../SecretQuestionAuthenticationPanel.java | 118 +++++++
     > .../SharedSecretAuthenticationPanel.java | 90 ++++++
     > .../otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
    ++++++++++++
     > .../plugin/otr/authdialog/SmpProgressDialog.java | 143
+++++++++
     > .../sip/communicator/plugin/otr/otr.manifest.mf | 2 +
     > 18 files changed, 1334 insertions(+), 193 deletions(-)
     >
     >
     >
     > _______________________________________________
     > commits mailing list
     > commits@jitsi.org <mailto:commits@jitsi.org>

     > Unsubscribe instructions and other list options:
     > http://lists.jitsi.org/mailman/listinfo/commits

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>

    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#5

Hello all,

It turns out that starting private conversations with a buddy who is logged
into the same account at multiple locations is not possible with versions of
OTR earlier than 4.0.0. otr4j is currently at version 2.

Source: https://otr.cypherpunks.ca/help/4.0.0/sessions.php?lang=en

Emil, what should we do?

Well ... XMPP resources allow the detection of multiple session at the
remote side so we should be able to handle this ourselves. Although it
may turn out to be easier to simply implement OTR version 4. Could you
please have a look at this and try to get a feel for the amount of
work involved?

George have you already looked at this?

I'd definitely like us to implement it but if it turns out to be too
convoluted, we would disable automatic establishment and then come
back to it after we are done with DNSSEC.

Emil

···

On Wed, Nov 13, 2013 at 9:36 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:

On Wed, Nov 13, 2013 at 6:53 AM, Emil Ivov <emcho@jitsi.org> wrote:

On 12.11.13, 17:01, Marin Dzhigarov wrote:

Hello George, all,

Please correct me if I'm wrong but the problem is with Jitsi's default
global otr policy.

Well ... not exactly. The policy is valid and reasonable so I wouldn't
call it a problem in anyway. The problem does seem to be a direct
consequence however.

Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT
which basically says "send whitespace tags with every message" and also
"as soon as we receive a whitespace tag we should start an otr session".
The thing is... this functionality was not quite working... until now.
When George and I integrated the latest version of otr4j we fixed some
bugs, addressing the processing of whitespace tags and my guess is that
it finally works as expected (which is good news! :slight_smile: ).

It is indeed.

This is the reason why OTR is started automatically. If you look at chat
window -> secure chat -> Automatically initiate private messaging, you
will also notice that this is checked.

In order to fix the issues that Yana mentioned I think we have to
options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT to
something that suits us (something that does not start otr
autimatically), or set Jitsi's global otr policy to
net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.

The current default does suit us. We just need to make it behave.

    The first one is that if someone writes to me, I can't write back, I
    get errors for all my messages.

  My best guess here is that when we're logged in with the same account
in several different istances of Jitsi

How do we handle OTR sessions in this case without the automatic
establishment? That is, what happens if I have an OTR sessions established
with one device and then I just move to another device. What do we do in
such cases?

& chat window -> secure chat ->
Automatically initiate private messaging is checked, these Jitsi
instances simultaneously start trying to initiate OTR with the remote
party and this creates a mess.

I created a small patch that seems to fix these issues.

George, can you please comment this and possibly commit the patch if you
agree that it is the right solution.

Well, again, I'd like us to keep, at least for now, the current default of
automatically establishing OTR when possible. We do need to think of a way
to fix the auto establishment though.

It seems that the most decent way of handling this would be to make sure
we properly establish two separate contexts in case we happen to be talking
to more than one instance. Or does OTR support some sort of context sharing
in such situations?

How do Adium and Pidgin handle this by the way?

If the above turns out to be too complicated then we could simply delay
auto session establishment at the receiving end until we actually send a
response (rather than as soon as we get a message with the whitespace tags).

Cheers,
Emil

Regards,
Marin

On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org >>> <mailto:yana@jitsi.org>> wrote:

    Hey George, Marin,

    I have two big problems with this commit. The first one is that if
    someone writes to me, I can't write back, I get errors for all my
    messages. The second one is that OTR seems to be enabled by default,
    so each time I write to someone it's active and hence the first
    problem also becomes very annoying if the other party is using
    Jitsi. It has become unusable.

    I've discussed this one off-list with Marin. He mentioned that the
    first problem may be related to the fact that I've been connected
    with the same account from two different locations. He's currently
    looking at the problem.

    Could you please come back to the list as soon as you have something
    sorted out? If it would take more time we should may be revert the
    commit.

    Cheers,
    Yana

    On 11 Nov 2013, at 22:49, gp@superpointer.com >>> <mailto:gp@superpointer.com> wrote:

     > Repository : ssh://lists.jitsi.org/jitsi
    <http://lists.jitsi.org/jitsi>

     >
     > On branch : master
     > Link :

https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
     >
     >> ---------------------------------------------------------------
     >
     > commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
     > Merge: 8ad5e17 67f1d73
     > Author: gpolitis <gp@superpointer.com
<mailto:gp@superpointer.com>>

     > Date: Mon Nov 11 13:45:49 2013 -0800
     >
     > Merge pull request #12 from mdzhigarov/otrJitsi
     >
     > Integrates the latest otr4j library and exposes the Socialist
    Millionaire Protocol (SMP) functionality in Jitsi.
     >
     >
     >
     >> ---------------------------------------------------------------
     >
     > fa69d4d2e75306cc62c949ac70a2d210ce146f25
     > lib/installer-exclude/otr4j.jar | Bin 74060
    -> 86024 bytes
     > resources/languages/resources.properties | 35 +-
     > .../plugin/otr/OtrConfigurationPanel.java | 1 +
     > .../sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
     > .../communicator/plugin/otr/ScOtrEngineImpl.java | 339
    +++++++++++++++++++-
     > .../communicator/plugin/otr/ScOtrKeyManager.java | 2 +
     > .../plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
     > .../plugin/otr/SwingOtrActionHandler.java | 1 +
     > .../plugin/otr/authdialog/CustomTextArea.java | 26 ++
     > .../FingerprintAuthenticationPanel.java} | 307
    +++++++-----------
     > .../{ => authdialog}/KnownFingerprintsPanel.java | 3 +-
     > .../KnownFingerprintsTableModel.java | 3 +-
     > .../authdialog/OtrBuddyAuthenticationDialog.java | 200
    ++++++++++++
     > .../SecretQuestionAuthenticationPanel.java | 118 +++++++
     > .../SharedSecretAuthenticationPanel.java | 90 ++++++
     > .../otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
    ++++++++++++
     > .../plugin/otr/authdialog/SmpProgressDialog.java | 143
+++++++++
     > .../sip/communicator/plugin/otr/otr.manifest.mf | 2 +
     > 18 files changed, 1334 insertions(+), 193 deletions(-)
     >
     >
     >
     > _______________________________________________
     > commits mailing list
     > commits@jitsi.org <mailto:commits@jitsi.org>

     > Unsubscribe instructions and other list options:
     > http://lists.jitsi.org/mailman/listinfo/commits

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>

    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#6

Hi,

if I click on the lock I cannot longer send message. I always get this
error:
" null
hristo@jit.si sent you an unreadable encrypted message."

When clicking on some of the submenus in SecureChat new menus become
visible.
Initially it was like:
<img src=’/uploads/jitsi/original/2X/6/69f63071688b52eed74c4cc9f742c37eba776b2c.png’ width=‘222’ height=‘198’>

end when I clicked enable private messaging it became:

<img src=’/uploads/jitsi/original/2X/5/5d755b2bc5191a1ab15cbafd5c08ffea9c87f85f.png’ width=‘529’ height=‘259’>

And one more, I got some strange combination of menu items which seems a
problem, like I have start and end private conversation at the same time.

<img src=’/uploads/jitsi/original/2X/5/51e7e5c8a4b9ee587b42336e305814a1e6a3fd99.png’ width=‘231’ height=‘140’>

Regards
damencho

···

On Wed, Nov 13, 2013 at 11:01 AM, Emil Ivov <emcho@jitsi.org> wrote:

On Wed, Nov 13, 2013 at 9:36 AM, Marin Dzhigarov <marin@bluejimp.com> > wrote:
> Hello all,
>
> It turns out that starting private conversations with a buddy who is
logged
> into the same account at multiple locations is not possible with
versions of
> OTR earlier than 4.0.0. otr4j is currently at version 2.
>
> Source: https://otr.cypherpunks.ca/help/4.0.0/sessions.php?lang=en
>
> Emil, what should we do?

Well ... XMPP resources allow the detection of multiple session at the
remote side so we should be able to handle this ourselves. Although it
may turn out to be easier to simply implement OTR version 4. Could you
please have a look at this and try to get a feel for the amount of
work involved?

George have you already looked at this?

I'd definitely like us to implement it but if it turns out to be too
convoluted, we would disable automatic establishment and then come
back to it after we are done with DNSSEC.

Emil

> On Wed, Nov 13, 2013 at 6:53 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>>
>>
>> On 12.11.13, 17:01, Marin Dzhigarov wrote:
>>>
>>> Hello George, all,
>>>
>>> Please correct me if I'm wrong but the problem is with Jitsi's default
>>> global otr policy.
>>
>>
>> Well … not exactly. The policy is valid and reasonable so I wouldn't
>> call it a problem in anyway. The problem does seem to be a direct
>> consequence however.
>>
>>
>>> Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT
>>> which basically says "send whitespace tags with every message" and also
>>> "as soon as we receive a whitespace tag we should start an otr
session".
>>> The thing is… this functionality was not quite working… until now.
>>> When George and I integrated the latest version of otr4j we fixed some
>>> bugs, addressing the processing of whitespace tags and my guess is that
>>> it finally works as expected (which is good news! :slight_smile: ).
>>
>>
>> It is indeed.
>>
>>
>>> This is the reason why OTR is started automatically. If you look at
chat
>>> window -> secure chat -> Automatically initiate private messaging, you
>>> will also notice that this is checked.
>>>
>>> In order to fix the issues that Yana mentioned I think we have to
>>> options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT to
>>> something that suits us (something that does not start otr
>>> autimatically), or set Jitsi's global otr policy to
>>> net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.
>>
>>
>> The current default does suit us. We just need to make it behave.
>>
>>
>>> The first one is that if someone writes to me, I can't write back,
I
>>> get errors for all my messages.
>>>
>>> My best guess here is that when we're logged in with the same account
>>> in several different istances of Jitsi
>>
>>
>> How do we handle OTR sessions in this case without the automatic
>> establishment? That is, what happens if I have an OTR sessions
established
>> with one device and then I just move to another device. What do we do in
>> such cases?
>>
>>
>>> & chat window -> secure chat ->
>>> Automatically initiate private messaging is checked, these Jitsi
>>> instances simultaneously start trying to initiate OTR with the remote
>>> party and this creates a mess.
>>>
>>> I created a small patch that seems to fix these issues.
>>>
>>> George, can you please comment this and possibly commit the patch if
you
>>> agree that it is the right solution.
>>
>>
>> Well, again, I'd like us to keep, at least for now, the current default
of
>> automatically establishing OTR when possible. We do need to think of a
way
>> to fix the auto establishment though.
>>
>> It seems that the most decent way of handling this would be to make sure
>> we properly establish two separate contexts in case we happen to be
talking
>> to more than one instance. Or does OTR support some sort of context
sharing
>> in such situations?
>>
>> How do Adium and Pidgin handle this by the way?
>>
>> If the above turns out to be too complicated then we could simply delay
>> auto session establishment at the receiving end until we actually send a
>> response (rather than as soon as we get a message with the whitespace
tags).
>>
>>
>> Cheers,
>> Emil
>>
>>
>>> Regards,
>>> Marin
>>>
>>>
>>> On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org > >>> <mailto:yana@jitsi.org>> wrote:
>>>
>>> Hey George, Marin,
>>>
>>> I have two big problems with this commit. The first one is that if
>>> someone writes to me, I can't write back, I get errors for all my
>>> messages. The second one is that OTR seems to be enabled by
default,
>>> so each time I write to someone it's active and hence the first
>>> problem also becomes very annoying if the other party is using
>>> Jitsi. It has become unusable.
>>>
>>> I've discussed this one off-list with Marin. He mentioned that the
>>> first problem may be related to the fact that I've been connected
>>> with the same account from two different locations. He's currently
>>> looking at the problem.
>>>
>>> Could you please come back to the list as soon as you have
something
>>> sorted out? If it would take more time we should may be revert the
>>> commit.
>>>
>>> Cheers,
>>> Yana
>>>
>>>
>>> On 11 Nov 2013, at 22:49, gp@superpointer.com > >>> <mailto:gp@superpointer.com> wrote:
>>>
>>> > Repository : ssh://lists.jitsi.org/jitsi
>>> <http://lists.jitsi.org/jitsi>
>>>
>>> >
>>> > On branch : master
>>> > Link :
>>>
>>>
https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> >
>>> >> ---------------------------------------------------------------
>>> >
>>> > commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> > Merge: 8ad5e17 67f1d73
>>> > Author: gpolitis <gp@superpointer.com
>>> <mailto:gp@superpointer.com>>
>>>
>>> > Date: Mon Nov 11 13:45:49 2013 -0800
>>> >
>>> > Merge pull request #12 from mdzhigarov/otrJitsi
>>> >
>>> > Integrates the latest otr4j library and exposes the Socialist
>>> Millionaire Protocol (SMP) functionality in Jitsi.
>>> >
>>> >
>>> >
>>> >> ---------------------------------------------------------------
>>> >
>>> > fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> > lib/installer-exclude/otr4j.jar | Bin 74060
>>> -> 86024 bytes
>>> > resources/languages/resources.properties | 35 ±
>>> > …/plugin/otr/OtrConfigurationPanel.java | 1 +
>>> > …/sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
>>> > …/communicator/plugin/otr/ScOtrEngineImpl.java | 339
>>> ++++++++++++++++++±
>>> > …/communicator/plugin/otr/ScOtrKeyManager.java | 2 +
>>> > …/plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
>>> > …/plugin/otr/SwingOtrActionHandler.java | 1 +
>>> > …/plugin/otr/authdialog/CustomTextArea.java | 26 ++
>>> > …/FingerprintAuthenticationPanel.java} | 307
>>> ++++++±----------
>>> > …/{ => authdialog}/KnownFingerprintsPanel.java | 3 ±
>>> > …/KnownFingerprintsTableModel.java | 3 ±
>>> > …/authdialog/OtrBuddyAuthenticationDialog.java | 200
>>> ++++++++++++
>>> > …/SecretQuestionAuthenticationPanel.java | 118
+++++++
>>> > …/SharedSecretAuthenticationPanel.java | 90 ++++++
>>> > …/otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
>>> ++++++++++++
>>> > …/plugin/otr/authdialog/SmpProgressDialog.java | 143
>>> +++++++++
>>> > …/sip/communicator/plugin/otr/otr.manifest.mf | 2 +
>>> > 18 files changed, 1334 insertions(+), 193 deletions(-)
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > commits mailing list
>>> > commits@jitsi.org <mailto:commits@jitsi.org>
>>>
>>> > Unsubscribe instructions and other list options:
>>> > http://lists.jitsi.org/mailman/listinfo/commits
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org <mailto:dev@jitsi.org>
>>>
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>
>> –
>> https://jitsi.org
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Hello Damencho,

And one more, I got some strange combination of menu items which seems a

problem, like I have start and end private conversation at the same time.

As you can see from the screenshot, your session status with the contact
Яна Стамчева is FINISHED. On a FINISHED session status Jitsi was always
showing both start and end private conversation in the menu. This is not
something new. But I agree that this might be a bit confusing. I will have
a look.

If I click on the lock I cannot longer send message. I always get this

error:
" null
hristo@jit.si sent you an unreadable encrypted message."

I'm pretty sure that this is related to the problem with OTRv2 not capable
of managing different sessions for the same account that we discussed in
the previous comments.
Are you sure that you or hristo@jit.si are not logged multiple times with
the same account?

When clicking on some of the submenus in SecureChat new menus become

visible.
Initially it was like:

I can not reproduce this on Windows 7 x64. As I see from the screenshots
this is related to the Mac OS screen menu bar.
Please, can someone who has Mac OS to check what is going on there?

Regards,
Marin

···

On Wed, Nov 13, 2013 at 3:55 PM, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

if I click on the lock I cannot longer send message. I always get this
error:
" null
hristo@jit.si sent you an unreadable encrypted message."

When clicking on some of the submenus in SecureChat new menus become
visible.
Initially it was like:
[image: Inline image 1]

end when I clicked enable private messaging it became:

[image: Inline image 2]

And one more, I got some strange combination of menu items which seems a
problem, like I have start and end private conversation at the same time.

[image: Inline image 1]

Regards
damencho

On Wed, Nov 13, 2013 at 11:01 AM, Emil Ivov <emcho@jitsi.org> wrote:

On Wed, Nov 13, 2013 at 9:36 AM, Marin Dzhigarov <marin@bluejimp.com> >> wrote:
> Hello all,
>
> It turns out that starting private conversations with a buddy who is
logged
> into the same account at multiple locations is not possible with
versions of
> OTR earlier than 4.0.0. otr4j is currently at version 2.
>
> Source: https://otr.cypherpunks.ca/help/4.0.0/sessions.php?lang=en
>
> Emil, what should we do?

Well ... XMPP resources allow the detection of multiple session at the
remote side so we should be able to handle this ourselves. Although it
may turn out to be easier to simply implement OTR version 4. Could you
please have a look at this and try to get a feel for the amount of
work involved?

George have you already looked at this?

I'd definitely like us to implement it but if it turns out to be too
convoluted, we would disable automatic establishment and then come
back to it after we are done with DNSSEC.

Emil

> On Wed, Nov 13, 2013 at 6:53 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>>
>>
>> On 12.11.13, 17:01, Marin Dzhigarov wrote:
>>>
>>> Hello George, all,
>>>
>>> Please correct me if I'm wrong but the problem is with Jitsi's default
>>> global otr policy.
>>
>>
>> Well … not exactly. The policy is valid and reasonable so I wouldn't
>> call it a problem in anyway. The problem does seem to be a direct
>> consequence however.
>>
>>
>>> Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT
>>> which basically says "send whitespace tags with every message" and
also
>>> "as soon as we receive a whitespace tag we should start an otr
session".
>>> The thing is… this functionality was not quite working… until now.
>>> When George and I integrated the latest version of otr4j we fixed some
>>> bugs, addressing the processing of whitespace tags and my guess is
that
>>> it finally works as expected (which is good news! :slight_smile: ).
>>
>>
>> It is indeed.
>>
>>
>>> This is the reason why OTR is started automatically. If you look at
chat
>>> window -> secure chat -> Automatically initiate private messaging, you
>>> will also notice that this is checked.
>>>
>>> In order to fix the issues that Yana mentioned I think we have to
>>> options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT
to
>>> something that suits us (something that does not start otr
>>> autimatically), or set Jitsi's global otr policy to
>>> net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.
>>
>>
>> The current default does suit us. We just need to make it behave.
>>
>>
>>> The first one is that if someone writes to me, I can't write
back, I
>>> get errors for all my messages.
>>>
>>> My best guess here is that when we're logged in with the same
account
>>> in several different istances of Jitsi
>>
>>
>> How do we handle OTR sessions in this case without the automatic
>> establishment? That is, what happens if I have an OTR sessions
established
>> with one device and then I just move to another device. What do we do
in
>> such cases?
>>
>>
>>> & chat window -> secure chat ->
>>> Automatically initiate private messaging is checked, these Jitsi
>>> instances simultaneously start trying to initiate OTR with the remote
>>> party and this creates a mess.
>>>
>>> I created a small patch that seems to fix these issues.
>>>
>>> George, can you please comment this and possibly commit the patch if
you
>>> agree that it is the right solution.
>>
>>
>> Well, again, I'd like us to keep, at least for now, the current
default of
>> automatically establishing OTR when possible. We do need to think of a
way
>> to fix the auto establishment though.
>>
>> It seems that the most decent way of handling this would be to make
sure
>> we properly establish two separate contexts in case we happen to be
talking
>> to more than one instance. Or does OTR support some sort of context
sharing
>> in such situations?
>>
>> How do Adium and Pidgin handle this by the way?
>>
>> If the above turns out to be too complicated then we could simply delay
>> auto session establishment at the receiving end until we actually send
a
>> response (rather than as soon as we get a message with the whitespace
tags).
>>
>>
>> Cheers,
>> Emil
>>
>>
>>> Regards,
>>> Marin
>>>
>>>
>>> On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org >> >>> <mailto:yana@jitsi.org>> wrote:
>>>
>>> Hey George, Marin,
>>>
>>> I have two big problems with this commit. The first one is that if
>>> someone writes to me, I can't write back, I get errors for all my
>>> messages. The second one is that OTR seems to be enabled by
default,
>>> so each time I write to someone it's active and hence the first
>>> problem also becomes very annoying if the other party is using
>>> Jitsi. It has become unusable.
>>>
>>> I've discussed this one off-list with Marin. He mentioned that the
>>> first problem may be related to the fact that I've been connected
>>> with the same account from two different locations. He's currently
>>> looking at the problem.
>>>
>>> Could you please come back to the list as soon as you have
something
>>> sorted out? If it would take more time we should may be revert the
>>> commit.
>>>
>>> Cheers,
>>> Yana
>>>
>>>
>>> On 11 Nov 2013, at 22:49, gp@superpointer.com >> >>> <mailto:gp@superpointer.com> wrote:
>>>
>>> > Repository : ssh://lists.jitsi.org/jitsi
>>> <http://lists.jitsi.org/jitsi>
>>>
>>> >
>>> > On branch : master
>>> > Link :
>>>
>>>
https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> >
>>> >>
---------------------------------------------------------------
>>> >
>>> > commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> > Merge: 8ad5e17 67f1d73
>>> > Author: gpolitis <gp@superpointer.com
>>> <mailto:gp@superpointer.com>>
>>>
>>> > Date: Mon Nov 11 13:45:49 2013 -0800
>>> >
>>> > Merge pull request #12 from mdzhigarov/otrJitsi
>>> >
>>> > Integrates the latest otr4j library and exposes the
Socialist
>>> Millionaire Protocol (SMP) functionality in Jitsi.
>>> >
>>> >
>>> >
>>> >>
---------------------------------------------------------------
>>> >
>>> > fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> > lib/installer-exclude/otr4j.jar | Bin 74060
>>> -> 86024 bytes
>>> > resources/languages/resources.properties | 35 ±
>>> > …/plugin/otr/OtrConfigurationPanel.java | 1 +
>>> > …/sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
>>> > …/communicator/plugin/otr/ScOtrEngineImpl.java | 339
>>> ++++++++++++++++++±
>>> > …/communicator/plugin/otr/ScOtrKeyManager.java | 2 +
>>> > …/plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
>>> > …/plugin/otr/SwingOtrActionHandler.java | 1 +
>>> > …/plugin/otr/authdialog/CustomTextArea.java | 26 ++
>>> > …/FingerprintAuthenticationPanel.java} | 307
>>> ++++++±----------
>>> > …/{ => authdialog}/KnownFingerprintsPanel.java | 3 ±
>>> > …/KnownFingerprintsTableModel.java | 3 ±
>>> > …/authdialog/OtrBuddyAuthenticationDialog.java | 200
>>> ++++++++++++
>>> > …/SecretQuestionAuthenticationPanel.java | 118
+++++++
>>> > …/SharedSecretAuthenticationPanel.java | 90
++++++
>>> > …/otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
>>> ++++++++++++
>>> > …/plugin/otr/authdialog/SmpProgressDialog.java | 143
>>> +++++++++
>>> > …/sip/communicator/plugin/otr/otr.manifest.mf | 2 +
>>> > 18 files changed, 1334 insertions(+), 193 deletions(-)
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > commits mailing list
>>> > commits@jitsi.org <mailto:commits@jitsi.org>
>>>
>>> > Unsubscribe instructions and other list options:
>>> > http://lists.jitsi.org/mailman/listinfo/commits
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org <mailto:dev@jitsi.org>
>>>
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>
>> –
>> https://jitsi.org
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#8

Hello all,

Emil asked me to change the default otr policy so that otr is no longer
automatically initiated.
Because the latest events, we agreed that as long as we do not support the
latest version of the OTR protocol things are better without automatic
initiation.

I'm attaching a patch that cointains the changes. It also contains some
modifications on the otr menu.

Regards,
Marin

otr.patch (7.64 KB)

···

On Thu, Nov 14, 2013 at 9:27 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello Damencho,

And one more, I got some strange combination of menu items which seems a

problem, like I have start and end private conversation at the same time.

As you can see from the screenshot, your session status with the contact
Яна Стамчева is FINISHED. On a FINISHED session status Jitsi was always
showing both start and end private conversation in the menu. This is not
something new. But I agree that this might be a bit confusing. I will have
a look.

If I click on the lock I cannot longer send message. I always get this

error:
" null
hristo@jit.si sent you an unreadable encrypted message."

I'm pretty sure that this is related to the problem with OTRv2 not capable
of managing different sessions for the same account that we discussed in
the previous comments.
Are you sure that you or hristo@jit.si are not logged multiple times with
the same account?

When clicking on some of the submenus in SecureChat new menus become

visible.
Initially it was like:

I can not reproduce this on Windows 7 x64. As I see from the screenshots
this is related to the Mac OS screen menu bar.
Please, can someone who has Mac OS to check what is going on there?

Regards,
Marin

On Wed, Nov 13, 2013 at 3:55 PM, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

if I click on the lock I cannot longer send message. I always get this
error:
" null
hristo@jit.si sent you an unreadable encrypted message."

When clicking on some of the submenus in SecureChat new menus become
visible.
Initially it was like:
[image: Inline image 1]

end when I clicked enable private messaging it became:

[image: Inline image 2]

And one more, I got some strange combination of menu items which seems a
problem, like I have start and end private conversation at the same time.

[image: Inline image 1]

Regards
damencho

On Wed, Nov 13, 2013 at 11:01 AM, Emil Ivov <emcho@jitsi.org> wrote:

On Wed, Nov 13, 2013 at 9:36 AM, Marin Dzhigarov <marin@bluejimp.com> >>> wrote:
> Hello all,
>
> It turns out that starting private conversations with a buddy who is
logged
> into the same account at multiple locations is not possible with
versions of
> OTR earlier than 4.0.0. otr4j is currently at version 2.
>
> Source: https://otr.cypherpunks.ca/help/4.0.0/sessions.php?lang=en
>
> Emil, what should we do?

Well ... XMPP resources allow the detection of multiple session at the
remote side so we should be able to handle this ourselves. Although it
may turn out to be easier to simply implement OTR version 4. Could you
please have a look at this and try to get a feel for the amount of
work involved?

George have you already looked at this?

I'd definitely like us to implement it but if it turns out to be too
convoluted, we would disable automatic establishment and then come
back to it after we are done with DNSSEC.

Emil

> On Wed, Nov 13, 2013 at 6:53 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>>
>>
>> On 12.11.13, 17:01, Marin Dzhigarov wrote:
>>>
>>> Hello George, all,
>>>
>>> Please correct me if I'm wrong but the problem is with Jitsi's
default
>>> global otr policy.
>>
>>
>> Well … not exactly. The policy is valid and reasonable so I wouldn't
>> call it a problem in anyway. The problem does seem to be a direct
>> consequence however.
>>
>>
>>> Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT
>>> which basically says "send whitespace tags with every message" and
also
>>> "as soon as we receive a whitespace tag we should start an otr
session".
>>> The thing is… this functionality was not quite working… until
now.
>>> When George and I integrated the latest version of otr4j we fixed
some
>>> bugs, addressing the processing of whitespace tags and my guess is
that
>>> it finally works as expected (which is good news! :slight_smile: ).
>>
>>
>> It is indeed.
>>
>>
>>> This is the reason why OTR is started automatically. If you look at
chat
>>> window -> secure chat -> Automatically initiate private messaging,
you
>>> will also notice that this is checked.
>>>
>>> In order to fix the issues that Yana mentioned I think we have to
>>> options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT
to
>>> something that suits us (something that does not start otr
>>> autimatically), or set Jitsi's global otr policy to
>>> net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.
>>
>>
>> The current default does suit us. We just need to make it behave.
>>
>>
>>> The first one is that if someone writes to me, I can't write
back, I
>>> get errors for all my messages.
>>>
>>> My best guess here is that when we're logged in with the same
account
>>> in several different istances of Jitsi
>>
>>
>> How do we handle OTR sessions in this case without the automatic
>> establishment? That is, what happens if I have an OTR sessions
established
>> with one device and then I just move to another device. What do we do
in
>> such cases?
>>
>>
>>> & chat window -> secure chat ->
>>> Automatically initiate private messaging is checked, these Jitsi
>>> instances simultaneously start trying to initiate OTR with the remote
>>> party and this creates a mess.
>>>
>>> I created a small patch that seems to fix these issues.
>>>
>>> George, can you please comment this and possibly commit the patch if
you
>>> agree that it is the right solution.
>>
>>
>> Well, again, I'd like us to keep, at least for now, the current
default of
>> automatically establishing OTR when possible. We do need to think of
a way
>> to fix the auto establishment though.
>>
>> It seems that the most decent way of handling this would be to make
sure
>> we properly establish two separate contexts in case we happen to be
talking
>> to more than one instance. Or does OTR support some sort of context
sharing
>> in such situations?
>>
>> How do Adium and Pidgin handle this by the way?
>>
>> If the above turns out to be too complicated then we could simply
delay
>> auto session establishment at the receiving end until we actually
send a
>> response (rather than as soon as we get a message with the whitespace
tags).
>>
>>
>> Cheers,
>> Emil
>>
>>
>>> Regards,
>>> Marin
>>>
>>>
>>> On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org >>> >>> <mailto:yana@jitsi.org>> wrote:
>>>
>>> Hey George, Marin,
>>>
>>> I have two big problems with this commit. The first one is that
if
>>> someone writes to me, I can't write back, I get errors for all my
>>> messages. The second one is that OTR seems to be enabled by
default,
>>> so each time I write to someone it's active and hence the first
>>> problem also becomes very annoying if the other party is using
>>> Jitsi. It has become unusable.
>>>
>>> I've discussed this one off-list with Marin. He mentioned that
the
>>> first problem may be related to the fact that I've been connected
>>> with the same account from two different locations. He's
currently
>>> looking at the problem.
>>>
>>> Could you please come back to the list as soon as you have
something
>>> sorted out? If it would take more time we should may be revert
the
>>> commit.
>>>
>>> Cheers,
>>> Yana
>>>
>>>
>>> On 11 Nov 2013, at 22:49, gp@superpointer.com >>> >>> <mailto:gp@superpointer.com> wrote:
>>>
>>> > Repository : ssh://lists.jitsi.org/jitsi
>>> <http://lists.jitsi.org/jitsi>
>>>
>>> >
>>> > On branch : master
>>> > Link :
>>>
>>>
https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> >
>>> >>
---------------------------------------------------------------
>>> >
>>> > commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> > Merge: 8ad5e17 67f1d73
>>> > Author: gpolitis <gp@superpointer.com
>>> <mailto:gp@superpointer.com>>
>>>
>>> > Date: Mon Nov 11 13:45:49 2013 -0800
>>> >
>>> > Merge pull request #12 from mdzhigarov/otrJitsi
>>> >
>>> > Integrates the latest otr4j library and exposes the
Socialist
>>> Millionaire Protocol (SMP) functionality in Jitsi.
>>> >
>>> >
>>> >
>>> >>
---------------------------------------------------------------
>>> >
>>> > fa69d4d2e75306cc62c949ac70a2d210ce146f25
>>> > lib/installer-exclude/otr4j.jar | Bin
74060
>>> -> 86024 bytes
>>> > resources/languages/resources.properties | 35 ±
>>> > …/plugin/otr/OtrConfigurationPanel.java | 1 +
>>> > …/sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
>>> > …/communicator/plugin/otr/ScOtrEngineImpl.java | 339
>>> ++++++++++++++++++±
>>> > …/communicator/plugin/otr/ScOtrKeyManager.java | 2 +
>>> > …/plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
>>> > …/plugin/otr/SwingOtrActionHandler.java | 1 +
>>> > …/plugin/otr/authdialog/CustomTextArea.java | 26 ++
>>> > …/FingerprintAuthenticationPanel.java} | 307
>>> ++++++±----------
>>> > …/{ => authdialog}/KnownFingerprintsPanel.java | 3 ±
>>> > …/KnownFingerprintsTableModel.java | 3 ±
>>> > …/authdialog/OtrBuddyAuthenticationDialog.java | 200
>>> ++++++++++++
>>> > …/SecretQuestionAuthenticationPanel.java | 118
+++++++
>>> > …/SharedSecretAuthenticationPanel.java | 90
++++++
>>> > …/otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
>>> ++++++++++++
>>> > …/plugin/otr/authdialog/SmpProgressDialog.java | 143
>>> +++++++++
>>> > …/sip/communicator/plugin/otr/otr.manifest.mf | 2 +
>>> > 18 files changed, 1334 insertions(+), 193 deletions(-)
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > commits mailing list
>>> > commits@jitsi.org <mailto:commits@jitsi.org>
>>>
>>> > Unsubscribe instructions and other list options:
>>> > http://lists.jitsi.org/mailman/listinfo/commits
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org <mailto:dev@jitsi.org>
>>>
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>>
>>
>> –
>> https://jitsi.org
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev