On 12.11.13, 17:01, Marin Dzhigarov wrote:
Hello George, all,
Please correct me if I'm wrong but the problem is with Jitsi's default
global otr policy.
Well ... not exactly. The policy is valid and reasonable so I wouldn't
call it a problem in anyway. The problem does seem to be a direct
consequence however.
Since always this otr policy was set to OtrPolicy.OTR_POLICY_DEFAULT
which basically says "send whitespace tags with every message" and also
"as soon as we receive a whitespace tag we should start an otr session".
The thing is... this functionality was not quite working... until now.
When George and I integrated the latest version of otr4j we fixed some
bugs, addressing the processing of whitespace tags and my guess is that
it finally works as expected (which is good news! 
).
It is indeed.
This is the reason why OTR is started automatically. If you look at chat
window -> secure chat -> Automatically initiate private messaging, you
will also notice that this is checked.
In order to fix the issues that Yana mentioned I think we have to
options - either change net.java.otr4j.OtrPolicy.OTRL_POLICY_DEFAULT to
something that suits us (something that does not start otr
autimatically), or set Jitsi's global otr policy to
net.java.otr4j.OtrPolicy.OTRL_POLICY_MANUAL which already does that.
The current default does suit us. We just need to make it behave.
The first one is that if someone writes to me, I can't write back, I
get errors for all my messages.
My best guess here is that when we're logged in with the same account
in several different istances of Jitsi
How do we handle OTR sessions in this case without the automatic
establishment? That is, what happens if I have an OTR sessions established
with one device and then I just move to another device. What do we do in
such cases?
& chat window -> secure chat ->
Automatically initiate private messaging is checked, these Jitsi
instances simultaneously start trying to initiate OTR with the remote
party and this creates a mess.
I created a small patch that seems to fix these issues.
George, can you please comment this and possibly commit the patch if you
agree that it is the right solution.
Well, again, I'd like us to keep, at least for now, the current default of
automatically establishing OTR when possible. We do need to think of a way
to fix the auto establishment though.
It seems that the most decent way of handling this would be to make sure
we properly establish two separate contexts in case we happen to be talking
to more than one instance. Or does OTR support some sort of context sharing
in such situations?
How do Adium and Pidgin handle this by the way?
If the above turns out to be too complicated then we could simply delay
auto session establishment at the receiving end until we actually send a
response (rather than as soon as we get a message with the whitespace tags).
Cheers,
Emil
Regards,
Marin
On Tue, Nov 12, 2013 at 4:54 PM, Yana Stamcheva <yana@jitsi.org >> <mailto:yana@jitsi.org>> wrote:
Hey George, Marin,
I have two big problems with this commit. The first one is that if
someone writes to me, I can't write back, I get errors for all my
messages. The second one is that OTR seems to be enabled by default,
so each time I write to someone it's active and hence the first
problem also becomes very annoying if the other party is using
Jitsi. It has become unusable.
I've discussed this one off-list with Marin. He mentioned that the
first problem may be related to the fact that I've been connected
with the same account from two different locations. He's currently
looking at the problem.
Could you please come back to the list as soon as you have something
sorted out? If it would take more time we should may be revert the
commit.
Cheers,
Yana
On 11 Nov 2013, at 22:49, gp@superpointer.com >> <mailto:gp@superpointer.com> wrote:
> Repository : ssh://lists.jitsi.org/jitsi
<http://lists.jitsi.org/jitsi>
>
> On branch : master
> Link :
https://github.com/jitsi/jitsi/compare/8ad5e173d8ef296c3aa72ddc2214a2
d93552b024...fa69d4d2e75306cc62c949ac70a2d210ce146f25
>
>> ---------------------------------------------------------------
>
> commit fa69d4d2e75306cc62c949ac70a2d210ce146f25
> Merge: 8ad5e17 67f1d73
> Author: gpolitis <gp@superpointer.com <mailto:gp@superpointer.com
>>
> Date: Mon Nov 11 13:45:49 2013 -0800
>
> Merge pull request #12 from mdzhigarov/otrJitsi
>
> Integrates the latest otr4j library and exposes the Socialist
Millionaire Protocol (SMP) functionality in Jitsi.
>
>
>
>> ---------------------------------------------------------------
>
> fa69d4d2e75306cc62c949ac70a2d210ce146f25
> lib/installer-exclude/otr4j.jar | Bin 74060
-> 86024 bytes
> resources/languages/resources.properties | 35 +-
> .../plugin/otr/OtrConfigurationPanel.java | 1 +
> .../sip/communicator/plugin/otr/ScOtrEngine.java | 35 ++
> .../communicator/plugin/otr/ScOtrEngineImpl.java | 339
+++++++++++++++++++-
> .../communicator/plugin/otr/ScOtrKeyManager.java | 2 +
> .../plugin/otr/ScOtrKeyManagerImpl.java | 20 ++
> .../plugin/otr/SwingOtrActionHandler.java | 1 +
> .../plugin/otr/authdialog/CustomTextArea.java | 26 ++
> .../FingerprintAuthenticationPanel.java} | 307
+++++++-----------
> .../{ => authdialog}/KnownFingerprintsPanel.java | 3 +-
> .../KnownFingerprintsTableModel.java | 3 +-
> .../authdialog/OtrBuddyAuthenticationDialog.java | 200
++++++++++++
> .../SecretQuestionAuthenticationPanel.java | 118 +++++++
> .../SharedSecretAuthenticationPanel.java | 90 ++++++
> .../otr/authdialog/SmpAuthenticateBuddyDialog.java | 202
++++++++++++
> .../plugin/otr/authdialog/SmpProgressDialog.java | 143
+++++++++
> .../sip/communicator/plugin/otr/otr.manifest.mf | 2 +
> 18 files changed, 1334 insertions(+), 193 deletions(-)
>
>
>
> _______________________________________________
> commits mailing list
> commits@jitsi.org <mailto:commits@jitsi.org>
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/commits
_______________________________________________
dev mailing list
dev@jitsi.org <mailto:dev@jitsi.org>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
--
https://jitsi.org
).
).
