[jitsi-dev] [jitsi-commits] master: Fixes index out of bounds exception in call history service. (744d44d)


#1

Hey Hristo

These call history changes causes exceptions:

20:51:52.975 SEVERE: [122] util.UtilActivator.uncaughtException().108 An
uncaught exception occurred in thread=Thread[Thread-48,6,main] and message
was: null
java.lang.NullPointerException
  at
net.java.sip.communicator.impl.callhistory.CallHistoryServiceImpl.convertHis
toryRecordToCallRecord(CallHistoryServiceImpl.java:490)
  at
net.java.sip.communicator.impl.callhistory.CallHistoryQueryImpl$1.historyRec
ordReceived(CallHistoryQueryImpl.java:45)
  at
net.java.sip.communicator.impl.history.HistoryQueryImpl.fireQueryEvent(Histo
ryQueryImpl.java:154)
  at
net.java.sip.communicator.impl.history.HistoryQueryImpl.addHistoryRecord(His
toryQueryImpl.java:128)
  at
net.java.sip.communicator.impl.history.InteractiveHistoryReaderImpl.find(Int
eractiveHistoryReaderImpl.java:186)
  at
net.java.sip.communicator.impl.history.InteractiveHistoryReaderImpl.access$0
(InteractiveHistoryReaderImpl.java:134)
  at
net.java.sip.communicator.impl.history.InteractiveHistoryReaderImpl$1.run(In
teractiveHistoryReaderImpl.java:116)

Could you please take a look?

Ingo

From: commits-bounces@jitsi.org [mailto:commits-bounces@jitsi.org] On

Behalf

Of hristo@jitsi.org
Sent: Montag, 17. Februar 2014 17:45
To: commits@jitsi.org
Subject: [jitsi-commits] master: Fixes index out of bounds exception in

call

···

-----Original Message-----
history service. (744d44d)
Repository : ssh://lists.jitsi.org/jitsi

On branch : master Link :
https://github.com/jitsi/jitsi/compare/8ddaf872ed7efbf58023fb1d7616eea350
5531 94...744d44d3f297722102cff95df7497b6deb6611e7

wrote on uthor: hristoterezov <hristo@jitsi.org>:

---------------------------------------------------------------

744d44d3f297722102cff95df7497b6deb6611e7
.../impl/callhistory/CallHistoryServiceImpl.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava
b/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava index 5a61f07..cd91110 100644 ---
a/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava +++
b/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava @@ -486,7 +486,10 @@ public class CallHistoryServiceImpl
                     callPeerStartValue,
                     callPeerEndValue);
- String callPeerSecondaryID = callPeerSecondaryIDs.get(i);
+ String callPeerSecondaryID = null;
+ if(!callPeerSecondaryIDs.isEmpty())
+ callPeerSecondaryID = callPeerSecondaryIDs.get(i);
+
             if(callPeerSecondaryID != null &&
             !callPeerSecondaryID.equals("")) {
                 cpr.setPeerSecondaryAddress(callPeerSecondaryID);

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#2

Hey Ingo,

I just committed a fix. The changes will be available in the next build.

Thanks for the report and sorry for the inconvenience.

Regards,
Hristo.

···

On Feb 17, 2014, at 9:56 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Hey Hristo

These call history changes causes exceptions:

20:51:52.975 SEVERE: [122] util.UtilActivator.uncaughtException().108 An
uncaught exception occurred in thread=Thread[Thread-48,6,main] and message
was: null
java.lang.NullPointerException
  at
net.java.sip.communicator.impl.callhistory.CallHistoryServiceImpl.convertHis
toryRecordToCallRecord(CallHistoryServiceImpl.java:490)
  at
net.java.sip.communicator.impl.callhistory.CallHistoryQueryImpl$1.historyRec
ordReceived(CallHistoryQueryImpl.java:45)
  at
net.java.sip.communicator.impl.history.HistoryQueryImpl.fireQueryEvent(Histo
ryQueryImpl.java:154)
  at
net.java.sip.communicator.impl.history.HistoryQueryImpl.addHistoryRecord(His
toryQueryImpl.java:128)
  at
net.java.sip.communicator.impl.history.InteractiveHistoryReaderImpl.find(Int
eractiveHistoryReaderImpl.java:186)
  at
net.java.sip.communicator.impl.history.InteractiveHistoryReaderImpl.access$0
(InteractiveHistoryReaderImpl.java:134)
  at
net.java.sip.communicator.impl.history.InteractiveHistoryReaderImpl$1.run(In
teractiveHistoryReaderImpl.java:116)

Could you please take a look?

Ingo

-----Original Message-----
From: commits-bounces@jitsi.org [mailto:commits-bounces@jitsi.org] On

Behalf

Of hristo@jitsi.org
Sent: Montag, 17. Februar 2014 17:45
To: commits@jitsi.org
Subject: [jitsi-commits] master: Fixes index out of bounds exception in

call

history service. (744d44d)
Repository : ssh://lists.jitsi.org/jitsi

On branch : master Link :
https://github.com/jitsi/jitsi/compare/8ddaf872ed7efbf58023fb1d7616eea350
5531 94...744d44d3f297722102cff95df7497b6deb6611e7

wrote on uthor: hristoterezov <hristo@jitsi.org>:

---------------------------------------------------------------

744d44d3f297722102cff95df7497b6deb6611e7
.../impl/callhistory/CallHistoryServiceImpl.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava
b/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava index 5a61f07..cd91110 100644 ---
a/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava +++
b/src/net/java/sip/communicator/impl/callhistory/CallHistoryServiceImpl.j
ava @@ -486,7 +486,10 @@ public class CallHistoryServiceImpl
                    callPeerStartValue,
                    callPeerEndValue);
- String callPeerSecondaryID = callPeerSecondaryIDs.get(i);
+ String callPeerSecondaryID = null;
+ if(!callPeerSecondaryIDs.isEmpty())
+ callPeerSecondaryID = callPeerSecondaryIDs.get(i);
+
            if(callPeerSecondaryID != null &&
            !callPeerSecondaryID.equals("")) {
                cpr.setPeerSecondaryAddress(callPeerSecondaryID);

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev