[jitsi-dev] [jitsi-commits] master: Cleans up code, fixes javadocs, applies tiny optimizations. (3b83284)


#1

Hey

Subject: [jitsi-commits] master: Cleans up code, fixes javadocs, applies

tiny

optimizations.

Lyubomir's last two commits are just impossible to review due to the
reformatting. While I acknowledge that the code was probably not correctly
formatted, applying an auto-formatter together with other changes is
dangerous. Our code convention even forbids using an auto-formatter on
existing code:

"Note: However please do not use the "auto format" on existing code!" [1]

If it is really seen as necessary to reformat the existing codebase, then
please do it once and for all as a one-time-gigantic-reformat commit that
does absolutely nothing else.

Besides that, the code formatter provided for Eclipse doesn't format the
code the same way as Lyubomir's commits were doing it. So conflicts are
guaranteed to come up again as long as a plugin like StyleCop doesn't exist
for Java (I know and use Checkstyle, it's child's play compared to
StyleCop). But it would be a good option to start with.

So in short: Please stop reformatting existing code.

Ingo

[1] https://jitsi.org/Documentation/CodeConvention


#2

I did not use auto-formatting, I manually formatted specific pieces of
code which I had to read and understand while working on a specific
task.


#3

Disagreed.

While I understand the pain of reviewing a change that also contains noise, and I do encourage developers to separate the two when ever possible, formatting existing code is in now way prohibited. If it breaks the convention then it simply MUST be done.

Obviously it would be better if conventions are respected on the first commit, but I do consider conventions important and I don't want code to be viewed as fixed in stone in any way.

While reviewing is important writing the code is significantly more so and I am very reluctant to impose any rules that would hamper that part of the process.

Emil

ยทยทยท

On 28.08.13, 23:09, Ingo Bauersachs wrote:

So in short: Please stop reformatting existing code.

--
https://jitsi.org