[jitsi-dev] [jitsi-commits] master: Changes the implementation of "Contacts" group. (a2ac6e0)


#1

Hristo, I see two issues with the arrow/> in front of the Contacts
group and I'd like to ask whether these are intentional:

1. The Chat rooms and Contacts groups are expanded by default.
However, the Chat rooms group has the arrow pointing downwards and the
Contacts group has it pointing to the right.

2. Clicking the arrow in front of the Contacts group has no effect whatsoever.

···

2013/12/16 <hristo@jitsi.org>:

Repository : ssh://lists.jitsi.org/jitsi

On branch : master
Link : https://github.com/jitsi/jitsi/compare/0cd1075f19f17c82d63f708279b9afb4bf960a8e...a2ac6e081c44681aeff8052e1a4ebcdacb8ff252

---------------------------------------------------------------

commit a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
Author: hristoterezov <hristo@jitsi.org>
Date: Mon Dec 16 18:44:03 2013 +0200

    Changes the implementation of "Contacts" group.


#2

The Contacts group isn't expandable. It is always expanded.

Maybe I should remove the arrow. What do you think?

···

On Tue, Dec 17, 2013 at 11:43 AM, Lyubomir Marinov < lyubomir.marinov@jitsi.org> wrote:

2013/12/16 <hristo@jitsi.org>:
> Repository : ssh://lists.jitsi.org/jitsi
>
> On branch : master
> Link :
https://github.com/jitsi/jitsi/compare/0cd1075f19f17c82d63f708279b9afb4bf960a8e...a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
>
>>---------------------------------------------------------------
>
> commit a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
> Author: hristoterezov <hristo@jitsi.org>
> Date: Mon Dec 16 18:44:03 2013 +0200
>
> Changes the implementation of "Contacts" group.

Hristo, I see two issues with the arrow/> in front of the Contacts
group and I'd like to ask whether these are intentional:

1. The Chat rooms and Contacts groups are expanded by default.
However, the Chat rooms group has the arrow pointing downwards and the
Contacts group has it pointing to the right.

2. Clicking the arrow in front of the Contacts group has no effect
whatsoever.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Regards,
Hristo.


#3

The arrow indicates that an expansion is possible so yes, we should remove it.

···

On Tue, Dec 17, 2013 at 11:34 AM, Hristo Terezov <hristo@jitsi.org> wrote:

The Contacts group isn't expandable. It is always expanded.

Maybe I should remove the arrow. What do you think?

On Tue, Dec 17, 2013 at 11:43 AM, Lyubomir Marinov > <lyubomir.marinov@jitsi.org> wrote:

2013/12/16 <hristo@jitsi.org>:
> Repository : ssh://lists.jitsi.org/jitsi
>
> On branch : master
> Link :
> https://github.com/jitsi/jitsi/compare/0cd1075f19f17c82d63f708279b9afb4bf960a8e...a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
>
>>---------------------------------------------------------------
>
> commit a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
> Author: hristoterezov <hristo@jitsi.org>
> Date: Mon Dec 16 18:44:03 2013 +0200
>
> Changes the implementation of "Contacts" group.

Hristo, I see two issues with the arrow/> in front of the Contacts
group and I'd like to ask whether these are intentional:

1. The Chat rooms and Contacts groups are expanded by default.
However, the Chat rooms group has the arrow pointing downwards and the
Contacts group has it pointing to the right.

2. Clicking the arrow in front of the Contacts group has no effect
whatsoever.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Regards,
Hristo.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#4

The arrow is removed in the last commit.

···

On Tue, Dec 17, 2013 at 12:42 PM, Emil Ivov <emcho@jitsi.org> wrote:

The arrow indicates that an expansion is possible so yes, we should remove
it.

On Tue, Dec 17, 2013 at 11:34 AM, Hristo Terezov <hristo@jitsi.org> wrote:
> The Contacts group isn't expandable. It is always expanded.
>
> Maybe I should remove the arrow. What do you think?
>
>
> On Tue, Dec 17, 2013 at 11:43 AM, Lyubomir Marinov > > <lyubomir.marinov@jitsi.org> wrote:
>>
>> 2013/12/16 <hristo@jitsi.org>:
>> > Repository : ssh://lists.jitsi.org/jitsi
>> >
>> > On branch : master
>> > Link :
>> >
https://github.com/jitsi/jitsi/compare/0cd1075f19f17c82d63f708279b9afb4bf960a8e...a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
>> >
>> >>---------------------------------------------------------------
>> >
>> > commit a2ac6e081c44681aeff8052e1a4ebcdacb8ff252
>> > Author: hristoterezov <hristo@jitsi.org>
>> > Date: Mon Dec 16 18:44:03 2013 +0200
>> >
>> > Changes the implementation of "Contacts" group.
>>
>> Hristo, I see two issues with the arrow/> in front of the Contacts
>> group and I'd like to ask whether these are intentional:
>>
>> 1. The Chat rooms and Contacts groups are expanded by default.
>> However, the Chat rooms group has the arrow pointing downwards and the
>> Contacts group has it pointing to the right.
>>
>> 2. Clicking the arrow in front of the Contacts group has no effect
>> whatsoever.
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
>
> –
> Regards,
> Hristo.
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Regards,
Hristo.