[jitsi-dev] [jitsi-commits] master: Adds the possibility to edit account details. Patch provided by Marin Dzhigarov on dev (Nov 8, 2013). (d55b3ef)


#1

Hi Marin,

             try
             {
                 tmp = card.getField("URL");
                 if(tmp != null)
- result.add(new WebPageDetail(new URL(tmp)));
+ result.add(new URLDetail("URL", new URL(tmp)));

Emil pinged me today that web buttons are no longer working and I
discovered they are broken because in the UI we are looking for
webpage detail and this was changed, at least for the xmpp contacts.

When you change such things, please check where are they used. For
example in this case you can check the places where WebPageDetail is
used. Or at least ask other devs, thanks.

I'm going to change the UI to use URLDetail cause it is more general
and can display and other url details and will also include
WebPageDetails.

Regards
damencho

···

On Tue, Nov 12, 2013 at 11:53 PM, <yana@jitsi.org> wrote:


#2

Hello damencho,

Thank you for fixing the issue!
I'll try to be more careful the next time I do such a change.

Regards,
Marin

···

On Wed, Nov 27, 2013 at 5:58 PM, Damian Minkov <damencho@jitsi.org> wrote:

Hi Marin,

On Tue, Nov 12, 2013 at 11:53 PM, <yana@jitsi.org> wrote:
> try
> {
> tmp = card.getField("URL");
> if(tmp != null)
> - result.add(new WebPageDetail(new URL(tmp)));
> + result.add(new URLDetail("URL", new URL(tmp)));

Emil pinged me today that web buttons are no longer working and I
discovered they are broken because in the UI we are looking for
webpage detail and this was changed, at least for the xmpp contacts.

When you change such things, please check where are they used. For
example in this case you can check the places where WebPageDetail is
used. Or at least ask other devs, thanks.

I'm going to change the UI to use URLDetail cause it is more general
and can display and other url details and will also include
WebPageDetails.

Regards
damencho

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev