[jitsi-dev] [jitsi-commits] ice: Suppresses deprecation warning. Nothing we could do about it for the time being. (aa582db)


#1

I'm not so Mac savy, but can't we use

java.awt.Desktop.browse() and java.awt.Desktop.open()

now that we're on Java 1.6?

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

···

Le 24.06.2013 à 02:45, "emcho@jitsi.org" <emcho@jitsi.org> a écrit :

Repository : ssh://lists.jitsi.org/jitsi

On branch : ice
Link : https://github.com/jitsi/jitsi/compare/3f93890c7237f1b8630724eceff0a384280b5cd4...3a4eb8552493980e2eab5ad084890f3f8b7cc43c

---------------------------------------------------------------

commit aa582db461e52825c83f23609ea68f187d75bc8c
Author: Emil Ivov <emcho@jitsi.org>
Date: Sun Jun 23 18:37:43 2013 +0200

   Suppresses deprecation warning. Nothing we could do about it for the time being.

---------------------------------------------------------------

aa582db461e52825c83f23609ea68f187d75bc8c
.../sip/communicator/launcher/BrowserLauncher.java | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/net/java/sip/communicator/launcher/BrowserLauncher.java b/src/net/java/sip/communicator/launcher/BrowserLauncher.java
index 7cb5fc9..58ccb05 100644
--- a/src/net/java/sip/communicator/launcher/BrowserLauncher.java
+++ b/src/net/java/sip/communicator/launcher/BrowserLauncher.java
@@ -51,6 +51,7 @@ public class BrowserLauncher
         * FileProtocolHandler to do so, on Linux, loops through a list of
         * known browsers until we find one that seems to work.
         */
+ @SuppressWarnings("deprecation") //FileManager.openURL - no choice
        public void run()
        {
            try

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#2

I'm not so Mac savy, but can't we use

java.awt.Desktop.browse() and java.awt.Desktop.open()

now that we're on Java 1.6?

We probably could indeed.

Emil

···

On 24.06.13, 09:16, Ingo Bauersachs wrote:

Freundliche Grüsse,
Ingo Bauersachs

-- sent from my mobile

Le 24.06.2013 à 02:45, "emcho@jitsi.org <mailto:emcho@jitsi.org>" > <emcho@jitsi.org <mailto:emcho@jitsi.org>> a écrit :

Repository : ssh://lists.jitsi.org/jitsi

On branch : ice
Link :
https://github.com/jitsi/jitsi/compare/3f93890c7237f1b8630724eceff0a384280b5cd4...3a4eb8552493980e2eab5ad084890f3f8b7cc43c

---------------------------------------------------------------

commit aa582db461e52825c83f23609ea68f187d75bc8c
Author: Emil Ivov <emcho@jitsi.org <mailto:emcho@jitsi.org>>
Date: Sun Jun 23 18:37:43 2013 +0200

   Suppresses deprecation warning. Nothing we could do about it for
the time being.

---------------------------------------------------------------

aa582db461e52825c83f23609ea68f187d75bc8c
.../sip/communicator/launcher/BrowserLauncher.java | 1 +
1 file changed, 1 insertion(+)

diff --git
a/src/net/java/sip/communicator/launcher/BrowserLauncher.java
b/src/net/java/sip/communicator/launcher/BrowserLauncher.java
index 7cb5fc9..58ccb05 100644
--- a/src/net/java/sip/communicator/launcher/BrowserLauncher.java
+++ b/src/net/java/sip/communicator/launcher/BrowserLauncher.java
@@ -51,6 +51,7 @@ public class BrowserLauncher
         * FileProtocolHandler to do so, on Linux, loops through a list of
         * known browsers until we find one that seems to work.
         */
+ @SuppressWarnings("deprecation") //FileManager.openURL - no
choice
        public void run()
        {
            try

_______________________________________________
commits mailing list
commits@jitsi.org <mailto:commits@jitsi.org>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#3

I'm not so Mac savy, but can't we use

java.awt.Desktop.browse() and java.awt.Desktop.open()

now that we're on Java 1.6?

We probably could indeed.

I was looking at this again and I have the impression that we either need to
stick with it or throw it away completely:
- BrowserLauncher is only referenced from ChangeJVMFrame
- ChangeJVMFrame by main(...) when the JVM is 1.4

Well, as I said, I don't know Macs, but I don't think there's an installed
1.4 around anywhere. Even if it's the case, doesn't our installer/.dmg take
care of notifying the user that a certain Java is required?

Emil

Ingo

···

On 24.06.13, 09:16, Ingo Bauersachs wrote: