[jitsi-dev] Jitsi Client: Rescaling ToolTip of contacts with large avatars


#1

Hi devs,

For a long time the tool tip of the jitsi client's contact list has
bothered me:

Whenever I hover over a contact that has a large avatar image,
the tool tip gets re-scaled in order to fit the whole avatar image.
So the tool tip might as well take up the whole screen of your monitor.
Not only that, but a large image takes up some considerable amount of time
to be drawn on the screen so this effectively blocks the whole EDT.

I would love to fix this myself but as far as I remember there were some
policy changes regarding who has rights to commit and I think I no longer
have write access to the Jitsi repo.

The relevant code is in:
net.java.sip.communicator.impl.gui.main.contactlist.contactsource.MetaUIContact#getToolTip()

Fix:
@Override
    public ExtendedTooltip getToolTip()
    {
        ExtendedTooltip tip = new ExtendedTooltip(true);

        tip.setImage(getScaledAvatar(true, 30, 30));

        tip.setTitle(metaContact.getDisplayName());

        loadTooltip(tip);

        return tip;
    }

I would appreciate it if someone can commit this :slight_smile:
Thank you!

Best regards,
Marin


#2

Hey Marin,

The fact that we had accepted you as a developer had never changed :slight_smile:
You still have write access to the repos.
The only thing that changed is that in repos other than jitsi desktop
client we create PRs and at least one person needs to review it before
merging it.
So feel free to directly commit the changes yourself in the desktop client.

Regards
damencho

···

On Fri, May 5, 2017 at 7:21 AM, Marin Dzhigarov <m.dzhigarov@gmail.com> wrote:

Hi devs,

For a long time the tool tip of the jitsi client's contact list has bothered
me:

Whenever I hover over a contact that has a large avatar image,
the tool tip gets re-scaled in order to fit the whole avatar image.
So the tool tip might as well take up the whole screen of your monitor.
Not only that, but a large image takes up some considerable amount of time
to be drawn on the screen so this effectively blocks the whole EDT.

I would love to fix this myself but as far as I remember there were some
policy changes regarding who has rights to commit and I think I no longer
have write access to the Jitsi repo.

The relevant code is in:
net.java.sip.communicator.impl.gui.main.contactlist.contactsource.MetaUIContact#getToolTip()

Fix:
@Override
    public ExtendedTooltip getToolTip()
    {
        ExtendedTooltip tip = new ExtendedTooltip(true);

        tip.setImage(getScaledAvatar(true, 30, 30));

        tip.setTitle(metaContact.getDisplayName());

        loadTooltip(tip);

        return tip;
    }

I would appreciate it if someone can commit this :slight_smile:
Thank you!

Best regards,
Marin

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev