[jitsi-dev] [jitsi] Call button Dissappears if logged in trough Bitlbee (#111)


#1

If an xmpp account is logged in trough Bitlbee and Jitsi at the same time, friends are not able to perform a call as the call button is greyed out. Both local and friend client are running version 2.8 on GNU/Linux.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111


#2

I suspect that this may be have been caused by https://github.com/jitsi/jitsi/commit/478a8ec46cc6c3ccebaadf965f9baa14e5975d1d or https://github.com/jitsi/jitsi/commit/4e5c881b236ec4be89199c06674b0dfa186d0513

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#issuecomment-96387170


#3

If someone could confirm that reverting one (or both) of these fixes the problem, I'd push a revert to master (and figure out how to fix it later).

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#issuecomment-96389291


#4

I just tried all combinations. Both commits separately and together. But reverting those changes did not seem to fix the issue. On two separate contacts running jitsi-android and chatsecure it didn't show the buttons reliably. Though it seems to help, if jitsi is using a higher priority, since that contact does at least initially show the buttons.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#issuecomment-143948084


#5

I've just tested jitsi-2.1.4590.10823 from back in 2013-04-30 and it behaves exactly the same. Meaning only the capabilities of the last signed in client on the side of the contact are being considered. Right now I'm currently looking into [OperationSetContactCapabilitiesJabberImpl](https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetContactCapabilitiesJabberImpl.java#L229). If I understand correctly, there should be code checking every single resource that contact has registered and use the capabilities of the resource supporting the most capabilities. However I did not find code similar to the one in [MetaUIContact](https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/impl/gui/main/contactlist/contactsource/MetaUIContact.java#L582) yet. Unfortunately contact.getResources() seems to be empty at this point.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#issuecomment-144592989


#6

So I took the list of resources straight from EntityCapsManager, since it seems way more reliable than contact.getResources(). This does actually work out pretty smoothly. I will test this a while and I will reference the commit, after I'm certain that it doesn't brake something.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#issuecomment-144642414


#7

https://github.com/459below/jitsi/commit/9dcb88b2a580243ac0e3b640b3f785ed16a5a705

I've been using this fix for some days. This shows the buttons appropriately and I haven't noticed any regressions. I have noticed a different issue mentioned in the commit message. But this seems to be a different pre-existing issue.

I suppose I should create a proper pull request in order to assess these changes, shouldn't I?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#issuecomment-145918619


#8

Closed #111 via #161.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/111#event-459391522