I tried placing fin.close inside the finally block at first, but since it
wouldn't have been initialized and initializing throws an exception, I
thought that the statement would be better off at the end of the try block.
I will make the change.
I am also of the opinion that this code to read the avatar file should be
moved out into a separate method and called from here.
On Tue, Feb 11, 2014 at 11:48 PM, Paweł Domas <email@example.com>wrote:
Nice catch ! But as we're on fixing it... Can we also move the check for
Avatar operation set to the front before we start any processing ? And
"fin" should be probably closed in finally block(with check for null value
of "fin"). Thanks !
Reply to this email directly or view it on GitHub<https://github.com/jitsi/jitsi-android/pull/5#issuecomment-34846254>
Reply to this email directly or view it on GitHub: