[jitsi-dev] [jitsi-android] Fixes & autostart functionality (#43)


#1

As I probably won't be doing any jitsi-android development anytime soon, I decided to open this pull request to give back some of the improvements I made.
Each commit falls into one of these categories:
1. Fixes (Typo fixes, missing strings, lint warnings...)
2. Size reduction (the apk was pretty big, I tried to cut down the size a bit to make it run better on my phone. I mainly ran optimization tools on the images and converted some gifs to pngs.)
3. Autostart functionality (The commits allow jitsi to be started automatically when the device starts. Main work was done my netmackan, I added the config option for it.)

The commits were tested and do work, a prebuilt apk is currently available at http://thrimbor.github.io/jitsi-builds/jitsi_2014-11-10.apk
I ran this build on my phone for months and still have it installed.

Please feel free to leave out individual commits if you want, I just wanted to offer you these changes because I will be deleting my jitsi-android fork soon (because, as I said, I won't be working on it anytime soon).
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-android/pull/43

-- Commit Summary --

  * String resources: Fix typos
  * Fix typos in string resource names
  * Reduced filesize of the png-images by running them through a compressor
  * Merge branch 'trivialFixes' of https://github.com/sandy-8925/jitsi-android
  * Fixed remaining typos to get the build process working again
  * Added missing string in the event config dialog
  * Added vibration option to notifications for incoming messages
  * fixed typo
  * Fixed a bunch of errors reported by lint:
  * Removed loginbackground.png - we already have background.png
  * Start Jitsi on boot.
  * Merge branch 'autostart-1' of https://github.com/netmackan/jitsi-android into autostart
  * fixed typos
  * added config option for autostart (breaks things at the moment)
  * the start-on-boot-setting is now correctly read on boot

-- File Changes --

    M AndroidManifest.xml (40)
    A lint.xml (7)
    M res/drawable-hdpi/acceptvideocall.png (0)
    M res/drawable-hdpi/callbutton.png (0)
    M res/drawable-hdpi/callhangup.png (0)
    M res/drawable-hdpi/callhold.png (0)
    M res/drawable-hdpi/default_jabber_status.png (0)
    M res/drawable-hdpi/default_sip_status.png (0)
    M res/drawable-hdpi/jabber_logo.png (0)
    M res/drawable-hdpi/jabber_status_away.png (0)
    M res/drawable-hdpi/jabber_status_connecting.png (0)
    M res/drawable-hdpi/jabber_status_dnd.png (0)
    M res/drawable-hdpi/jabber_status_ffc.png (0)
    M res/drawable-hdpi/jabber_status_offline.png (0)
    M res/drawable-hdpi/jabber_status_online.png (0)
    M res/drawable-hdpi/jabber_status_phone.png (0)
    M res/drawable-hdpi/jabber_status_xa.png (0)
    M res/drawable-hdpi/sip_logo.png (0)
    M res/drawable-hdpi/sip_status_away.png (0)
    M res/drawable-hdpi/sip_status_busy.png (0)
    M res/drawable-hdpi/sip_status_connecting.png (0)
    M res/drawable-hdpi/sip_status_offline.png (0)
    M res/drawable-hdpi/sip_status_online.png (0)
    M res/drawable-hdpi/sip_status_phone.png (0)
    M res/drawable-mdpi/acceptvideocall.png (0)
    M res/drawable-mdpi/action_item_selected.9.png (0)
    M res/drawable-mdpi/actionbaricon.png (0)
    M res/drawable-mdpi/addcontact.png (0)
    M res/drawable-mdpi/arrow_down.png (0)
    M res/drawable-mdpi/arrow_up.png (0)
    M res/drawable-mdpi/avatar.png (0)
    M res/drawable-mdpi/background.png (0)
    M res/drawable-mdpi/buttonseparator.png (0)
    M res/drawable-mdpi/call.png (0)
    M res/drawable-mdpi/callbutton.png (0)
    M res/drawable-mdpi/callbuttonfull.png (0)
    M res/drawable-mdpi/callhangup.png (0)
    M res/drawable-mdpi/callhold.png (0)
    M res/drawable-mdpi/callmessage.png (0)
    M res/drawable-mdpi/callmicrophone.png (0)
    M res/drawable-mdpi/callmicrophonemute.png (0)
    M res/drawable-mdpi/callvideo.png (0)
    M res/drawable-mdpi/callvolume.png (0)
    M res/drawable-mdpi/cancel_edit.png (0)
    M res/drawable-mdpi/chatarrow.png (0)
    M res/drawable-mdpi/chatseparator.9.png (0)
    M res/drawable-mdpi/chatvideocall.png (0)
    M res/drawable-mdpi/collapsed.png (0)
    M res/drawable-mdpi/contact_away.png (0)
    M res/drawable-mdpi/contact_call.png (0)
    M res/drawable-mdpi/contact_call_selected.png (0)
    M res/drawable-mdpi/contact_dnd.png (0)
    M res/drawable-mdpi/contact_ffc.png (0)
    M res/drawable-mdpi/contact_list_h_separator.png (0)
    M res/drawable-mdpi/contact_list_v_separator.png (0)
    M res/drawable-mdpi/contact_offline.png (0)
    M res/drawable-mdpi/contact_online.png (0)
    M res/drawable-mdpi/contact_otp.png (0)
    M res/drawable-mdpi/corner.png (0)
    M res/drawable-mdpi/default_jabber_status.png (0)
    M res/drawable-mdpi/default_sip_status.png (0)
    M res/drawable-mdpi/drag.png (0)
    M res/drawable-mdpi/editing.png (0)
    M res/drawable-mdpi/encrypted_finished.png (0)
    M res/drawable-mdpi/encrypted_unsecure.png (0)
    M res/drawable-mdpi/encrypted_unverified.png (0)
    M res/drawable-mdpi/encrypted_verified.png (0)
    M res/drawable-mdpi/expanded.png (0)
    M res/drawable-mdpi/fade.png (0)
    M res/drawable-mdpi/global_away.png (0)
    M res/drawable-mdpi/global_dnd.png (0)
    M res/drawable-mdpi/global_ffc.png (0)
    M res/drawable-mdpi/global_offline.png (0)
    M res/drawable-mdpi/global_online.png (0)
    M res/drawable-mdpi/global_otp.png (0)
    M res/drawable-mdpi/hangup.png (0)
    M res/drawable-mdpi/incoming_call.png (0)
    M res/drawable-mdpi/incoming_message.png (0)
    M res/drawable-mdpi/jabber_logo.png (0)
    M res/drawable-mdpi/jabber_status_away.png (0)
    M res/drawable-mdpi/jabber_status_connecting.png (0)
    M res/drawable-mdpi/jabber_status_dnd.png (0)
    M res/drawable-mdpi/jabber_status_ffc.png (0)
    M res/drawable-mdpi/jabber_status_offline.png (0)
    M res/drawable-mdpi/jabber_status_online.png (0)
    M res/drawable-mdpi/jabber_status_phone.png (0)
    M res/drawable-mdpi/jabber_status_xa.png (0)
    M res/drawable-mdpi/loadinglogo.png (0)
    D res/drawable-mdpi/loginbackground.png (0)
    M res/drawable-mdpi/loginbutton.png (0)
    M res/drawable-mdpi/loginbuttonpressed.png (0)
    M res/drawable-mdpi/logoblue.png (0)
    M res/drawable-mdpi/menu.png (0)
    M res/drawable-mdpi/messagearrowin.png (0)
    M res/drawable-mdpi/messagearrowout.png (0)
    M res/drawable-mdpi/messagearrowout_correction.png (0)
    M res/drawable-mdpi/messageholder.9.png (0)
    M res/drawable-mdpi/messageholder_correction.9.png (0)
    M res/drawable-mdpi/missed_call.png (0)
    M res/drawable-mdpi/notificationicon.png (0)
    M res/drawable-mdpi/personphoto.png (0)
    M res/drawable-mdpi/popup.9.png (0)
    M res/drawable-mdpi/reset_editing.png (0)
    M res/drawable-mdpi/search.png (0)
    M res/drawable-mdpi/secure_audio_off.png (0)
    M res/drawable-mdpi/secure_audio_on.png (0)
    M res/drawable-mdpi/secure_off.png (0)
    M res/drawable-mdpi/secure_on.png (0)
    M res/drawable-mdpi/secure_video_off.png (0)
    M res/drawable-mdpi/secure_video_on.png (0)
    M res/drawable-mdpi/selectcallbuttonbackground.png (0)
    M res/drawable-mdpi/send_message.png (0)
    M res/drawable-mdpi/sip_logo.png (0)
    M res/drawable-mdpi/sip_status_away.png (0)
    M res/drawable-mdpi/sip_status_busy.png (0)
    M res/drawable-mdpi/sip_status_connecting.png (0)
    M res/drawable-mdpi/sip_status_offline.png (0)
    M res/drawable-mdpi/sip_status_online.png (0)
    M res/drawable-mdpi/sip_status_phone.png (0)
    D res/drawable-mdpi/smiley1.gif (0)
    A res/drawable-mdpi/smiley1.png (0)
    D res/drawable-mdpi/smiley10.gif (0)
    A res/drawable-mdpi/smiley10.png (0)
    D res/drawable-mdpi/smiley11.gif (0)
    A res/drawable-mdpi/smiley11.png (0)
    D res/drawable-mdpi/smiley12.gif (0)
    A res/drawable-mdpi/smiley12.png (0)
    D res/drawable-mdpi/smiley13.gif (0)
    A res/drawable-mdpi/smiley13.png (0)
    D res/drawable-mdpi/smiley14.gif (0)
    A res/drawable-mdpi/smiley14.png (0)
    D res/drawable-mdpi/smiley15.gif (0)
    A res/drawable-mdpi/smiley15.png (0)
    D res/drawable-mdpi/smiley16.gif (0)
    A res/drawable-mdpi/smiley16.png (0)
    D res/drawable-mdpi/smiley17.gif (0)
    A res/drawable-mdpi/smiley17.png (0)
    D res/drawable-mdpi/smiley18.gif (0)
    A res/drawable-mdpi/smiley18.png (0)
    D res/drawable-mdpi/smiley19.gif (0)
    A res/drawable-mdpi/smiley19.png (0)
    D res/drawable-mdpi/smiley2.gif (0)
    A res/drawable-mdpi/smiley2.png (0)
    D res/drawable-mdpi/smiley20.gif (0)
    A res/drawable-mdpi/smiley20.png (0)
    D res/drawable-mdpi/smiley3.gif (0)
    A res/drawable-mdpi/smiley3.png (0)
    D res/drawable-mdpi/smiley4.gif (0)
    A res/drawable-mdpi/smiley4.png (0)
    D res/drawable-mdpi/smiley5.gif (0)
    A res/drawable-mdpi/smiley5.png (0)
    D res/drawable-mdpi/smiley6.gif (0)
    A res/drawable-mdpi/smiley6.png (0)
    D res/drawable-mdpi/smiley7.gif (0)
    A res/drawable-mdpi/smiley7.png (0)
    D res/drawable-mdpi/smiley8.gif (0)
    A res/drawable-mdpi/smiley8.png (0)
    D res/drawable-mdpi/smiley9.gif (0)
    A res/drawable-mdpi/smiley9.png (0)
    M res/drawable-mdpi/status_bar_hangup.png (0)
    M res/drawable-mdpi/status_bar_mute.png (0)
    M res/drawable-mdpi/status_bar_show_call.png (0)
    M res/drawable-mdpi/status_bar_speaker.png (0)
    M res/drawable-mdpi/status_btn_off.png (0)
    M res/drawable-mdpi/status_btn_on.png (0)
    M res/drawable-mdpi/typing1.png (0)
    M res/drawable-mdpi/typing2.png (0)
    M res/drawable-mdpi/typing3.png (0)
    M res/drawable-mdpi/typing4.png (0)
    M res/drawable-mdpi/video_call.png (0)
    M res/drawable-mdpi/video_call_selected.png (0)
    M res/drawable-mdpi/whitefield.png (0)
    M res/drawable-mdpi/whitespinner.png (0)
    M res/layout-land/account_list_row.xml (1)
    M res/layout/add_contact.xml (2)
    M res/layout/audio_video_info.xml (4)
    M res/layout/authorization_requested.xml (9)
    M res/layout/chat_typing_area.xml (1)
    M res/layout/contact_list_row.xml (2)
    M res/layout/new_account.xml (2)
    M res/layout/presence_status.xml (2)
    M res/values/strings.xml (12)
    M res/xml-v16/preferences.xml (4)
    M res/xml/acc_jabber_preferences.xml (2)
    M res/xml/preferences.xml (4)
    M src/jitsi-defaults.properties (1)
    A src/org/jitsi/android/BootReceiver.java (97)
    M src/org/jitsi/android/gui/AndroidGUIActivator.java (6)
    M src/org/jitsi/android/gui/account/settings/JabberPreferenceFragment.java (10)
    M src/org/jitsi/android/gui/account/settings/JingleNodeDialogFragment.java (2)
    M src/org/jitsi/android/gui/account/settings/SecProtocolsDialogFragment.java (2)
    M src/org/jitsi/android/gui/account/settings/StunTurnDialogFragment.java (2)
    M src/org/jitsi/android/gui/settings/widget/ConfigEditText.java (2)
    M src/org/jitsi/android/gui/settings/widget/ConfigListPreference.java (1)
    M src/org/jitsi/android/gui/settings/widget/ConfigWidgetUtil.java (2)
    M src/org/jitsi/android/plugin/notificationwiring/AndroidNotifications.java (5)
    M src/org/jitsi/impl/androidcertdialog/CertInfoDialog.java (2)

-- Patch Links --

https://github.com/jitsi/jitsi-android/pull/43.patch
https://github.com/jitsi/jitsi-android/pull/43.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-android/pull/43


#2

It is not really my place to say this. I am **not** a maintainer of any kind and I have **no affiliation** (excluding the CLA) whatsoever to the Jitsi Organization. Since that is so, I can be wrong on some or all of the points I'm raising. That being said:

I think there are several problems with this pull request.
* CLA: They cannot accept your contributions, before every contributor in this pull request has signed the [Contributor License Agreement](https://jitsi.org/icla). So @thrimbor, @sandy-8925, @netmackan all would need to sign this.
* Diverged: Your fork seems to be 4 commits behind the upstream repository. You would need to rebase it onto the current master branch of the jitsi repository.
* At least one of the commits is huge. Mixing several separate logical changes together. Since it's not atomic, it would be impossible to revert one logical change inside this commit.
* Some of the code doesn't seem to adhere to the [Jitsi Code Convetion](https://jitsi.org/Documentation/CodeConvention)

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-android/pull/43#issuecomment-156783388


#3

I (netmackan) have signed the CLA long time ago when contributing some stuff to Jitsi.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-android/pull/43#issuecomment-227006975