[jitsi-dev] [jicofo] Prevent granting ownership to the participants


#1

We use jitsi meet for a permanent room with our list of moderators. It
works pretty well, except for the fact that jicofo makes an infinite
list of owners in this case (the room is not destroyed). The other
thing is that not always it is reasonable to grant moderator rights to
any user.

It will be good to make this option customisable, just adding it in
config (for example variable 'not_grant_ownership'), and in
/src/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java instead of if
(owner == null) / if (owner == sourceMember) to use if (owner == null
&& not_grant_ownership) / if (owner == sourceMember &&
not_grant_ownership).

I think it can be useful also for other cases to prevent any conflicts.
Can it be implemented in jicofo or it is unuseful and I should use my
own fork? Is it used only for moderation or it is also needed for
jistsi videobridge?

Regards,
Zalmoxisus


#2

Just tested with temporary rooms (jitsi-meet creates "instant rooms"),
and it's the same problem here. When an owner leaves the conference,
jicofo makes the second user as owner, but the left user also remains
as the room owner. Then when the new owner leaves, the other one will
become owner, and so on. So, in the end all users will be the room
owners, if the room will not become empty and be destroyed.

···

On Sun, Dec 28, 2014 at 11:54 PM, Michael Diordiev <zalmoxisus@gmail.com> wrote:

We use jitsi meet for a permanent room with our list of moderators. It
works pretty well, except for the fact that jicofo makes an infinite
list of owners in this case (the room is not destroyed). The other
thing is that not always it is reasonable to grant moderator rights to
any user.

It will be good to make this option customisable, just adding it in
config (for example variable 'not_grant_ownership'), and in
/src/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java instead of if
(owner == null) / if (owner == sourceMember) to use if (owner == null
&& not_grant_ownership) / if (owner == sourceMember &&
not_grant_ownership).

I think it can be useful also for other cases to prevent any conflicts.
Can it be implemented in jicofo or it is unuseful and I should use my
own fork? Is it used only for moderation or it is also needed for
jistsi videobridge?

Regards,
Zalmoxisus


#3

Hi,

···

On Sun, Dec 28, 2014 at 10:54 PM, Michael Diordiev <zalmoxisus@gmail.com> wrote:

We use jitsi meet for a permanent room with our list of moderators. It
works pretty well, except for the fact that jicofo makes an infinite
list of owners in this case (the room is not destroyed). The other
thing is that not always it is reasonable to grant moderator rights to
any user.

It will be good to make this option customisable, just adding it in
config (for example variable 'not_grant_ownership'), and in
/src/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java instead of if
(owner == null) / if (owner == sourceMember) to use if (owner == null
&& not_grant_ownership) / if (owner == sourceMember &&
not_grant_ownership).

I think it can be useful also for other cases to prevent any conflicts.
Can it be implemented in jicofo or it is unuseful and I should use my
own fork? Is it used only for moderation or it is also needed for
jistsi videobridge?

We need this for room locking functionality as well as few other
features, but yes it can be made configurable. It is not required by
jitsi videobridge.

Regards,
Pawel


#4

Paweł, thanks for the response!

It will be nice to have this configurable (in jistsi meet or in jicofo
config). It is be a big security issue, as we grant owner affiliation
to every user. For example, someone getting the owner rights, may
abuse it by sending manually item affiliation='outcast' for every jid
in the room, and ban all the users.

Having this opportunity, I want to thank all the jitsi team for the
great work you've done this year, and wish you a prosperous New Year!

Regards,
Zalmxisus

···

On Mon, Dec 29, 2014 at 8:31 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi,

On Sun, Dec 28, 2014 at 10:54 PM, Michael Diordiev <zalmoxisus@gmail.com> wrote:

We use jitsi meet for a permanent room with our list of moderators. It
works pretty well, except for the fact that jicofo makes an infinite
list of owners in this case (the room is not destroyed). The other
thing is that not always it is reasonable to grant moderator rights to
any user.

It will be good to make this option customisable, just adding it in
config (for example variable 'not_grant_ownership'), and in
/src/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java instead of if
(owner == null) / if (owner == sourceMember) to use if (owner == null
&& not_grant_ownership) / if (owner == sourceMember &&
not_grant_ownership).

I think it can be useful also for other cases to prevent any conflicts.
Can it be implemented in jicofo or it is unuseful and I should use my
own fork? Is it used only for moderation or it is also needed for
jistsi videobridge?

We need this for room locking functionality as well as few other
features, but yes it can be made configurable. It is not required by
jitsi videobridge.

Regards,
Pawel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev