[jitsi-dev] Issue con styles (I think)


#1

Hi, Jitsi team!

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

Thanks in advance.

Kind regards,
Daniel


#2

I see you modified interface_config.js to put basically everything in the top toolbar. Does this problem happen if you leave the default buttons only there? If so, can you try to find the culprit button (my money is on the profile button) ?

Cheers,

···

On Aug 23, 2017, at 21:36, Daniel Bareiro <daniel-listas@gmx.net> wrote:

Hi, Jitsi team!

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

--
Saúl


#3

Hi, Saúl.

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

I see you modified interface_config.js to put basically everything in the top
toolbar. Does this problem happen if you leave the default buttons only there?

Good question! In the installation I have done using the 'testing'
repositories I am using the default button layout with both toolbars and
there I did not find this issue.

If so, can you try to find the culprit button (my money is on the profile
button) ?

It looks like your money is safe :slight_smile: By moving the profile button to the
vertical toolbar, this issue does not occur and when returning it to the
main toolbar the issue reappears. Should I open a issue for this in Github?

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

Thanks for your reply.

Kind regards,
Daniel

···

On 25/08/17 05:42, Saúl Ibarra Corretgé wrote:


#4

Hi again, Saúl.

···

On 25/08/17 09:35, Daniel Bareiro wrote:

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

Testing against meet.jit.If I am able to reproduce this behavior as well.

Kind regards,
Daniel


#5

Hi, Saúl.

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

I see you modified interface_config.js to put basically everything in the top
toolbar. Does this problem happen if you leave the default buttons only there?

Good question! In the installation I have done using the 'testing'
repositories I am using the default button layout with both toolbars and
there I did not find this issue.

If so, can you try to find the culprit button (my money is on the profile
button) ?

It looks like your money is safe :slight_smile: By moving the profile button to the
vertical toolbar, this issue does not occur and when returning it to the
main toolbar the issue reappears. Should I open a issue for this in Github?

Please do!

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

The quality slider is implemented by dropping simulcast layers, which won’t work on Firefox because we currently don’t support simulcast there.

Cheers,

···

On Aug 25, 2017, at 14:35, Daniel Bareiro <daniel-listas@gmx.net> wrote:
On 25/08/17 05:42, Saúl Ibarra Corretgé wrote:

Thanks for your reply.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Saúl


#6

Hi, Saúl.

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

I see you modified interface_config.js to put basically everything in the top
toolbar. Does this problem happen if you leave the default buttons only there?

Good question! In the installation I have done using the 'testing'
repositories I am using the default button layout with both toolbars and
there I did not find this issue.

If so, can you try to find the culprit button (my money is on the profile
button) ?

It looks like your money is safe :slight_smile: By moving the profile button to the
vertical toolbar, this issue does not occur and when returning it to the
main toolbar the issue reappears. Should I open a issue for this in Github?

Please do!

Done!

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

The quality slider is implemented by dropping simulcast layers, which
won’t work on Firefox because we currently don’t support simulcast there.

Ah, good. Thanks for the observation. Anyway, although the buttons on
the slider might have no effect, my intention was to mention that the
slider was not shown in Firefox when positioning the mouse over HD. But
recently I did a "pull" and it seems that is already solved.

Thanks for your reply.

Kind regards,
Daniel

···

On 25/08/17 12:41, Saúl Ibarra Corretgé wrote:


#7

Hi, Saúl.

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

I see you modified interface_config.js to put basically everything in the top
toolbar. Does this problem happen if you leave the default buttons only there?

Good question! In the installation I have done using the 'testing'
repositories I am using the default button layout with both toolbars and
there I did not find this issue.

If so, can you try to find the culprit button (my money is on the profile
button) ?

It looks like your money is safe :slight_smile: By moving the profile button to the
vertical toolbar, this issue does not occur and when returning it to the
main toolbar the issue reappears. Should I open a issue for this in Github?

Please do!

Done!

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

The quality slider is implemented by dropping simulcast layers, which
won’t work on Firefox because we currently don’t support simulcast there.

Ah, good. Thanks for the observation. Anyway, although the buttons on
the slider might have no effect, my intention was to mention that the
slider was not shown in Firefox when positioning the mouse over HD. But
recently I did a "pull" and it seems that is already solved.

Good to hear! Come to think of it, what I said earlier is incorrect. While Firefox does not support *sending* simulcast streams, it will receive them just fine, so the slider should work there too.

Cheers,

···

On Aug 26, 2017, at 00:01, Daniel Bareiro <daniel-listas@gmx.net> wrote:
On 25/08/17 12:41, Saúl Ibarra Corretgé wrote:

Thanks for your reply.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Saúl


#8

Hi, Saúl.

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

I see you modified interface_config.js to put basically everything in the top
toolbar. Does this problem happen if you leave the default buttons only there?

Good question! In the installation I have done using the 'testing'
repositories I am using the default button layout with both toolbars and
there I did not find this issue.

If so, can you try to find the culprit button (my money is on the profile
button) ?

It looks like your money is safe :slight_smile: By moving the profile button to the
vertical toolbar, this issue does not occur and when returning it to the
main toolbar the issue reappears. Should I open a issue for this in Github?

Please do!

Done!

When there is an update about this, please let me know in the Github issue.

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

The quality slider is implemented by dropping simulcast layers, which
won’t work on Firefox because we currently don’t support simulcast there.

Ah, good. Thanks for the observation. Anyway, although the buttons on
the slider might have no effect, my intention was to mention that the
slider was not shown in Firefox when positioning the mouse over HD. But
recently I did a "pull" and it seems that is already solved.

Good to hear! Come to think of it, what I said earlier is incorrect.
While Firefox does not support *sending* simulcast streams, it will receive
them just fine, so the slider should work there too.

Thank you very much for clarifying this.

So, leaving aside for a moment that particular case, this manual
parameterization would apply to both the video quality sent and received
starting from a default value set in 'resolution' of config.js?

And the manual parameterization for video quality would be overridden by
bridge adaptivity?

Kind regards,
Daniel

···

On 28/08/17 04:59, Saúl Ibarra Corretgé wrote:


#9

Hi, Saúl.

I just compiled Jitsi Meet in a testing environment and there seems to
be a problem with the top toolbar styles. I'm finding this in both
Chromium and Firefox. The active button has a box that escapes the width
of the button bar. Can you reproduce it? In the version installed from
the repositories I am not seeing this behavior. I think this happens
because the elements of the toolbar are not vertically centered.

Here a screenshot so that you can see it better:

https://ibin.co/3Xu0UlvXRTBC.jpg

Also, for some reason, the thumbnail looks like it's off screen. This
only happens in Chrome and not in Firefox.

If I can provide more information, please let me know.

I see you modified interface_config.js to put basically everything in the top
toolbar. Does this problem happen if you leave the default buttons only there?

Good question! In the installation I have done using the 'testing'
repositories I am using the default button layout with both toolbars and
there I did not find this issue.

If so, can you try to find the culprit button (my money is on the profile
button) ?

It looks like your money is safe :slight_smile: By moving the profile button to the
vertical toolbar, this issue does not occur and when returning it to the
main toolbar the issue reappears. Should I open a issue for this in Github?

Please do!

Done!

When there is an update about this, please let me know in the Github issue.

By the way, I'm also seeing that only the video quality dropdown is
working only in Chromium and not in Firefox (testing from a version
compiled with Jitsi Meet). Can you reproduce this?

The quality slider is implemented by dropping simulcast layers, which
won’t work on Firefox because we currently don’t support simulcast there.

Ah, good. Thanks for the observation. Anyway, although the buttons on
the slider might have no effect, my intention was to mention that the
slider was not shown in Firefox when positioning the mouse over HD. But
recently I did a "pull" and it seems that is already solved.

Good to hear! Come to think of it, what I said earlier is incorrect.
While Firefox does not support *sending* simulcast streams, it will receive
them just fine, so the slider should work there too.

Thank you very much for clarifying this.

So, leaving aside for a moment that particular case, this manual
parameterization would apply to both the video quality sent and received
starting from a default value set in 'resolution' of config.js?

Right now it’s only the reception. The implementation uses the resolution (currently) but this is an implementation detail, we may just switch to raw bitrate based calculations. The “resolution” config variable is not used for any of this.

And the manual parameterization for video quality would be overridden by
bridge adaptivity?

No, it cannot.

···

On Aug 28, 2017, at 16:12, Daniel Bareiro <daniel-listas@gmx.net> wrote:
On 28/08/17 04:59, Saúl Ibarra Corretgé wrote:

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Saúl