[jitsi-dev] Issue #315 rtcpMuxPolicy


#1

I tried searching for the fix to the issue https://github.com/
jitsi/jitsi-meet/issues/315, related to enabling rtcpMuxPolicy to
'require'. Although I am not theoretically aware about gathering ICE
candidates and Mux policies, I did read about it and understand that while
creating a new RTCPeerConnection, I have to add the configuration option
rtcpMuxPolicy:"require" (is it the default ?)

I am uncertain about its implementation in the code, is it for the mobile
app (react-native-webrtc?)


features/base/lib-jitsi-meet/native/RTCPeerConnection.js

This is a demo code from react-native-webrtc git repo where configuration
is added https://github.com/oney/RCTWebRTCDemo/blob/master/main.js
I wasn't too sure about commenting on github due to the confusion about
implementation.

Thanks for the help,
Saumeya


#2

Hi Saumeya,

Thanks for your interest.

I tried searching for the fix to the issue https://github.com/jitsi/jitsi-meet/issues/315, related to enabling rtcpMuxPolicy to 'require'. Although I am not theoretically aware about gathering ICE candidates and Mux policies, I did read about it and understand that while creating a new RTCPeerConnection, I have to add the configuration option rtcpMuxPolicy:"require" (is it the default ?)

I don't know what the default is. If the default is now "require", then we can just close the issue.

I am uncertain about its implementation in the code, is it for the mobile app (react-native-webrtc?)
https://github.com/jitsi/jitsi-meet/blob/master/react/features/base/lib-jitsi-meet/native/RTCPeerConnection.js

No, it's not for the mobile app. It will probably be in lib-jitsi-meet (see TraceablePeerConnection.js)

This is a demo code from react-native-webrtc git repo where configuration is added https://github.com/oney/RCTWebRTCDemo/blob/master/main.js
I wasn't too sure about commenting on github due to the confusion about implementation.

Feel free to also comment on github.

Regards,
Boris

···

On 30/03/2018 13:53, Saumeya Katyal wrote:


#3

Thanks, will check again.

Saumeya

···

On Sat, Mar 31, 2018 at 12:31 AM, Boris Grozev <boris@jitsi.org> wrote:

Hi Saumeya,

Thanks for your interest.

On 30/03/2018 13:53, Saumeya Katyal wrote:

I tried searching for the fix to the issue https://github.com/jitsi/jitsi
-meet/issues/315 <https://github.com/jitsi/jitsi-meet/issues/315>,
related to enabling rtcpMuxPolicy to 'require'. Although I am not
theoretically aware about gathering ICE candidates and Mux policies, I did
read about it and understand that while creating a new RTCPeerConnection, I
have to add the configuration option rtcpMuxPolicy:"require" (is it the
default ?)

I don't know what the default is. If the default is now "require", then we
can just close the issue.

I am uncertain about its implementation in the code, is it for the mobile
app (react-native-webrtc?)
https://github.com/jitsi/jitsi-meet/blob/master/react/featur
es/base/lib-jitsi-meet/native/RTCPeerConnection.js <
https://github.com/jitsi/jitsi-meet/blob/master/react/featu
res/base/lib-jitsi-meet/native/RTCPeerConnection.js>

No, it's not for the mobile app. It will probably be in lib-jitsi-meet
(see TraceablePeerConnection.js)

This is a demo code from react-native-webrtc git repo where configuration
is added https://github.com/oney/RCTWebRTCDemo/blob/master/main.js <
https://github.com/oney/RCTWebRTCDemo/blob/master/main.js>
I wasn't too sure about commenting on github due to the confusion about
implementation.

Feel free to also comment on github.

Regards,
Boris


#4

Hi,

Yes the default is "require" , also according to this :
https://www.w3.org/TR/webrtc/#rtcrtcpmuxpolicy-enum this specification is
at risk due to lack of implementers' interest.

Saumeya

<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

···

On Sat, Mar 31, 2018 at 12:34 AM, Saumeya Katyal < saumeya.katyal@cumminscollege.in> wrote:

Thanks, will check again.

Saumeya

On Sat, Mar 31, 2018 at 12:31 AM, Boris Grozev <boris@jitsi.org> wrote:

Hi Saumeya,

Thanks for your interest.

On 30/03/2018 13:53, Saumeya Katyal wrote:

I tried searching for the fix to the issue
https://github.com/jitsi/jitsi-meet/issues/315 <
https://github.com/jitsi/jitsi-meet/issues/315>, related to enabling
rtcpMuxPolicy to 'require'. Although I am not theoretically aware about
gathering ICE candidates and Mux policies, I did read about it and
understand that while creating a new RTCPeerConnection, I have to add the
configuration option rtcpMuxPolicy:"require" (is it the default ?)

I don't know what the default is. If the default is now "require", then
we can just close the issue.

I am uncertain about its implementation in the code, is it for the
mobile app (react-native-webrtc?)
https://github.com/jitsi/jitsi-meet/blob/master/react/featur
es/base/lib-jitsi-meet/native/RTCPeerConnection.js <
https://github.com/jitsi/jitsi-meet/blob/master/react/featu
res/base/lib-jitsi-meet/native/RTCPeerConnection.js>

No, it's not for the mobile app. It will probably be in lib-jitsi-meet
(see TraceablePeerConnection.js)

This is a demo code from react-native-webrtc git repo where
configuration is added https://github.com/oney/RCTWeb
RTCDemo/blob/master/main.js <https://github.com/oney/RCTWe
bRTCDemo/blob/master/main.js>
I wasn't too sure about commenting on github due to the confusion about
implementation.

Feel free to also comment on github.

Regards,
Boris