[jitsi-dev] IRC implementation ready for a larger audience (?)


#1

Hi Hristo,

Yeah, I figured as much. The changes have become obsolete now that the chat rooms are incorporated in the contact list. I will probaby just rebase interactively and clean up these old changes.

Incidentally, do you know if there is a reason for the current behavior of joining a chatroom, i.e.:

  1. You issue a command to join a chatroom, then 2. a “empty chatroom window” pops up. Then you wait until 3. the actual joining happens on the background and then the window gets filled with data (i.e. messages, users, topic title, etc.) related to the joined chatroom.

Step 2: the empty chatroom window gets openend immediately, becomes a problem when the chatroom that you clicked is not going to be the chatroom that you join. In IRC it is possible to get redirected (forwarded) to a different chatroom.

For this reason (i.e. my use case), it would be more useful to only show the chatroom window after the local user’s presence in the chatroom has been announced.

Danny

···

----- Original Message -----

From: Hristo Terezov [mailto:hristoterezov@gmail.com]

To: dev@jitsi.org

Sent: Mon, 20 Jan 2014 11:42:36 +0200

Subject: Re: [jitsi-dev] IRC implementation ready for a larger audience (?)

Hello Danny,

The current version of ChatRoomTableDialog is the “Add chat room” dialog which is displayed from File -> Add chat room. Before the implementation of the chat room contacts in the contact list the ChatRoomTableDialog was the only place where you can manage your chat rooms. Since we add the most of functionality implemented in the ChatRoomTableDialog in the contact list we removed the list of chatrooms and the add / remove buttons from the dialog. At the moment the ChatRoomTableDialog is used only for adding new chat rooms to the contact list.

Maybe we should rename the class.

Regards,
Hristo.

On Jan 18, 2014, at 12:46 AM, Danny van Heumen danny@dannyvanheumen.nl wrote:

About the ChatRoomTableDialog …
It is a separate chat room management window where you can see the chat
rooms, which ones are joined and others. You can add, join, leave,
remove chat rooms. This has now all been incorporated in the contact
list though, so not immediately relevant. The only exception I can think
of, is when some menu item still shows this window for some reason.

On 01/17/2014 10:42 PM, Ingo Bauersachs wrote:

[…]

The changes in
ChatRoomTableDialog.java look weird. Are you sure the commented code
there is not necessary? If so, completely remove it (the reformats seem
unnecessary too).
The unnecessary formatting was by mistake I think. The reason for
changing the behavior was that the behavior deviated between
double-clicking a chatroom to join it, and selecting the chatroom then
joining by clicking the ‘join’ button. With the change it adopts the
behavior of the join-button. (I commented out the
duplicate-but-slightly-off implementation and called the open chat room
implementation of the join button … or the other way around …)
I am not sure whether or not this Dialog is even still used. With the
recent Chat UI changes, the ChatRoomTableDialog does not show anymore.
Or at least I have not found it yet.
Instead (I think) it has now been replaced by a more slimmed down ‘Add
Chat Room’ dialog. Did Hristo do the recent chat dialog changes? Maybe
he knows more about this.
I have absolutely no idea what that code actually does/did. Someone else who
knows more would have to answer this.

I could remove this code if that is preferred. If so, does anyone know
what the easiest way is to edit out git history?
git rebase master --interactive

[…]
Danny
Ingo


dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


Danny


dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#2

Hi Hristo,

Yeah, I figured as much. The changes have become obsolete now that the
chat rooms are incorporated in the contact list. I will probaby just
rebase interactively and clean up these old changes.

Incidentally, do you know if there is a reason for the current behavior
of joining a chatroom, i.e.:
1. You issue a command to join a chatroom, then 2. a "empty chatroom
window" pops up.

This way they know something happened in response to their click. That's actually pretty important.

Then you wait until 3. the actual joining happens on
the background and then the window gets filled with data (i.e. messages,
users, topic title, etc.) related to the joined chatroom.

Step 2: the empty chatroom window gets openend immediately, becomes a
problem when the chatroom that you clicked is not going to be the
chatroom that you join. In IRC it is possible to get redirected
(forwarded) to a different chatroom.

For this reason (i.e. my use case), it would be more useful to only show
the chatroom window after the local user's presence in the chatroom has
been announced.

I think it would be better if we just popup a new one and close the one that got opened initially. After all, this isn't the common case and it shouldn't be that much of a problem when it actually happens.

Emil

···

On 20.01.14, 13:03, Danny van Heumen wrote:

Danny

*----- Original Message -----*
*From:* Hristo Terezov [mailto:hristoterezov@gmail.com]
*To:* dev@jitsi.org
*Sent:* Mon, 20 Jan 2014 11:42:36 +0200
*Subject:* Re: [jitsi-dev] IRC implementation ready for a larger
audience (?)

Hello Danny,

The current version of ChatRoomTableDialog is the "Add chat room" dialog
which is displayed from File -> Add chat room. Before the implementation
of the chat room contacts in the contact list the ChatRoomTableDialog
was the only place where you can manage your chat rooms. Since we add
the most of functionality implemented in the ChatRoomTableDialog in the
contact list we removed the list of chatrooms and the add / remove
buttons from the dialog. At the moment the ChatRoomTableDialog is used
only for adding new chat rooms to the contact list.

Maybe we should rename the class.

Regards,
Hristo.

On Jan 18, 2014, at 12:46 AM, Danny van Heumen <danny@dannyvanheumen.nl > <#>> wrote:

> About the ChatRoomTableDialog ...
> It is a separate chat room management window where you can see the chat
> rooms, which ones are joined and others. You can add, join, leave,
> remove chat rooms. This has now all been incorporated in the contact
> list though, so not immediately relevant. The only exception I can think
> of, is when some menu item still shows this window for some reason.
>
> On 01/17/2014 10:42 PM, Ingo Bauersachs wrote:
>>> [...]
>>>> The changes in
>>>> ChatRoomTableDialog.java look weird. Are you sure the commented code
>>>> there is not necessary? If so, completely remove it (the reformats
seem
>>>> unnecessary too).
>>> The unnecessary formatting was by mistake I think. The reason for
>>> changing the behavior was that the behavior deviated between
>>> double-clicking a chatroom to join it, and selecting the chatroom then
>>> joining by clicking the 'join' button. With the change it adopts the
>>> behavior of the join-button. (I commented out the
>>> duplicate-but-slightly-off implementation and called the open chat room
>>> implementation of the join button ... or the other way around ...)
>>> I am not sure whether or not this Dialog is even still used. With the
>>> recent Chat UI changes, the ChatRoomTableDialog does not show anymore.
>>> Or at least I have not found it yet.
>>> Instead (I think) it has now been replaced by a more slimmed down 'Add
>>> Chat Room' dialog. Did Hristo do the recent chat dialog changes? Maybe
>>> he knows more about this.
>> I have absolutely no idea what that code actually does/did. Someone
else who
>> knows more would have to answer this.
>>
>>> I could remove this code if that is preferred. If so, does anyone know
>>> what the easiest way is to edit out git history?
>> git rebase master --interactive
>>
>>> [...]
>>> Danny
>> Ingo
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org <#>
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>
> --
> Danny
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org <#>
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org <#>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org