Reply to both messages inline ...
one more, which I'm not sure was it there before irc when I receive
a new message in a room, and the tab is opened, but is not the
selected one, the tab is selected. Which of course has and a security
problem, you may send a message(or a part of it) to wrong tab, the way
it happened to me.
So, let me see if I inderstand you ... you have, say 3 chatrooms #a, #b,
#c. Room #b is selected but, say, you've minimized the chat window. Then
if you get a message on #a, when you unminimize the room, it still shows
#b? ... somehow I think I'm missing something here ... because if you
see the message in the chat window tab, that is also the tab that is
Do you mean via the notification pop-up, maybe?
first great work! Thanks for the irc provider!
Everything is working fine, I just have some improvements in mind.
First after I created my account, I tried adding a chat room, but
clicking on Join was doing nothing. I had to go to the logs to realize
that I was entering the room without the # sign.
java.lang.IllegalArgumentException: invalid channel prefix: j
Yeah ... very recent change because it came to me that it was more
appropriate to check the name in the ChatRoom implementation. Will fix
that ... obvious mistake.
Maybe we can let this exception go to the UI and show an error text in
"Add chat room" dialog, like "invalid channel prefix: j (maybe missing
#)" or something similar and meaningful for the user.
I'll have to see how a message looks. I can also "assume" the # and add
it if it's missing. Although there are 2 channel symbols: # and & IIRC.
The second isn't often used. So I'm thinking of making # the implicitly
added prefix and & must be typed to be used.
The second one that bothers me is the NickServ in not in contact list.
Didn't we have a special system chat room(chat room without the
members list)? If we have one, the NickServ can be shown in Chat Rooms
Yeah, I do remember seeing stuff about the system room. The problem here
is mainly that NickServ (and ChanServ for that matter) is not the actual
server itself. This is interaction with a "user" which is actually a bot
hosted by the IRC network server.
I need to check if I can get some information beforehand to tell that
these are the bots. ChanServ, for example, sends you some info if you
join particular channels, for example channel rules and if so that a
channel is logged and such.
On 08/14/2014 03:03 PM, Damian Minkov wrote:
On Thu, Aug 14, 2014 at 9:21 AM, Damian Minkov <email@example.com> wrote:
Anyway, thanks and great work! And thanks Ingo for taking care of it
and merging it!
P.S. Can you point me to the sources of the IRC stack, maybe I have
missed that email from the mailinglist Will need to add them to the
debian source package.
dev mailing list
Unsubscribe instructions and other list options: