[jitsi-dev] interface_config.js / toolbar definition


#1

Hi!

I'd like to configure the various buttons that are visible in Jitsi Meet.
As far as I can tell, there appear to be two relevant properties in
interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
arrays, but there's overlap.

Am I right to conclude that *all* buttons are to be defined in
TOOLBAR_BUTTONS? Every button that is *also* defined in
MAIN_TOOLBAR_BUTTONS appears in the toolbar at the top of the screen, while
the others appear on the left-hand side?

Regards,

  Guus


#2

Hi,

So in TOOLBAR_BUTTONS go all toolbar buttons that are enabled, this
includes the vertical one and the horizontal one. While in
MAIN_TOOLBAR_BUTTONS go all the buttons that should be visible in the
horizontal one and are enabled, so if something is present in MAIN_...
and missing in TOOLBAR_BUTTONS it will be just not shown.

Regards
damencho

···

On Tue, Apr 25, 2017 at 1:23 PM, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Hi!

I'd like to configure the various buttons that are visible in Jitsi Meet. As
far as I can tell, there appear to be two relevant properties in
interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
arrays, but there's overlap.

Am I right to conclude that *all* buttons are to be defined in
TOOLBAR_BUTTONS? Every button that is *also* defined in MAIN_TOOLBAR_BUTTONS
appears in the toolbar at the top of the screen, while the others appear on
the left-hand side?

Regards,

  Guus

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi Damian,

What's about the mobile toolbar configuration?

In the mobile app, two buttons Phone (vertical toolbar) and Camera
(horizontal toolbar) have the same function: turn of the camera.

How can I hide vertical button?
Thanks

···

On Wed, Apr 26, 2017 at 1:54 AM, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

So in TOOLBAR_BUTTONS go all toolbar buttons that are enabled, this
includes the vertical one and the horizontal one. While in
MAIN_TOOLBAR_BUTTONS go all the buttons that should be visible in the
horizontal one and are enabled, so if something is present in MAIN_...
and missing in TOOLBAR_BUTTONS it will be just not shown.

Regards
damencho

On Tue, Apr 25, 2017 at 1:23 PM, Guus der Kinderen > <guus.der.kinderen@gmail.com> wrote:
> Hi!
>
> I'd like to configure the various buttons that are visible in Jitsi
Meet. As
> far as I can tell, there appear to be two relevant properties in
> interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
> arrays, but there's overlap.
>
> Am I right to conclude that *all* buttons are to be defined in
> TOOLBAR_BUTTONS? Every button that is *also* defined in
MAIN_TOOLBAR_BUTTONS
> appears in the toolbar at the top of the screen, while the others appear
on
> the left-hand side?
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hi,

Those buttons have different functions. One mutes camera, the other
switches the call in audio only mode, where you stop receiving any video
and stop sending one.
I think those cannot be controlled/hidden currently through an option,
others can correct me if I'm wrong.

Regards
damencho

···

On Apr 26, 2017 2:39 AM, "Nam Vu" <zuzoovn@gmail.com> wrote:

Hi Damian,

What's about the mobile toolbar configuration?

In the mobile app, two buttons Phone (vertical toolbar) and Camera
(horizontal toolbar) have the same function: turn of the camera.

How can I hide vertical button?
Thanks

On Wed, Apr 26, 2017 at 1:54 AM, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

So in TOOLBAR_BUTTONS go all toolbar buttons that are enabled, this
includes the vertical one and the horizontal one. While in
MAIN_TOOLBAR_BUTTONS go all the buttons that should be visible in the
horizontal one and are enabled, so if something is present in MAIN_...
and missing in TOOLBAR_BUTTONS it will be just not shown.

Regards
damencho

On Tue, Apr 25, 2017 at 1:23 PM, Guus der Kinderen >> <guus.der.kinderen@gmail.com> wrote:
> Hi!
>
> I'd like to configure the various buttons that are visible in Jitsi
Meet. As
> far as I can tell, there appear to be two relevant properties in
> interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
> arrays, but there's overlap.
>
> Am I right to conclude that *all* buttons are to be defined in
> TOOLBAR_BUTTONS? Every button that is *also* defined in
MAIN_TOOLBAR_BUTTONS
> appears in the toolbar at the top of the screen, while the others
appear on
> the left-hand side?
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Hi,

One more question on this subject: If I compare the content of the
TOOLBAR_BUTTONS array in /interface_config.js with
/react/features/toolbox/defaultToolbarButtons.js, then i notice
that TOOLBAR_BUTTONS contains a button called "filmstrip" that I do not
find in defaultToolbarButtons.js. Is that an omission, or does it serve a
purpose?

I had hoped that by removing the "filmstrip" button from
the TOOLBAR_BUTTONS array, the filmstrip would disappear - but that's not
the case. Can I remove the filmstrip through configuration?

Regards,

  Guus

···

On 26 April 2017 at 15:34, Damian Minkov <damencho@damencho.com> wrote:

Hi,

Those buttons have different functions. One mutes camera, the other
switches the call in audio only mode, where you stop receiving any video
and stop sending one.
I think those cannot be controlled/hidden currently through an option,
others can correct me if I'm wrong.

Regards
damencho

On Apr 26, 2017 2:39 AM, "Nam Vu" <zuzoovn@gmail.com> wrote:

Hi Damian,

What's about the mobile toolbar configuration?

In the mobile app, two buttons Phone (vertical toolbar) and Camera
(horizontal toolbar) have the same function: turn of the camera.

How can I hide vertical button?
Thanks

On Wed, Apr 26, 2017 at 1:54 AM, Damian Minkov <damencho@jitsi.org> >> wrote:

Hi,

So in TOOLBAR_BUTTONS go all toolbar buttons that are enabled, this
includes the vertical one and the horizontal one. While in
MAIN_TOOLBAR_BUTTONS go all the buttons that should be visible in the
horizontal one and are enabled, so if something is present in MAIN_...
and missing in TOOLBAR_BUTTONS it will be just not shown.

Regards
damencho

On Tue, Apr 25, 2017 at 1:23 PM, Guus der Kinderen >>> <guus.der.kinderen@gmail.com> wrote:
> Hi!
>
> I'd like to configure the various buttons that are visible in Jitsi
Meet. As
> far as I can tell, there appear to be two relevant properties in
> interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
> arrays, but there's overlap.
>
> Am I right to conclude that *all* buttons are to be defined in
> TOOLBAR_BUTTONS? Every button that is *also* defined in
MAIN_TOOLBAR_BUTTONS
> appears in the toolbar at the top of the screen, while the others
appear on
> the left-hand side?
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Hi Gus,

Hi,

One more question on this subject: If I compare the content of the TOOLBAR_BUTTONS array in /interface_config.js with /react/features/toolbox/defaultToolbarButtons.js,
then i notice that TOOLBAR_BUTTONS contains a button called "filmstrip" that I do not find in defaultToolbarButtons.js. Is that an omission, or does it serve a purpose?

Good catch! We recently moved the toolbar to react and this has been forgotten in the interface_config.js. It does not correspond to a button in the toolbar and I’ll submit a patch to remove it.

I had hoped that by removing the "filmstrip" button from the TOOLBAR_BUTTONS array, the filmstrip would disappear - but that's not the case. Can I remove the filmstrip through configuration?

Not with a config parameter, no. You can disable it programatically or by changing the css by setting display:none; to the filmstrip css class.

Cheers,
Yana

···

On 26 Apr 2017, at 9:37 am, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Regards,

  Guus

On 26 April 2017 at 15:34, Damian Minkov <damencho@damencho.com> wrote:
Hi,

Those buttons have different functions. One mutes camera, the other switches the call in audio only mode, where you stop receiving any video and stop sending one.
I think those cannot be controlled/hidden currently through an option, others can correct me if I'm wrong.

Regards
damencho

On Apr 26, 2017 2:39 AM, "Nam Vu" <zuzoovn@gmail.com> wrote:
Hi Damian,

What's about the mobile toolbar configuration?

In the mobile app, two buttons Phone (vertical toolbar) and Camera (horizontal toolbar) have the same function: turn of the camera.

How can I hide vertical button?
Thanks

On Wed, Apr 26, 2017 at 1:54 AM, Damian Minkov <damencho@jitsi.org> wrote:
Hi,

So in TOOLBAR_BUTTONS go all toolbar buttons that are enabled, this
includes the vertical one and the horizontal one. While in
MAIN_TOOLBAR_BUTTONS go all the buttons that should be visible in the
horizontal one and are enabled, so if something is present in MAIN_...
and missing in TOOLBAR_BUTTONS it will be just not shown.

Regards
damencho

On Tue, Apr 25, 2017 at 1:23 PM, Guus der Kinderen > <guus.der.kinderen@gmail.com> wrote:
> Hi!
>
> I'd like to configure the various buttons that are visible in Jitsi Meet. As
> far as I can tell, there appear to be two relevant properties in
> interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
> arrays, but there's overlap.
>
> Am I right to conclude that *all* buttons are to be defined in
> TOOLBAR_BUTTONS? Every button that is *also* defined in MAIN_TOOLBAR_BUTTONS
> appears in the toolbar at the top of the screen, while the others appear on
> the left-hand side?
>
> Regards,
>
> Guus
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Hi Yana,

Forgive my React / Node / Front-end noobieness, but how do I do this best?
I'd love to be able to run with a setup that has next to no modified files,
with the exception of the entry point files like index.html, config.js and
interface_config.js?

I'd like to remain in sync with your upstream development, as deviations
have proven to be quite fatal in the past. Thoughts?

Regards,

  Guus

···

On 26 April 2017 at 17:45, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Gus,

> On 26 Apr 2017, at 9:37 am, Guus der Kinderen < > guus.der.kinderen@gmail.com> wrote:
>
> Hi,
>
> One more question on this subject: If I compare the content of the
TOOLBAR_BUTTONS array in /interface_config.js with /react/features/toolbox/
defaultToolbarButtons.js,
> then i notice that TOOLBAR_BUTTONS contains a button called "filmstrip"
that I do not find in defaultToolbarButtons.js. Is that an omission, or
does it serve a purpose?

Good catch! We recently moved the toolbar to react and this has been
forgotten in the interface_config.js. It does not correspond to a button in
the toolbar and I’ll submit a patch to remove it.

>
> I had hoped that by removing the "filmstrip" button from the
TOOLBAR_BUTTONS array, the filmstrip would disappear - but that's not the
case. Can I remove the filmstrip through configuration?

Not with a config parameter, no. You can disable it programatically or by
changing the css by setting display:none; to the filmstrip css class.

Cheers,
Yana
>
> Regards,
>
> Guus
>
> On 26 April 2017 at 15:34, Damian Minkov <damencho@damencho.com> wrote:
> Hi,
>
> Those buttons have different functions. One mutes camera, the other
switches the call in audio only mode, where you stop receiving any video
and stop sending one.
> I think those cannot be controlled/hidden currently through an option,
others can correct me if I'm wrong.
>
> Regards
> damencho
>
> On Apr 26, 2017 2:39 AM, "Nam Vu" <zuzoovn@gmail.com> wrote:
> Hi Damian,
>
> What's about the mobile toolbar configuration?
>
> In the mobile app, two buttons Phone (vertical toolbar) and Camera
(horizontal toolbar) have the same function: turn of the camera.
>
> How can I hide vertical button?
> Thanks
>
>
> On Wed, Apr 26, 2017 at 1:54 AM, Damian Minkov <damencho@jitsi.org> > wrote:
> Hi,
>
> So in TOOLBAR_BUTTONS go all toolbar buttons that are enabled, this
> includes the vertical one and the horizontal one. While in
> MAIN_TOOLBAR_BUTTONS go all the buttons that should be visible in the
> horizontal one and are enabled, so if something is present in MAIN_...
> and missing in TOOLBAR_BUTTONS it will be just not shown.
>
> Regards
> damencho
>
>
> On Tue, Apr 25, 2017 at 1:23 PM, Guus der Kinderen > > <guus.der.kinderen@gmail.com> wrote:
> > Hi!
> >
> > I'd like to configure the various buttons that are visible in Jitsi
Meet. As
> > far as I can tell, there appear to be two relevant properties in
> > interface_config.js: TOOLBAR_BUTTONS and MAIN_TOOLBAR_BUTTONS. Both are
> > arrays, but there's overlap.
> >
> > Am I right to conclude that *all* buttons are to be defined in
> > TOOLBAR_BUTTONS? Every button that is *also* defined in
MAIN_TOOLBAR_BUTTONS
> > appears in the toolbar at the top of the screen, while the others
appear on
> > the left-hand side?
> >
> > Regards,
> >
> > Guus
> >
> > _______________________________________________
> > dev mailing list
> > dev@jitsi.org
> > Unsubscribe instructions and other list options:
> > http://lists.jitsi.org/mailman/listinfo/dev
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev