Hey Boris,
Thanks for testing.
A few of your remarks make me think that you may be running a (much)
older version of the code. Could you please check what code you are
actually running? I commit my changes to the branch 'master', so that is
most current. I give a few pointers below to check if the situation is
as expected, so that might help.
Further comments below...
I feel that this implementation is far enough along the way (in terms of
features) that we can start testing on a larger scale and create a first
stable and decent implementation.
Danny
PS: I'd like to say it is quite stable already, but since I've only
tested it for myself, you never know for sure, right? 
Hello, Danny
Thanks for all the work -- this is really awesome!
I just added an account (on freenode) and played a bit with it. I'm
running your branch merged with a recent master. Here's what I noticed:
Failures to connect (e.g. when a wrong port number is used in the
account registration) are not indicated in the GUI.
Yes, this is due to Freenode (and others as well) having a number of
hosts that do not support SSL and a bunch that do. As you have probably
noticed, the check for a secure connection is on by default. This does
however limit the number of servers that you can connect to without
having to uncheck Secure Connection. (It does adjust the default port
number accordingly when you uncheck Secure Connection, so that should help.)
Did it pop up a notification message saying "Connection failed for the
following account ..."?
I entered a name in the "Nickname" field during account registration,
and it shows up in the jitsi GUI (when I enter a room, for example).
However other clients show me enter as "boris" (which is my system
username). This might be some misunderstanding due to my ignorance of
IRC, but it's unexpected and seems weird.
The nick name is always the same for all chat rooms of an IRC
connection, i.e. the nick name is determined by the account, not an
individual chat room. I am aware of this, and I suspected it to become
an issue sooner or later. I need to find a way to inform the user that a
custom nick name for this chat room is not available for IRC.
I have already taken a quick look into this. I found an OperationSet for
account details or such, which I believe I can use to "suggest" te
correct nick name. That does not enforce anything, though, so there's
still a weakness there. If you have any suggests on how we can limit
user choice at that point? (Preferrably without having to overthrow the
complete UI ...)
Entering a room and double clicking a name results in:
[java] 12:32:01.971 SEVERE: [20]
util.UtilActivator.uncaughtException().108 An uncaught exception
occurred in thread=Thread[AWT-EventQueue-0,6,main] and message was: null
[java] java.lang.NullPointerException
[java] at
net.java.sip.communicator.impl.contactlist.MetaContactGroupImpl.findMetaContactByContact(MetaContactGroupImpl.java:569)
[java] at
net.java.sip.communicator.impl.contactlist.MetaContactListServiceImpl.findMetaContactByContact(MetaContactListServiceImpl.java:1646)
[java] at
net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.openPrivateChatForChatRoomMember(ChatWindowManager.java:138)
[java] at
net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.openPrivateChatForChatRoomMember(ChatWindowManager.java:114)
[java] at
net.java.sip.communicator.impl.gui.main.chat.conference.ChatRoomMemberListPanel$1.mouseClicked(ChatRoomMemberListPanel.java:117)
[java] at
java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:253)
[java] at
java.awt.Component.processMouseEvent(Component.java:6417)
[java] at
javax.swing.JComponent.processMouseEvent(JComponent.java:3275)
[java] at
net.java.sip.communicator.impl.gui.main.contactlist.DefaultContactList.processMouseEvent(DefaultContactList.java:360)
[java] at java.awt.Component.processEvent(Component.java:6179)
[java] at java.awt.Container.processEvent(Container.java:2084)
[java] at
java.awt.Component.dispatchEventImpl(Component.java:4776)
[java] at
java.awt.Container.dispatchEventImpl(Container.java:2142)
[java] at java.awt.Component.dispatchEvent(Component.java:4604)
[java] at
java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4618)
[java] at
java.awt.LightweightDispatcher.processMouseEvent(Container.java:4288)
[java] at
java.awt.LightweightDispatcher.dispatchEvent(Container.java:4209)
[java] at
java.awt.Container.dispatchEventImpl(Container.java:2128)
[java] at java.awt.Window.dispatchEventImpl(Window.java:2492)
[java] at java.awt.Component.dispatchEvent(Component.java:4604)
[java] at
java.awt.EventQueue.dispatchEventImpl(EventQueue.java:717)
[java] at java.awt.EventQueue.access$400(EventQueue.java:82)
[java] at java.awt.EventQueue$2.run(EventQueue.java:676)
[java] at java.awt.EventQueue$2.run(EventQueue.java:674)
[java] at java.security.AccessController.doPrivileged(Native
Method)
[java] at
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:86)
[java] at
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:97)
[java] at java.awt.EventQueue$3.run(EventQueue.java:690)
[java] at java.awt.EventQueue$3.run(EventQueue.java:688)
[java] at java.security.AccessController.doPrivileged(Native
Method)
[java] at
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:86)
[java] at java.awt.EventQueue.dispatchEvent(EventQueue.java:687)
[java] at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
[java] at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
[java] at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
[java] at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
[java] at
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
[java] at
java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Hmm... I don't quite get this exception. I got this "way back" before I
implemented a correct way of creating a Contact instance when it doesn't
yet exist. So, this is somewhat unexpected.
[java] at
net.java.sip.communicator.impl.gui.main.chat.ChatWindowManager.openPrivateChatForChatRoomMember(ChatWindowManager.java:114)
What is strange here, is that the statement before this one, on line
111, it should always get a Contact-instance. I say always, because it
will be created when it cannot be found. So, it should never be null.
Are you sure that you are running the latest version? (latest commits
should be at most a few days ago)
If so, could you trace into the statement on line 111? (call of method
room.getPrivateContactByNickname(nickname)) It should lead to code
calling "findOrCreateContactByID".
When someone sends me a personal message, it shows up in "recent
conversations", but no tab in the chat window is opened. If I click
the chat icon in "recent conversation" the tab is opened and it all
works fine.
Hmm... this also sounds familiar as behaviour from when I used the
"private conversation via chat room" workaround. Again, please confirm
that you are running current code. Just to be sure ...
These errors are logged when I disable the account while in a room:
[java] [ApiDaemon] ERROR
com.ircclouds.irc.api.MessageDispatcherImpl -
[java] java.lang.NullPointerException
[java] at
net.java.sip.communicator.impl.protocol.irc.IrcStack$ChatRoomListener.isMe(IrcStack.java:1572)
[java] at
net.java.sip.communicator.impl.protocol.irc.IrcStack$ChatRoomListener.onChannelPart(IrcStack.java:1132)
[java] at
com.ircclouds.irc.api.MessageDispatcherImpl.dispatchVarious(MessageDispatcherImpl.java:84)
[java] at
com.ircclouds.irc.api.MessageDispatcherImpl.dispatchTo(MessageDispatcherImpl.java:62)
[java] at
com.ircclouds.irc.api.MessageDispatcherImpl.dispatch(MessageDispatcherImpl.java:28)
[java] at
com.ircclouds.irc.api.AbstractApiDaemon.run(AbstractApiDaemon.java:39)
[java] [ApiDaemon] ERROR
com.ircclouds.irc.api.MessageDispatcherImpl -
[java] java.lang.NullPointerException
[java] at
net.java.sip.communicator.impl.protocol.irc.IrcStack$ChatRoomListener.leaveChatRoom(IrcStack.java:1294)
[java] at
net.java.sip.communicator.impl.protocol.irc.IrcStack$ChatRoomListener.onServerNumericMessage(IrcStack.java:1185)
[java] at
com.ircclouds.irc.api.MessageDispatcherImpl.dispatchVarious(MessageDispatcherImpl.java:131)
[java] at
com.ircclouds.irc.api.MessageDispatcherImpl.dispatchTo(MessageDispatcherImpl.java:62)
[java] at
com.ircclouds.irc.api.MessageDispatcherImpl.dispatch(MessageDispatcherImpl.java:28)
[java] at
com.ircclouds.irc.api.AbstractApiDaemon.run(AbstractApiDaemon.java:39)
[java] [ApiDaemon] ERROR
com.ircclouds.irc.api.AbstractMessageReader - End of stream received.
I'll look into this.
Thanks again,
Danny
···
On 08/03/2014 12:01 PM, Boris Grozev wrote:
On 31/07/14 01:58, Danny van Heumen wrote:
Regards,
Boris
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev