[jitsi-dev] ice4j into Maven Central?


#1

Hi,

Could somebody please publish ice4j into Maven Central?

This will help the f-droid people to automate their builds of packages
that depend on it.

Regards,

Daniel


#2

Could somebody please publish ice4j into Maven Central?

I'm working on it.
I need to figure out how to deal with the JAIN SDP dependency. Your opentelecoms package only contains the javax.sdp API, but we also need the implementation. It compiles with javax.sdp:nist-sdp:1.0, but the license of that artifact is unclear to me.
And I also need to update the weupnp dependency now that my pull requests got merged and published.

This will help the f-droid people to automate their builds of packages
that depend on it.

Regards,
Daniel

Ingo


#3

If I remember correctly, the nist implementation files are public
domain. Public domain is not quite the same as copyright+license, but
it is OK for distribution. I think they are also distributed as part of
Android.

Debian will accept code that is public domain, but in this case, I'm
just asking about Maven Central

Regards,

Daniel

···

On 10/10/15 22:07, Ingo Bauersachs wrote:

Could somebody please publish ice4j into Maven Central?

I'm working on it.
I need to figure out how to deal with the JAIN SDP dependency. Your opentelecoms package only contains the javax.sdp API, but we also need the implementation. It compiles with javax.sdp:nist-sdp:1.0, but the license of that artifact is unclear to me.
And I also need to update the weupnp dependency now that my pull requests got merged and published.


#4

Could somebody please publish ice4j into Maven Central?

I'm working on it.
I need to figure out how to deal with the JAIN SDP dependency. Your
opentelecoms package only contains the javax.sdp API, but we also need the
implementation. It compiles with javax.sdp:nist-sdp:1.0, but the license of
that artifact is unclear to me.
And I also need to update the weupnp dependency now that my pull
requests got merged and published.

If I remember correctly, the nist implementation files are public
domain. Public domain is not quite the same as copyright+license, but
it is OK for distribution. I think they are also distributed as part of
Android.

Debian will accept code that is public domain, but in this case, I'm
just asking about Maven Central

Sure, but I still need to prepare an artifact first that can go into Maven Central (and later maybe Debian). Part of the problem with that is also the version to use. We haven't updated our (repo included) JAIN binaries for years and I'm afraid of breaking stuff.

Regards,
Daniel

Ingo

···

On 10/10/15 22:07, Ingo Bauersachs wrote:


#5

Maven Central accepts multiple versions of things, so you can just put
the old version that you support into Maven Central for now

Debian is different though, the FTP masters won't be enthusiastic if
they see an old version of something in their queue, but if there is
good reason for it (e.g. it is part of a bigger product that has been
tested and is working correctly) they may accept it anyway.

Regards,

Daniel

···

On 10/10/15 22:55, Ingo Bauersachs wrote:

On 10/10/15 22:07, Ingo Bauersachs wrote:

Could somebody please publish ice4j into Maven Central?

I'm working on it.
I need to figure out how to deal with the JAIN SDP dependency. Your
opentelecoms package only contains the javax.sdp API, but we also need the
implementation. It compiles with javax.sdp:nist-sdp:1.0, but the license of
that artifact is unclear to me.
And I also need to update the weupnp dependency now that my pull
requests got merged and published.

If I remember correctly, the nist implementation files are public
domain. Public domain is not quite the same as copyright+license, but
it is OK for distribution. I think they are also distributed as part of
Android.

Debian will accept code that is public domain, but in this case, I'm
just asking about Maven Central

Sure, but I still need to prepare an artifact first that can go into Maven Central (and later maybe Debian). Part of the problem with that is also the version to use. We haven't updated our (repo included) JAIN binaries for years and I'm afraid of breaking stuff.


#6

To finish the Lumicall build with Gradle, I uploaded my own build of
ice4j under the groupId org.opentelecoms.ice:

http://search.maven.org/#artifactdetails|org.opentelecoms.ice|ice4j-fork|1.0%2Bf.1|jar

The name makes it clear this is a fork, but it doesn't contain any code
changes, just the pom.xml is changed

Here is my change to the pom.xml:

https://github.com/dpocock/ice4j/commit/dc7afc3f11589a504a772e23037c162366ceebe5

Notice that I use the dependency:

  <groupId>javax.sdp</groupId>
  <artifactId>nist-sdp</artifactId>
  <version>1.0</version>

and that appears to try and use another transitive dependency:

  <groupId>javax.sip</groupId>
  <artifactId>jain-sip-ri</artifactId>
  <version>1.2.1</version>

This causes problems on the Lumicall build, it complains about having
two copies of the MediaDescription class, so I just exclude the JAIN SIP
stuff completely when using this from my build.gradle:

https://github.com/opentelecoms-org/lumicall/commit/9afbaca1be02a4c1696b8ba57e021dc6c2adf2b6#diff-c197962302397baf3a4cc36463dce5eaR23

dependencies {
    compile 'com.googlecode.libphonenumber:libphonenumber:7.1.0'
    compile 'info.ganglia.gmetric4j:gmetric4j:1.0.10'
    compile 'de.rtner:PBKDF2:1.1.1'
    compile 'org.opentelecoms.sip:mjsip-fork:1.6+lumicall.1'
    compile 'org.opentelecoms.zrtp:zorg-zrtp:1.0.0+f.1'
    compile ('org.opentelecoms.ice:ice4j-fork:1.0+f.1') {
        // nist-sdp and jain-sip-ri are transitive dependencies, must
exclude
        // them here or we get errors about duplicate classes later.Some
        // of these classes may be part of the Android platform.
        exclude module: 'nist-sdp'
    }
}

Maybe this problem occurs because some of those classes are in Android's
own SIP support.

Please let me know when the official ice4j is published and I'll remove
this alternative build from Maven.

···

On 10/10/15 23:06, Daniel Pocock wrote:

On 10/10/15 22:55, Ingo Bauersachs wrote:

On 10/10/15 22:07, Ingo Bauersachs wrote:

Could somebody please publish ice4j into Maven Central?

I'm working on it.
I need to figure out how to deal with the JAIN SDP dependency. Your
opentelecoms package only contains the javax.sdp API, but we also need the
implementation. It compiles with javax.sdp:nist-sdp:1.0, but the license of
that artifact is unclear to me.
And I also need to update the weupnp dependency now that my pull
requests got merged and published.

If I remember correctly, the nist implementation files are public
domain. Public domain is not quite the same as copyright+license, but
it is OK for distribution. I think they are also distributed as part of
Android.

Debian will accept code that is public domain, but in this case, I'm
just asking about Maven Central

Sure, but I still need to prepare an artifact first that can go into Maven Central (and later maybe Debian). Part of the problem with that is also the version to use. We haven't updated our (repo included) JAIN binaries for years and I'm afraid of breaking stuff.

Maven Central accepts multiple versions of things, so you can just put
the old version that you support into Maven Central for now

Debian is different though, the FTP masters won't be enthusiastic if
they see an old version of something in their queue, but if there is
good reason for it (e.g. it is part of a bigger product that has been
tested and is working correctly) they may accept it anyway.


#7

Please let me know when the official ice4j is published and I'll remove
this alternative build from Maven.

I was working on it today and managed to upload a snapshot version, using the same sdp dependency you mentioned. However, I'm currently running into problems with Maven creating the PGP signature over and over again. Do you have any idea what could be causing this?

I was planning on the using your opentelecoms javax.sdp interfaces and deploying the gov.nist implementation under org.jitsi. Does that seem okay for you?

Ingo


#8

Please let me know when the official ice4j is published and I'll remove
this alternative build from Maven.

I was working on it today and managed to upload a snapshot version, using the
same sdp dependency you mentioned. However, I'm currently running into
problems with Maven creating the PGP signature over and over again. Do you
have any idea what could be causing this?

Answering myself, this was a bug in the maven-bundle-plugin 2.5.4.

I was planning on the using your opentelecoms javax.sdp interfaces and
deploying the gov.nist implementation under org.jitsi. Does that seem okay
for you?

Ingo

Ingo