[jitsi-dev] [ibauersachs/dnssecjava] Provide alternatve to the resource bundle mechanism #7 FIX (#9)


#1

- Add setBundle() to R in order to manually set the ResourceBundle
- Update R.get() to handle MissingResourceException by using printing "key:param1:...:paramN"
You can view, comment on, or merge this pull request online at:

  https://github.com/ibauersachs/dnssecjava/pull/9

-- Commit Summary --

  * - Add setBundle() to R in order to manually set the ResourceBundle

-- File Changes --

    M src/main/java/org/jitsi/dnssec/R.java (25)

-- Patch Links --

https://github.com/ibauersachs/dnssecjava/pull/9.patch
https://github.com/ibauersachs/dnssecjava/pull/9.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9


#2

[![Coverage Status](https://coveralls.io/builds/7751644/badge)](https://coveralls.io/builds/7751644)

Coverage decreased (-0.6%) to 94.582% when pulling **702bab666958a7cb11c0e41a76149e0a55a968e5 on techguy613:master** into **bab567de2715becb675a94522d048ddbdfa79d4b on ibauersachs:master**.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9#issuecomment-244797568


#3

Thanks! This doesn't yet catch the case when the ResourceBundle isn't set manually and cannot be loaded automatically, the fallback is only effective if the key is actually not available.
Without testing it, I'd even assume that the attempt to call `setBundle` would crash on Android.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9#issuecomment-244800245


#4

@techguy613 pushed 1 commit.

5d7519c - Update R to import the resourceBundle upon first use

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9/files/702bab666958a7cb11c0e41a76149e0a55a968e5..5d7519c8a30c3f2a7c7d2af7f3cc4c6407e312e4


#5

@techguy613 pushed 1 commit.

98d244e - Fix un-checked formatting errors

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9/files/5d7519c8a30c3f2a7c7d2af7f3cc4c6407e312e4..98d244e63d0cf8c8c1cfa535f3d00d73480a2718


#6

[![Coverage Status](https://coveralls.io/builds/7752809/badge)](https://coveralls.io/builds/7752809)

Coverage decreased (-0.7%) to 94.44% when pulling **98d244e63d0cf8c8c1cfa535f3d00d73480a2718 on techguy613:master** into **bab567de2715becb675a94522d048ddbdfa79d4b on ibauersachs:master**.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9#issuecomment-244809426


#7

Merged #9.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ibauersachs/dnssecjava/pull/9#event-779984684