[jitsi-dev] HOW TO DISABLE TOOLBAR BUTTON IN ANDROID AND IOS NATIVE APP


#1

I tried removing the button view
from react/features/toolbox/components/Toolbox.native.js, but I got a red
screen error. I was able to disable the functionality but when I tried
removing the button , red screen error mentioning the Toobox.native.js was
popped up while starting the app.
Please provide a work around for this.
Thank you.
example of the view that I removed <ToolbarButton
iconName = {
this.props._locked ? 'security-locked' : 'security'
}
iconStyle = { iconStyle }
onClick = { this.props._onRoomLock }
style = { style }
underlayColor = { underlayColor } />

···

On Thu, Oct 26, 2017 at 9:21 PM, <dev-request@jitsi.org> wrote:

Send dev mailing list submissions to
        dev@jitsi.org

To subscribe or unsubscribe via the World Wide Web, visit
        http://lists.jitsi.org/mailman/listinfo/dev
or, via email, send a message with subject or body 'help' to
        dev-request@jitsi.org

You can reach the person managing the list at
        dev-owner@jitsi.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of dev digest..."

Today's Topics:

   1. Re: [jitsi/jitsi] Colibri cleanup (#416) (bbaldino)
   2. Re: [jitsi/jitsi] Colibri cleanup (#416) (bbaldino)
   3. Re: [jitsi/jitsi] Colibri cleanup (#416) (bbaldino)
   4. Re: HOW TO REMOVE THE TOOLBAR BUTONS (Saúl Ibarra Corretgé)

----------------------------------------------------------------------

Message: 1
Date: Thu, 26 Oct 2017 15:19:36 +0000 (UTC)
From: bbaldino <notifications@github.com>
To: jitsi/jitsi <jitsi@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [jitsi-dev] [jitsi/jitsi] Colibri cleanup (#416)
Message-ID: <jitsi/jitsi/pull/416/review/72234131@github.com>
Content-Type: text/plain; charset="utf-8"

bbaldino commented on this pull request.

> + RtpDescriptionPacketExtension.class);
+ if (description != null)
+ {
+ return copyDescription(description, channel);
+ }
+ return false;
+ }
+
+ /**
+ * Copies the contents of a {@link RtpDescriptionPacketExtension} to a
+ * {@link ColibriConferenceIQ.Channel}.
+ * @param description the {@link RtpDescriptionPacketExtension} from
which
+ * to copy.
+ * @param channel the {@link ColibriConferenceIQ.Channel} to which to
copy.
+ */
+ private boolean copyDescription(

looks like this doesn't access any member data and could be static?

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/416#pullrequestreview-72234131
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.jitsi.org/pipermail/dev/attachments/
20171026/89d4ef8f/attachment-0001.html>

------------------------------

Message: 2
Date: Thu, 26 Oct 2017 08:20:24 -0700
From: bbaldino <notifications@github.com>
To: jitsi/jitsi <jitsi@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [jitsi-dev] [jitsi/jitsi] Colibri cleanup (#416)
Message-ID: <jitsi/jitsi/pull/416/review/72234459@github.com>
Content-Type: text/plain; charset="utf-8"

bbaldino commented on this pull request.

> */
     public boolean addBundleTransportUpdateReq(
- IceUdpTransportPacketExtension transport,
- ColibriConferenceIQ localChannelsInfo)
+ IceUdpTransportPacketExtension transport,
+ String channelBundleId)

extra space looks like

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/416#pullrequestreview-72234459
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.jitsi.org/pipermail/dev/attachments/
20171026/0ef9a8ae/attachment-0001.html>

------------------------------

Message: 3
Date: Thu, 26 Oct 2017 08:23:10 -0700
From: bbaldino <notifications@github.com>
To: jitsi/jitsi <jitsi@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [jitsi-dev] [jitsi/jitsi] Colibri cleanup (#416)
Message-ID: <jitsi/jitsi/pull/416/review/72235529@github.com>
Content-Type: text/plain; charset="utf-8"

bbaldino commented on this pull request.

> */
- private void copyTransportOnChannel(
+ private void copyTransport(

looks like this could be static too

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/416#pullrequestreview-72235529
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.jitsi.org/pipermail/dev/attachments/
20171026/e906812b/attachment-0001.html>

------------------------------

Message: 4
Date: Thu, 26 Oct 2017 17:41:17 +0200
From: Saúl Ibarra Corretgé <scorretge@atlassian.com>
To: Jitsi Developers <dev@jitsi.org>
Subject: Re: [jitsi-dev] HOW TO REMOVE THE TOOLBAR BUTONS
Message-ID: <DB5B630A-EECE-4639-8760-CE5AA4529A91@atlassian.com>
Content-Type: text/plain; charset=utf-8

> On Oct 26, 2017, at 15:49, Rashid Mv <rashidmv@gmail.com> wrote:
>
>
> Sorry to mention that this is for android and ios. I hope
'interface_config.js' modification will be reflecting only on web jitsi.
What I want is to remove the buttons in android and ios
> Thank you

The you need to modify https://github.com/jitsi/
jitsi-meet/blob/master/react/features/toolbox/components/Toolbox.native.js
and remove the buttons you don’t want.

Cheers,

> On Thu, Oct 26, 2017 at 5:24 PM, <dev-request@jitsi.org> wrote:
> Send dev mailing list submissions to
> dev@jitsi.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.jitsi.org/mailman/listinfo/dev
> or, via email, send a message with subject or body 'help' to
> dev-request@jitsi.org
>
> You can reach the person managing the list at
> dev-owner@jitsi.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of dev digest..."
>
>
> Today's Topics:
>
> 1. Jitsi logging (Hedlund Rickard)
> 2. HOW TO REMOVE THE TOOLBAR BUTTONS (Rashid Mv)
> 3. Re: Jitsi logging (Saúl Ibarra Corretgé)
> 4. Re: HOW TO REMOVE THE TOOLBAR BUTTONS (Saúl Ibarra Corretgé)
> 5. Re: Jitsi logging (Hedlund Rickard)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 26 Oct 2017 10:46:44 +0000
> From: Hedlund Rickard <rickard.hedlund@lm.se>
> To: "dev@jitsi.org" <dev@jitsi.org>
> Subject: [jitsi-dev] Jitsi logging
> Message-ID: <5459d75787e744a29716e035df473923@SAAB.lantm.intra.local>
> Content-Type: text/plain; charset="utf-8"
>
> hi, does anyone know if there is any way to get logging information from
jitsi? I've been looking into jiloin but the support for influxdb seems to
be removed, is this correct or is it still active?
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.jitsi.org/pipermail/dev/attachments/
20171026/ab36c0e9/attachment-0001.html>
>
> ------------------------------
>
> Message: 2
> Date: Thu, 26 Oct 2017 16:30:11 +0530
> From: Rashid Mv <rashidmv@gmail.com>
> To: dev@jitsi.org
> Subject: [jitsi-dev] HOW TO REMOVE THE TOOLBAR BUTTONS
> Message-ID:
> <CAC5WWPYzroogF6T3mqZEgNfQOLkWq4q_vkcvXxPJwRF+z+tR5g@mail.
gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> I tried to remove the view
> from react/features/toolbox/components/Toolbox.native.js but got red
screen
> error. Please provide a work around for this.
> Thank you
>
> --
>
> Rashid M V | Software Engineer | Triassic Solutions Pvt. Ltd.
>
> +91 9633331989 | w <http://www.castalialabs.com/>
ww.triassicsolutions.com
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.jitsi.org/pipermail/dev/attachments/
20171026/45c104a9/attachment-0001.html>
>
> ------------------------------
>
> Message: 3
> Date: Thu, 26 Oct 2017 13:30:02 +0200
> From: Saúl Ibarra Corretgé <scorretge@atlassian.com>
> To: Jitsi Developers <dev@jitsi.org>
> Subject: Re: [jitsi-dev] Jitsi logging
> Message-ID: <D45BDCCE-99F5-4F13-BB9E-7CDB42A50184@atlassian.com>
> Content-Type: text/plain; charset=utf-8
>
>
> > On Oct 26, 2017, at 12:46, Hedlund Rickard <rickard.hedlund@lm.se> > wrote:
> >
> > hi, does anyone know if there is any way to get logging information
from jitsi? I've been looking into jiloin but the support for influxdb
seems to be removed, is this correct or is it still active?
>
> Hi,
>
> What project, specifically? jicofo and the jvb each log to a file, for
example.
>
>
> Cheers,
>
> --
> Saúl
>
>
>
>
> ------------------------------
>
> Message: 4
> Date: Thu, 26 Oct 2017 13:31:42 +0200
> From: Saúl Ibarra Corretgé <scorretge@atlassian.com>
> To: Jitsi Developers <dev@jitsi.org>
> Subject: Re: [jitsi-dev] HOW TO REMOVE THE TOOLBAR BUTTONS
> Message-ID: <BA294939-002F-4124-A189-AB6DC08AA27B@atlassian.com>
> Content-Type: text/plain; charset=utf-8
>
>
> > On Oct 26, 2017, at 13:00, Rashid Mv <rashidmv@gmail.com> wrote:
> >
> > I tried to remove the view from react/features/toolbox/components/Toolbox.native.js
but got red screen error. Please provide a work around for this.
> > Thank you
> >
>
> You can customize it by modifying interface_config.js:
https://github.com/jitsi/jitsi-meet/blob/master/interface_config.js#L40
>
>
> Cheers,
>
> --
> Saúl
>
>
>
>
> ------------------------------
>
> Message: 5
> Date: Thu, 26 Oct 2017 11:43:37 +0000
> From: Hedlund Rickard <rickard.hedlund@lm.se>
> To: Jitsi Developers <dev@jitsi.org>
> Subject: Re: [jitsi-dev] Jitsi logging
> Message-ID: <c94fe13513cd473787abc2a07c9041cd@SAAB.lantm.intra.local>
> Content-Type: text/plain; charset="utf-8"
>
> I want to log statistics.
> By reviewing the config-files, it looks like the only support for what I
want is to enable sending statistics to callstats.io.
> I want log that kind of information but on my own server.
> I'm mostly interested in logging from jicofo and jitsi-videobridge.
>
> Cheers,
> Rickard
>
> -----Ursprungligt meddelande-----
> Från: dev [mailto:dev-bounces@jitsi.org] För Saúl Ibarra Corretgé
> Skickat: den 26 oktober 2017 13:30
> Till: Jitsi Developers <dev@jitsi.org>
> Ämne: Re: [jitsi-dev] Jitsi logging
>
>
> > On Oct 26, 2017, at 12:46, Hedlund Rickard <rickard.hedlund@lm.se> > wrote:
> >
> > hi, does anyone know if there is any way to get logging information
from jitsi? I've been looking into jiloin but the support for influxdb
seems to be removed, is this correct or is it still active?
>
> Hi,
>
> What project, specifically? jicofo and the jvb each log to a file, for
example.
>
>
> Cheers,
>
> --
> Saúl
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> http://lists.jitsi.org/mailman/listinfo/dev
>
>
> ------------------------------
>
> End of dev Digest, Vol 55, Issue 101
> ************************************
>
>
>
> --
> Rashid M V | Software Engineer | Triassic Solutions Pvt. Ltd.
>
> +91 9633331989 | www.triassicsolutions.com
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Saúl

------------------------------

Subject: Digest Footer

_______________________________________________
dev mailing list
dev@jitsi.org
http://lists.jitsi.org/mailman/listinfo/dev

------------------------------

End of dev Digest, Vol 55, Issue 103
************************************

--

Rashid M V | Software Engineer | Triassic Solutions Pvt. Ltd.

+91 9633331989 | w <http://www.castalialabs.com/>ww.triassicsolutions.com


#2

If you DID NOT HAVE a red screen before you removed the button view
and you DO HAVE a red screen after you removed the button, then I'd
say that the error i.e. red screen was caused by your modifications to
the source code. So it's for you to go through your modifications and
figure out what you broke.

···

On Thu, Oct 26, 2017 at 10:55 AM, Rashid Mv <rashidmv@gmail.com> wrote:

I tried removing the button view from react/features/toolbox/components/Toolbox.native.js, but I got a red screen error. I was able to disable the functionality but when I tried removing the button , red screen error mentioning the Toobox.native.js was popped up while starting the app.
Please provide a work around for this.


#3

Please be more precise than "mentioning".

What exactly does the error message say?

They usually give a good hint as to what the problem is...

Antony.

···

On Thursday 26 October 2017 at 17:55:41, Rashid Mv wrote:

I tried removing the button view
from react/features/toolbox/components/Toolbox.native.js, but I got a red
screen error. I was able to disable the functionality but when I tried
removing the button , red screen error mentioning the Toobox.native.js was
popped up while starting the app.

--
"Linux is going to be part of the future. It's going to be like Unix was."

- Peter Moore, Asia-Pacific general manager, Microsoft

                                                   Please reply to the list;
                                                         please *don't* CC me.