[jitsi-dev] G.722 sample rate in Call Info


#1

Call Info displays the sample rate of G.722 as 8kHz while it is 16kHz.
The problem is that MediaFormat defines G.722 as 8kHz because G.722 is
to be advertised as such for the purposes of media negotiation while
16kHz audio is to actually be used - that's an error noted in the
respective RFC and kept for the sake of compatibility. We have a few
ifs here and there to properly display the actual sample rate so we
should probably think of a way to consolidate that info into
MediaFormat so that Call Info can display it correctly as well.


#2

Agreed. We should probably just implement a second method for this in
MediaFormat.

Emil

···

On 09.03.12 20:08, Lyubomir Marinov wrote:

Call Info displays the sample rate of G.722 as 8kHz while it is 16kHz.
The problem is that MediaFormat defines G.722 as 8kHz because G.722 is
to be advertised as such for the purposes of media negotiation while
16kHz audio is to actually be used - that's an error noted in the
respective RFC and kept for the sake of compatibility. We have a few
ifs here and there to properly display the actual sample rate so we
should probably think of a way to consolidate that info into
MediaFormat so that Call Info can display it correctly as well.


#3

Hi Lyubomir, Emil,

Commit #9463 corrects the displayed clock rate in call info for the G.722 encoding:

- Adds a getRealUsedClockRateString() function in MediaFormat and its implementation.

- This new function is used in the MediaStreamStatsImpl (call by the CallInfoFrame) and in the EncodingConfigurationTableModel (used for the Tools->Options->Audio->Encoding).

Thank you for the report,
Vincent

···

On 03/12/2012 08:17 AM, Emil Ivov wrote:

Agreed. We should probably just implement a second method for this in
MediaFormat.

Emil

On 09.03.12 20:08, Lyubomir Marinov wrote:

Call Info displays the sample rate of G.722 as 8kHz while it is 16kHz.
The problem is that MediaFormat defines G.722 as 8kHz because G.722 is
to be advertised as such for the purposes of media negotiation while
16kHz audio is to actually be used - that's an error noted in the
respective RFC and kept for the sake of compatibility. We have a few
ifs here and there to properly display the actual sample rate so we
should probably think of a way to consolidate that info into
MediaFormat so that Call Info can display it correctly as well.

--
Vincent Lucas, Ph.D. Jitsi developer
chenzo@jitsi.org http://jitsi.org