[jitsi-dev] Fwd: Re: Re: [jitsi~svn:9137] Change "proactive notification" to "typing notification"


#1

Hey

Any "Proactive Notification" is a typing notification received while
there were no windows open with the contact that generated it. So yes
you are right: PROACTIVE_NOTIFICATIONs are only generated by typing
notifications. That still keeps them different from regular typing
notifications that you get in the chat window during a conversation with
someone.

Right, maybe "Proactive typing notifications"?

Those notifications were to noisy, thats why I wanted to disable them.

IMHO they shouldn't show up when no prior conversation was established.
If I open a chat window to a contact, type something but decide to
forget about it, the contact would already have been informed. For me,
thats a privacy violation.
If a conversation is established, then they may show up for those who
like it.

Before I translated the notification config UI, the plugin simply showed
the enum names (converted from Pascal-Casing to "Spaced-Casing").

I don't understand. Where was this happening? Is this related to your
change? In your example, what is the difference between Pascal-Casing to
"Spaced-Casing"?

The notification plugin used enum constants for the entries in its
table. And because that looked ugly, some decided to call
"ConvertCamcelCaseToDisplayString", which, for the
ProactiveNofitications, resulted in "Proactive Notifications". Since
they are now translated, we're free to chose any meaningful name.

Maybe you remember that I told you I disabled the typing notifications,
but receive them despite the setting? Well, no wonder: The setting
behind the checkbox in Options->General->Message is not used anywhere.

OK. Just to be clear, this is not related to your string change, right?

Yes (but the source for trying to find out how to disable those popups).

IIRC, that setting was meant to prevent Jitsi from sending typing
notifications. It could have been broken along the way of course and if
so then we should have a look at it.

I didn't follow that deeper because I found a way for me to disable the
annoyance and put it on a todo list. I kind of accidentally committed
that string change (because it was in my master-tree instead of in a
branch), but didn't revert because it still seemed correct to change it.

Ingo


#2

На 24.11.11 17:40, Bauersachs Ingo написа:

Hey

Any "Proactive Notification" is a typing notification received while
there were no windows open with the contact that generated it. So yes
you are right: PROACTIVE_NOTIFICATIONs are only generated by typing
notifications. That still keeps them different from regular typing
notifications that you get in the chat window during a conversation with
someone.

Right, maybe "Proactive typing notifications"?

Yup, that's better.

Those notifications were to noisy, thats why I wanted to disable them.

IMHO they shouldn't show up when no prior conversation was established.
If I open a chat window to a contact, type something but decide to
forget about it, the contact would already have been informed. For me,
thats a privacy violation.

I understand how it could be considered one. However that's not a
problem with the notification itself. Jitsi is simply showing the
information it is receiving. The user may choose to disable such
notifications but that won't do anything to protect their own privacy.

In order to do this, we need to change sending of typing notifications
to only happen after a conversation has been started. Given that we
don't currently support the notion of conversations in the protocol
provider service, it would have to be some sort of a hack and it may be
tricky for some protocols.

Cheers,
Emil

···

If a conversation is established, then they may show up for those who
like it.

Before I translated the notification config UI, the plugin simply showed
the enum names (converted from Pascal-Casing to "Spaced-Casing").

I don't understand. Where was this happening? Is this related to your
change? In your example, what is the difference between Pascal-Casing to
"Spaced-Casing"?

The notification plugin used enum constants for the entries in its
table. And because that looked ugly, some decided to call
"ConvertCamcelCaseToDisplayString", which, for the
ProactiveNofitications, resulted in "Proactive Notifications". Since
they are now translated, we're free to chose any meaningful name.

Maybe you remember that I told you I disabled the typing notifications,
but receive them despite the setting? Well, no wonder: The setting
behind the checkbox in Options->General->Message is not used anywhere.

OK. Just to be clear, this is not related to your string change, right?

Yes (but the source for trying to find out how to disable those popups).

IIRC, that setting was meant to prevent Jitsi from sending typing
notifications. It could have been broken along the way of course and if
so then we should have a look at it.

I didn't follow that deeper because I found a way for me to disable the
annoyance and put it on a todo list. I kind of accidentally committed
that string change (because it was in my master-tree instead of in a
branch), but didn't revert because it still seemed correct to change it.

Ingo

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
http://jitsi.org FAX: +33.1.77.62.47.31