[jitsi-dev] Fwd: Re: Merge of NIO Branch


#1

We've been seeing a number of performance issues with JSIP lately so it
might be worth trying to upgrade to the latest trunk and turning on the
nioEnabled flag.

Cheers,
Emil

From: Jean Deruelle <jean.deruelle@gmail.com>

Just changed that in the latest commit. It was a merge error. I added
the flag -DnioEnabled so that we can test both NIO and Blocking NIO in
the CI Jobs.
Running them right now
at https://mobicents.ci.cloudbees.com/job/JAIN-SIP/ and
https://mobicents.ci.cloudbees.com/job/JAIN-SIP-NIO/

Jean

···

-------- Original Message --------
Subject: Re: Merge of NIO Branch
Date: Thu, 13 Dec 2012 11:33:59 +0100
Reply-To: users@jsip.java.net
To: users@jsip.java.net <users@jsip.java.net>

On Thu, Dec 13, 2012 at 7:48 AM, Vladimir Ralev <vladimir.ralev@gmail.com <mailto:vladimir.ralev@gmail.com>> wrote:

    Looks like NIO is now the default transport layer. Previously it was
    agreed that the old IO will stay default and NIO can be enabled by
    configuration. Is this the new plan or just a mistake? It's still
    possible that some older apps may suffer from the change because of
    non-blocking behavior.

    On Wed, Dec 12, 2012 at 10:03 PM, Jean Deruelle <jean.deruelle@gmail.com <mailto:jean.deruelle@gmail.com>> wrote:

        This is another good thing about git it keeps history of moved
        files, just saying :slight_smile:

        Jean

        On Wed, Dec 12, 2012 at 8:31 AM, Vladimir Ralev <vladimir.ralev@gmail.com <mailto:vladimir.ralev@gmail.com>> wrote:

            I was hoping to have a chance to do the merge myself, but
            anyway. I will review the merge this weekend. I also plan to
            move some classes into different packages because now the
            root package grew a bit out of proportion. I am always
            hesitant to move stuff because it will delete the proper
            history of the files, however the NIO stuff doesn't have any
            history of value so at least NIO and WebSockets I will move
            elsewhere for sure.

            On Tue, Dec 11, 2012 at 6:05 PM, Jean Deruelle <jean.deruelle@gmail.com <mailto:jean.deruelle@gmail.com>> wrote:

                Hi all,

                With the recent refactoring from Jonathan and Frederic,
                I figured it was starting to be more and more difficult
                to maintain the NIO branch in parallel. We were also
                discussing the formatter changes to the code base so
                that would have made it even harder to merge.
                I decided to merge the NIO Branch (which is actually NIO
                and SIP Over WebSockets) back into trunk which is the
                recent bulk of commits.
                I ran the TCK and unit tests on
                Jenkins
https://mobicents.ci.cloudbees.com/job/JAIN-SIP/lastCompletedBuild/testReport/
and
                there isn't much regression.

test.unit.gov.nist.javax.sip.stack.ReconnectTCPTest.testReconnectTCP
                 might be a race condition, I will check if it pops up
                on the next run as locally everything is fine

test.unit.gov.nist.javax.sip.stack.SIPEventInterceptorTest.testCallAnalyzerConcurrencyAndLeaks
                this one is fialing on cloudbees but not locally so need
                to check what happens and it has been failing before the
                merge for some time as well

                I will
                keep https://mobicents.ci.cloudbees.com/job/JAIN-SIP-NIO/ to
                keep testing the NIO switch by including a system prop
                for running the cc-buildloop but please double check if
                the merge has been successful with regard to the recent
                changes either Frederic or Jonathan and the ML as a
                whole for your applications.

                FYI, NIO has been reported to handle 15K Connections on
                a 8 Gb JVM with little CPU util. A couple more fixes may
                be needed for TLS, we are waiting for the report on that
                so you may expect a couple more commits there.

                Thanks to Vlad for the great work on the NIO Branch

                Jean