I'm forwarding message for our colleagues.
Emil, Lyubomir the subject of "manager" we were discussing at an early
stage of SCTP data channels comes back again.
-----BEGIN PGP SIGNED MESSAGE-----
I tried to use WebRtcDataStream but met some problems. Here are some
suggestions of mine:
First, I find that WebRtcDataStream is inside package
org.jitsi.videobridge. If I want to use WebRtcDataStream, I have to
import videobridge.jar, it's not convenient because Jirecon doesn't
need other things in videobridge.jar. So I think maybe we should move
it into libjitsi?
Next, the construct method of WebRtcDataStream is package visible, so
even if I imported the whole videobridge.jar, I still can't
instantiate it. It seems that I can only copy the code into my
project. But I think that's weird and hard to modify. So I'd suggest
to change the construct method to public visible.
What do you think?
Well the class is public, but the constructor was hidden for purpose.
In SctpConnection there is part of code that handles this WebRTC data
channel protocol from RFC mentioned in our eralier conversations.
SctpConnection allows to open new WebRtcDataStream on demand or to
listen for streams opened by the other side.
The problem is that this code is not easily reusable for your purpose.
One idea would be to take this code to some "WebRtcDataStreamManager"
that takes SctpSocket as a parameter and handles this WebRtc data
channel protocol. I feel that it's quite easy to extract out of from
SctpConnection to seprate class(it was like that in my first version).
Then it can be placed in libjitsi.
Unfortunately I am currently busy with some other tasks, so it would
take time. Eventually it would be great if you could try to do this
and make some pull request. What do you think ?
: Open WebRtcDataStream on request:
On Mon, Aug 11, 2014 at 4:16 PM, Shunyang Li <firstname.lastname@example.org> wrote: