I've added an event that is thrown whenever the recording state is changed. When the recording state is becoming true, the event also includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:
-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path (#184)
Yes, sorry. Pushed the wrong branch. You are right that this might not used right now elsewhere in jitsi-meet, I just thought that it would be useful for others as well. I am using it through the API that has been pushed recently by Hristo.
···
On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:
-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path (#184)
I've added an event that is thrown whenever the recording state is changed. When the recording state is becoming true, the event also includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:
The privacy implications here are somewhat worrying.
This basically gives users the knowledge about your storage infrastructure.
Emil
···
On 24.10.14, 15:19, Nicholas Wittstruck wrote:
Yes, sorry. Pushed the wrong branch. You are right that this might not used right now elsewhere in jitsi-meet, I just thought that it would be useful for others as well. I am using it through the API that has been pushed recently by Hristo.
On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:
-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path (#184)
I've added an event that is thrown whenever the recording state is changed. When the recording state is becoming true, the event also includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:
We already do this without the patch. I agree it exposes information and I think we might want to change it.
Regards,
Boris
···
On October 24, 2014 9:23:44 AM PDT, Emil Ivov <emcho@jitsi.org> wrote:
The privacy implications here are somewhat worrying.
This basically gives users the knowledge about your storage
infrastructure.
Emil
On 24.10.14, 15:19, Nicholas Wittstruck wrote:
Yes, sorry. Pushed the wrong branch. You are right that this might
not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API that
has been pushed recently by Hristo.
On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:
-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path
(#184)
I've added an event that is thrown whenever the recording state
is changed. When the recording state is becoming true, the event also
includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:
I agree, the fact that the recording has started and the timestamp should be sufficient. Should I submit a patch for the videobridge to remove the path?
All the best
Nicholas
···
On 24 Oct 2014, at 23:05, Boris Grozev <boris@jitsi.org> wrote:
The privacy implications here are somewhat worrying.
This basically gives users the knowledge about your storage
infrastructure.
Emil
On 24.10.14, 15:19, Nicholas Wittstruck wrote:
Yes, sorry. Pushed the wrong branch. You are right that this might
not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API that
has been pushed recently by Hristo.
On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:
-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path
(#184)
I've added an event that is thrown whenever the recording state
is changed. When the recording state is becoming true, the event also
includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:
I agree, the fact that the recording has started and the timestamp
should be sufficient. Should I submit a patch for the videobridge to
remove the path?
All the best
Nicholas
On 24 Oct 2014, at 23:05, Boris Grozev <boris@jitsi.org> wrote:
The privacy implications here are somewhat worrying.
This basically gives users the knowledge about your storage
infrastructure.
Emil
On 24.10.14, 15:19, Nicholas Wittstruck wrote:
Yes, sorry. Pushed the wrong branch. You are right that this might
not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API
that
has been pushed recently by Hristo.
On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:
-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path
(#184)
I've added an event that is thrown whenever the recording
state
is changed. When the recording state is becoming true, the event
also
includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:
I agree, the fact that the recording has started and the timestamp
should be sufficient. Should I submit a patch for the videobridge to
remove the path?
