[jitsi-dev] Fwd: [jitsi-meet] Added recording event that includes path (#184)


#1

I've added an event that is thrown whenever the recording state is changed. When the recording state is becoming true, the event also includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:

  git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

  * added recording event that includes path

-- File Changes --

    M app.js (6)
    M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

···

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path (#184)

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we don't handle the event).

The parameter that you added in app.js seems unused. Should it be named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.


#2

Yes, sorry. Pushed the wrong branch. You are right that this might not used right now elsewhere in jitsi-meet, I just thought that it would be useful for others as well. I am using it through the API that has been pushed recently by Hristo.

···

On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path (#184)

I&#39;ve added an event that is thrown whenever the recording state is changed. When the recording state is becoming true, the event also includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:

git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

* added recording event that includes path

-- File Changes --

   M app.js (6)
   M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we don't handle the event).

The parameter that you added in app.js seems unused. Should it be named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

The privacy implications here are somewhat worrying.

This basically gives users the knowledge about your storage infrastructure.

Emil

···

On 24.10.14, 15:19, Nicholas Wittstruck wrote:

Yes, sorry. Pushed the wrong branch. You are right that this might not used right now elsewhere in jitsi-meet, I just thought that it would be useful for others as well. I am using it through the API that has been pushed recently by Hristo.

On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path (#184)

I&#39;ve added an event that is thrown whenever the recording state is changed. When the recording state is becoming true, the event also includes a path to the recorded files.
Maybe this is useful for others as well?
You can merge this Pull Request by running:

  git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

  * added recording event that includes path

-- File Changes --

    M app.js (6)
    M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we don't handle the event).

The parameter that you added in app.js seems unused. Should it be named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#4

We already do this without the patch. I agree it exposes information and I think we might want to change it.

Regards,
Boris

···

On October 24, 2014 9:23:44 AM PDT, Emil Ivov <emcho@jitsi.org> wrote:

The privacy implications here are somewhat worrying.

This basically gives users the knowledge about your storage
infrastructure.

Emil

On 24.10.14, 15:19, Nicholas Wittstruck wrote:

Yes, sorry. Pushed the wrong branch. You are right that this might

not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API that
has been pushed recently by Hristo.

On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path

(#184)

I&#39;ve added an event that is thrown whenever the recording state

is changed. When the recording state is becoming true, the event also
includes a path to the recorded files.

Maybe this is useful for others as well?
You can merge this Pull Request by running:

  git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

  * added recording event that includes path

-- File Changes --

    M app.js (6)
    M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we don't

handle the event).

The parameter that you added in app.js seems unused. Should it be

named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Sent from a mobile. Please excuse my brevity.


#5

I agree, the fact that the recording has started and the timestamp should be sufficient. Should I submit a patch for the videobridge to remove the path?

All the best

Nicholas

···

On 24 Oct 2014, at 23:05, Boris Grozev <boris@jitsi.org> wrote:

On October 24, 2014 9:23:44 AM PDT, Emil Ivov <emcho@jitsi.org <mailto:emcho@jitsi.org>> wrote:

The privacy implications here are somewhat worrying.

This basically gives users the knowledge about your storage
infrastructure.

Emil

On 24.10.14, 15:19, Nicholas Wittstruck wrote:

Yes, sorry. Pushed the wrong branch. You are right that this might

not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API that
has been pushed recently by Hristo.

On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path

(#184)

I&#39;ve added an event that is thrown whenever the recording state

is changed. When the recording state is becoming true, the event also
includes a path to the recorded files.

Maybe this is useful for others as well?
You can merge this Pull Request by running:

git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

* added recording event that includes path

-- File Changes --

   M app.js (6)
   M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we don't

handle the event).

The parameter that you added in app.js seems unused. Should it be

named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

We already do this without the patch. I agree it exposes information and I think we might want to change it.

Regards,
Boris
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org <mailto:dev@jitsi.org>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Yes, please. We are not using the path for anything and a patch is very welcome.

Regards,
Boris

···

On October 27, 2014 1:34:50 PM PDT, Nicholas Wittstruck <n.wittstruck@gmail.com> wrote:

I agree, the fact that the recording has started and the timestamp
should be sufficient. Should I submit a patch for the videobridge to
remove the path?

All the best

Nicholas

On 24 Oct 2014, at 23:05, Boris Grozev <boris@jitsi.org> wrote:

On October 24, 2014 9:23:44 AM PDT, Emil Ivov <emcho@jitsi.org ><mailto:emcho@jitsi.org>> wrote:

The privacy implications here are somewhat worrying.

This basically gives users the knowledge about your storage
infrastructure.

Emil

On 24.10.14, 15:19, Nicholas Wittstruck wrote:

Yes, sorry. Pushed the wrong branch. You are right that this might

not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API

that

has been pushed recently by Hristo.

On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org> wrote:

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com>
Subject: [jitsi-meet] Added recording event that includes path

(#184)

I&#39;ve added an event that is thrown whenever the recording

state

is changed. When the recording state is becoming true, the event

also

includes a path to the recorded files.

Maybe this is useful for others as well?
You can merge this Pull Request by running:

git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

* added recording event that includes path

-- File Changes --

   M app.js (6)
   M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we

don't

handle the event).

The parameter that you added in app.js seems unused. Should it be

named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

We already do this without the patch. I agree it exposes information

and I think we might want to change it.

Regards,
Boris
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org <mailto:dev@jitsi.org>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<http://lists.jitsi.org/mailman/listinfo/dev>

------------------------------------------------------------------------

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Sent from a mobile. Please excuse my brevity.


#7

I’ve replaced the path with the name of the directory. That allows apps to access the recording, without exposing any critical information.

Here are the prs:
https://github.com/jitsi/jitsi-videobridge/pull/32
https://github.com/jitsi/jitsi/pull/63

I am happy about feedback :slight_smile:

···

On 27 Oct 2014, at 23:40, Boris Grozev <boris@jitsi.org> wrote:

On October 27, 2014 1:34:50 PM PDT, Nicholas Wittstruck <n.wittstruck@gmail.com <mailto:n.wittstruck@gmail.com>> wrote:

I agree, the fact that the recording has started and the timestamp
should be sufficient. Should I submit a patch for the videobridge to
remove the path?

All the best

Nicholas

On 24 Oct 2014, at 23:05, Boris Grozev <boris@jitsi.org <mailto:boris@jitsi.org>> wrote:

On October 24, 2014 9:23:44 AM PDT, Emil Ivov <emcho@jitsi.org <mailto:emcho@jitsi.org> >> <mailto:emcho@jitsi.org <mailto:emcho@jitsi.org>>> wrote:

The privacy implications here are somewhat worrying.

This basically gives users the knowledge about your storage
infrastructure.

Emil

On 24.10.14, 15:19, Nicholas Wittstruck wrote:

Yes, sorry. Pushed the wrong branch. You are right that this might

not used right now elsewhere in jitsi-meet, I just thought that it
would be useful for others as well. I am using it through the API

that

has been pushed recently by Hristo.

On 24 Oct 2014, at 15:06, Boris Grozev <boris@jitsi.org <mailto:boris@jitsi.org>> wrote:

-------- Original Message --------
From: Nicholas Wittstruck <notifications@github.com <mailto:notifications@github.com>>
Sent: October 24, 2014 3:21:33 AM PDT
To: jitsi/jitsi-meet <jitsi-meet@noreply.github.com <mailto:jitsi-meet@noreply.github.com>>
Subject: [jitsi-meet] Added recording event that includes path

(#184)

I&#39;ve added an event that is thrown whenever the recording

state

is changed. When the recording state is becoming true, the event

also

includes a path to the recorded files.

Maybe this is useful for others as well?
You can merge this Pull Request by running:

git pull https://github.com/nwittstruck/jitsi-meet master

Or you can view, comment on it, or merge it online at:

https://github.com/jitsi/jitsi-meet/pull/184

-- Commit Summary --

* added recording event that includes path

-- File Changes --

  M app.js (6)
  M libs/colibri/colibri.focus.js (3)

-- Patch Links --

https://github.com/jitsi/jitsi-meet/pull/184.patch
https://github.com/jitsi/jitsi-meet/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-meet/pull/184

I'm not sure if we have a use for this at the moment (since we

don't

handle the event).

The parameter that you added in app.js seems unused. Should it be

named 'path'?

Regards,
Boris

PS Sorry for replying here, I cannot login to github right now.
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

We already do this without the patch. I agree it exposes information

and I think we might want to change it.

Regards,
Boris
--
Sent from a mobile. Please excuse my brevity.

_______________________________________________
dev mailing list
dev@jitsi.org <mailto:dev@jitsi.org> <mailto:dev@jitsi.org <mailto:dev@jitsi.org>>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<http://lists.jitsi.org/mailman/listinfo/dev>

------------------------------------------------------------------------

_______________________________________________
dev mailing list
dev@jitsi.org <mailto:dev@jitsi.org>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

Yes, please. We are not using the path for anything and a patch is very welcome.

Regards,
Boris
--
Sent from a mobile. Please excuse my brevity.