[jitsi-dev] Fwd: [jitsi/jitsi] 5728fa: Refactor AccountIDs


#1

Hi Pawel,

When I try to create an XMPP account from the initial registration window (which appears when you have no accounts yet), I get the following exception:

[java] java.lang.IllegalStateException: No user ID provided.
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.JabberAccountRegistrationForm.commitPage(JabberAccountRegistrationForm.java:286)
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.FirstWizardPage.commitPage(FirstWizardPage.java:121)
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.JabberAccountRegistrationWizard.signin(JabberAccountRegistrationWizard.java:245)
     [java] at net.java.sip.communicator.plugin.simpleaccreg.InitialAccountRegistrationFrame$AccountRegistrationPanel.signin(InitialAccountRegistrationFrame.java:474)
     [java] at net.java.sip.communicator.plugin.simpleaccreg.InitialAccountRegistrationFrame$SigninActionListener.actionPerformed(InitialAccountRegistrationFrame.java:569)
     [java] at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
     [java] at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
     [java] at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
     [java] at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
     [java] at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
     [java] at java.awt.Component.processMouseEvent(Component.java:6382)
     [java] at javax.swing.JComponent.processMouseEvent(JComponent.java:3275)
     [java] at java.awt.Component.processEvent(Component.java:6147)
     [java] at java.awt.Container.processEvent(Container.java:2083)
     [java] at java.awt.Component.dispatchEventImpl(Component.java:4744)
     [java] at java.awt.Container.dispatchEventImpl(Container.java:2141)
     [java] at java.awt.Component.dispatchEvent(Component.java:4572)
     [java] at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4619)
     [java] at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4280)
     [java] at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4210)
     [java] at java.awt.Container.dispatchEventImpl(Container.java:2127)
     [java] at java.awt.Window.dispatchEventImpl(Window.java:2489)
     [java] at java.awt.Component.dispatchEvent(Component.java:4572)
     [java] at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:710)
     [java] at java.awt.EventQueue.access$400(EventQueue.java:82)
     [java] at java.awt.EventQueue$2.run(EventQueue.java:669)
     [java] at java.awt.EventQueue$2.run(EventQueue.java:667)
     [java] at java.security.AccessController.doPrivileged(Native Method)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
     [java] at java.awt.EventQueue$3.run(EventQueue.java:683)
     [java] at java.awt.EventQueue$3.run(EventQueue.java:681)
     [java] at java.security.AccessController.doPrivileged(Native Method)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
     [java] at java.awt.EventQueue.dispatchEvent(EventQueue.java:680)
     [java] at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
     [java] at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
     [java] at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
     [java] at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
     [java] at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
     [java] at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

The creation of the account fails.

Could you please have a look? I think it could be related to the last changes in this commit.

Cheers,
Yana

···

Begin forwarded message:

From: paweldomas <pawel.domas@jitsi.org>
Subject: [jitsi/jitsi] 5728fa: Refactor AccountIDs
Date: June 3, 2013 5:44:16 PM GMT+02:00
To: commits@jitsi.org
Reply-To: dev@jitsi.org, paweldomas <pawel.domas@jitsi.org>

Branch: refs/heads/Android-settings
Home: https://github.com/jitsi/jitsi
Commit: 5728fa3ce7ad864bbd73ed91425320962012d474
     https://github.com/jitsi/jitsi/commit/5728fa3ce7ad864bbd73ed91425320962012d474
Author: paweldomas <pawel.domas@jitsi.org>
Date: 2013-06-03 (Mon, 03 Jun 2013)

Changed paths:
   M lib/jitsi-defaults.properties
   M src/net/java/sip/communicator/impl/protocol/jabber/IceUdpTransportManager.java
   R src/net/java/sip/communicator/impl/protocol/jabber/JabberAccountID.java
   A src/net/java/sip/communicator/impl/protocol/jabber/JabberAccountIDImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/JingleNodesServiceDiscovery.java
   M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderFactoryJabberImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/TransportManagerGTalkImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/jabber.provider.manifest.mf
   M src/net/java/sip/communicator/impl/protocol/sip/OperationSetPresenceSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderFactorySipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ServerStoredContactListSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ServerStoredContactListXivoImpl.java
   R src/net/java/sip/communicator/impl/protocol/sip/SipAccountID.java
   A src/net/java/sip/communicator/impl/protocol/sip/SipAccountIDImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/AutoProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/ManualProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/ProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/SslNetworkLayer.java
   M src/net/java/sip/communicator/impl/protocol/sip/sip.provider.manifest.mf
   M src/net/java/sip/communicator/plugin/desktoputil/wizard/EncodingsPanel.java
   M src/net/java/sip/communicator/plugin/desktoputil/wizard/SecurityPanel.java
   M src/net/java/sip/communicator/plugin/facebookaccregwizz/FacebookAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/facebookaccregwizz/facebookaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/googletalkaccregwizz/GoogleTalkAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/googletalkaccregwizz/googletalkaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/ippiaccregwizz/IppiAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/ippiaccregwizz/ippiaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/iptelaccregwizz/IptelAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/iptelaccregwizz/iptelaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/ConnectionPanel.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/FirstWizardPage.java
   R src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistration.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistrationForm.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/jabberaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/sip2sipaccregwizz/Sip2SipAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/sip2sipaccregwizz/sip2sipaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/sipaccregwizz/ConnectionPanel.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/PresencePanel.java
   R src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistration.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationForm.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/sipaccregwizz.manifest.mf
   M src/net/java/sip/communicator/service/protocol/AccountID.java
   A src/net/java/sip/communicator/service/protocol/EncodingsRegistrationUtil.java
   M src/net/java/sip/communicator/service/protocol/JingleNodeDescriptor.java
   M src/net/java/sip/communicator/service/protocol/ProtocolProviderActivator.java
   M src/net/java/sip/communicator/service/protocol/ProtocolProviderFactory.java
   A src/net/java/sip/communicator/service/protocol/SecurityAccountRegistration.java
   A src/net/java/sip/communicator/service/protocol/jabber/JabberAccountID.java
   A src/net/java/sip/communicator/service/protocol/jabber/JabberAccountRegistration.java
   M src/net/java/sip/communicator/service/protocol/protocol.provider.manifest.mf
   A src/net/java/sip/communicator/service/protocol/sip/SIPAccountRegistration.java
   A src/net/java/sip/communicator/service/protocol/sip/SipAccountID.java
   R src/net/java/sip/communicator/util/wizard/EncodingsRegistrationUtil.java
   R src/net/java/sip/communicator/util/wizard/SecurityAccountRegistration.java
   M test/net/java/sip/communicator/slick/protocol/sip/SipProtocolProviderServiceLick.java
   M test/net/java/sip/communicator/slick/protocol/sip/TestAccountInstallation.java
   M test/net/java/sip/communicator/slick/protocol/sip/TestAutoProxyDetection.java

Log Message:
-----------
Refactor AccountIDs

Created SipAccountID and JabberAccountID from wizard registration
objects(work in progress).

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#2

Does it happends in master tree ?

I have already resolved the issue, but it's not commited yet as I
thought it's not urgent on the feature branch. It happens only from
the initial wizard, so you could try from options menu for now.

Regards,
Pawel

···

On Thu, Jun 6, 2013 at 4:47 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

When I try to create an XMPP account from the initial registration window (which appears when you have no accounts yet), I get the following exception:

[java] java.lang.IllegalStateException: No user ID provided.
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.JabberAccountRegistrationForm.commitPage(JabberAccountRegistrationForm.java:286)
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.FirstWizardPage.commitPage(FirstWizardPage.java:121)
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.JabberAccountRegistrationWizard.signin(JabberAccountRegistrationWizard.java:245)
     [java] at net.java.sip.communicator.plugin.simpleaccreg.InitialAccountRegistrationFrame$AccountRegistrationPanel.signin(InitialAccountRegistrationFrame.java:474)
     [java] at net.java.sip.communicator.plugin.simpleaccreg.InitialAccountRegistrationFrame$SigninActionListener.actionPerformed(InitialAccountRegistrationFrame.java:569)
     [java] at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
     [java] at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
     [java] at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
     [java] at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
     [java] at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
     [java] at java.awt.Component.processMouseEvent(Component.java:6382)
     [java] at javax.swing.JComponent.processMouseEvent(JComponent.java:3275)
     [java] at java.awt.Component.processEvent(Component.java:6147)
     [java] at java.awt.Container.processEvent(Container.java:2083)
     [java] at java.awt.Component.dispatchEventImpl(Component.java:4744)
     [java] at java.awt.Container.dispatchEventImpl(Container.java:2141)
     [java] at java.awt.Component.dispatchEvent(Component.java:4572)
     [java] at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4619)
     [java] at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4280)
     [java] at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4210)
     [java] at java.awt.Container.dispatchEventImpl(Container.java:2127)
     [java] at java.awt.Window.dispatchEventImpl(Window.java:2489)
     [java] at java.awt.Component.dispatchEvent(Component.java:4572)
     [java] at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:710)
     [java] at java.awt.EventQueue.access$400(EventQueue.java:82)
     [java] at java.awt.EventQueue$2.run(EventQueue.java:669)
     [java] at java.awt.EventQueue$2.run(EventQueue.java:667)
     [java] at java.security.AccessController.doPrivileged(Native Method)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
     [java] at java.awt.EventQueue$3.run(EventQueue.java:683)
     [java] at java.awt.EventQueue$3.run(EventQueue.java:681)
     [java] at java.security.AccessController.doPrivileged(Native Method)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
     [java] at java.awt.EventQueue.dispatchEvent(EventQueue.java:680)
     [java] at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
     [java] at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
     [java] at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
     [java] at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
     [java] at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
     [java] at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

The creation of the account fails.

Could you please have a look? I think it could be related to the last changes in this commit.

Cheers,
Yana

Begin forwarded message:

From: paweldomas <pawel.domas@jitsi.org>
Subject: [jitsi/jitsi] 5728fa: Refactor AccountIDs
Date: June 3, 2013 5:44:16 PM GMT+02:00
To: commits@jitsi.org
Reply-To: dev@jitsi.org, paweldomas <pawel.domas@jitsi.org>

Branch: refs/heads/Android-settings
Home: https://github.com/jitsi/jitsi
Commit: 5728fa3ce7ad864bbd73ed91425320962012d474
     https://github.com/jitsi/jitsi/commit/5728fa3ce7ad864bbd73ed91425320962012d474
Author: paweldomas <pawel.domas@jitsi.org>
Date: 2013-06-03 (Mon, 03 Jun 2013)

Changed paths:
   M lib/jitsi-defaults.properties
   M src/net/java/sip/communicator/impl/protocol/jabber/IceUdpTransportManager.java
   R src/net/java/sip/communicator/impl/protocol/jabber/JabberAccountID.java
   A src/net/java/sip/communicator/impl/protocol/jabber/JabberAccountIDImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/JingleNodesServiceDiscovery.java
   M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderFactoryJabberImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/TransportManagerGTalkImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/jabber.provider.manifest.mf
   M src/net/java/sip/communicator/impl/protocol/sip/OperationSetPresenceSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderFactorySipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ServerStoredContactListSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ServerStoredContactListXivoImpl.java
   R src/net/java/sip/communicator/impl/protocol/sip/SipAccountID.java
   A src/net/java/sip/communicator/impl/protocol/sip/SipAccountIDImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/AutoProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/ManualProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/ProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/SslNetworkLayer.java
   M src/net/java/sip/communicator/impl/protocol/sip/sip.provider.manifest.mf
   M src/net/java/sip/communicator/plugin/desktoputil/wizard/EncodingsPanel.java
   M src/net/java/sip/communicator/plugin/desktoputil/wizard/SecurityPanel.java
   M src/net/java/sip/communicator/plugin/facebookaccregwizz/FacebookAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/facebookaccregwizz/facebookaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/googletalkaccregwizz/GoogleTalkAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/googletalkaccregwizz/googletalkaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/ippiaccregwizz/IppiAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/ippiaccregwizz/ippiaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/iptelaccregwizz/IptelAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/iptelaccregwizz/iptelaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/ConnectionPanel.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/FirstWizardPage.java
   R src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistration.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistrationForm.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/jabberaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/sip2sipaccregwizz/Sip2SipAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/sip2sipaccregwizz/sip2sipaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/sipaccregwizz/ConnectionPanel.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/PresencePanel.java
   R src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistration.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationForm.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/sipaccregwizz.manifest.mf
   M src/net/java/sip/communicator/service/protocol/AccountID.java
   A src/net/java/sip/communicator/service/protocol/EncodingsRegistrationUtil.java
   M src/net/java/sip/communicator/service/protocol/JingleNodeDescriptor.java
   M src/net/java/sip/communicator/service/protocol/ProtocolProviderActivator.java
   M src/net/java/sip/communicator/service/protocol/ProtocolProviderFactory.java
   A src/net/java/sip/communicator/service/protocol/SecurityAccountRegistration.java
   A src/net/java/sip/communicator/service/protocol/jabber/JabberAccountID.java
   A src/net/java/sip/communicator/service/protocol/jabber/JabberAccountRegistration.java
   M src/net/java/sip/communicator/service/protocol/protocol.provider.manifest.mf
   A src/net/java/sip/communicator/service/protocol/sip/SIPAccountRegistration.java
   A src/net/java/sip/communicator/service/protocol/sip/SipAccountID.java
   R src/net/java/sip/communicator/util/wizard/EncodingsRegistrationUtil.java
   R src/net/java/sip/communicator/util/wizard/SecurityAccountRegistration.java
   M test/net/java/sip/communicator/slick/protocol/sip/SipProtocolProviderServiceLick.java
   M test/net/java/sip/communicator/slick/protocol/sip/TestAccountInstallation.java
   M test/net/java/sip/communicator/slick/protocol/sip/TestAutoProxyDetection.java

Log Message:
-----------
Refactor AccountIDs

Created SipAccountID and JabberAccountID from wizard registration
objects(work in progress).

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi Yana,

I've checked if the issue occurs on prior builds and it does even
before my first patch "android settings prerequisite patch" in master
branch. The reason is that in signin method of jabber wizard there is
condition:

        // if firstWizardPage is null we are requested sign-in from
        // initial account registration form we must init
        // firstWizardPage in order to init default values
        if(firstWizardPage == null)
        {
            firstWizardPage = new FirstWizardPage(this);
            AccountPanel accPanel =
                    (AccountPanel)firstWizardPage.getSimpleForm();
            accPanel.setUsername(userName);
            accPanel.setPassword(password);
            accPanel.setRememberPassword(true);
        }

As explained in the comment it assumes that first WizardPage will be
null, but it is always intialized from getSimpleForm method that is
used in "initial wizard". I've changed it to always fill the username
and password passed as signin method parametrs. It does work because
in other cases(not initial wizard) parameterless signin is called
which commits the wizard first and passes the login and pass from the
form anyway:

public ProtocolProviderService signin()
        throws OperationFailedException
    {
        firstWizardPage.commitPage();

        return signin( registration.getUserID(),
                             registration.getPassword());
    }

Now signin(String userName, String password) looks like this:

// if firstWizardPage is null we are requested sign-in from
        // initial account registration form we must init
        // firstWizardPage in order to init default values
        // Pawel: firstWizardPage is never null, and commitPage fails
        // with no user ID provided for simple account wizard.
        // Now userName and password are reentered here
        AccountPanel accPanel =
                    (AccountPanel)firstWizardPage.getSimpleForm();
        accPanel.setUsername(userName);
        accPanel.setPassword(password);
        accPanel.setRememberPassword(password != null);

        if(!firstWizardPage.isCommitted())
            firstWizardPage.commitPage();

···

On Thu, Jun 6, 2013 at 5:05 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Does it happends in master tree ?

I have already resolved the issue, but it's not commited yet as I
thought it's not urgent on the feature branch. It happens only from
the initial wizard, so you could try from options menu for now.

Regards,
Pawel

On Thu, Jun 6, 2013 at 4:47 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

When I try to create an XMPP account from the initial registration window (which appears when you have no accounts yet), I get the following exception:

[java] java.lang.IllegalStateException: No user ID provided.
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.JabberAccountRegistrationForm.commitPage(JabberAccountRegistrationForm.java:286)
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.FirstWizardPage.commitPage(FirstWizardPage.java:121)
     [java] at net.java.sip.communicator.plugin.jabberaccregwizz.JabberAccountRegistrationWizard.signin(JabberAccountRegistrationWizard.java:245)
     [java] at net.java.sip.communicator.plugin.simpleaccreg.InitialAccountRegistrationFrame$AccountRegistrationPanel.signin(InitialAccountRegistrationFrame.java:474)
     [java] at net.java.sip.communicator.plugin.simpleaccreg.InitialAccountRegistrationFrame$SigninActionListener.actionPerformed(InitialAccountRegistrationFrame.java:569)
     [java] at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
     [java] at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
     [java] at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
     [java] at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
     [java] at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
     [java] at java.awt.Component.processMouseEvent(Component.java:6382)
     [java] at javax.swing.JComponent.processMouseEvent(JComponent.java:3275)
     [java] at java.awt.Component.processEvent(Component.java:6147)
     [java] at java.awt.Container.processEvent(Container.java:2083)
     [java] at java.awt.Component.dispatchEventImpl(Component.java:4744)
     [java] at java.awt.Container.dispatchEventImpl(Container.java:2141)
     [java] at java.awt.Component.dispatchEvent(Component.java:4572)
     [java] at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4619)
     [java] at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4280)
     [java] at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4210)
     [java] at java.awt.Container.dispatchEventImpl(Container.java:2127)
     [java] at java.awt.Window.dispatchEventImpl(Window.java:2489)
     [java] at java.awt.Component.dispatchEvent(Component.java:4572)
     [java] at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:710)
     [java] at java.awt.EventQueue.access$400(EventQueue.java:82)
     [java] at java.awt.EventQueue$2.run(EventQueue.java:669)
     [java] at java.awt.EventQueue$2.run(EventQueue.java:667)
     [java] at java.security.AccessController.doPrivileged(Native Method)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
     [java] at java.awt.EventQueue$3.run(EventQueue.java:683)
     [java] at java.awt.EventQueue$3.run(EventQueue.java:681)
     [java] at java.security.AccessController.doPrivileged(Native Method)
     [java] at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
     [java] at java.awt.EventQueue.dispatchEvent(EventQueue.java:680)
     [java] at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
     [java] at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
     [java] at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
     [java] at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
     [java] at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
     [java] at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

The creation of the account fails.

Could you please have a look? I think it could be related to the last changes in this commit.

Cheers,
Yana

Begin forwarded message:

From: paweldomas <pawel.domas@jitsi.org>
Subject: [jitsi/jitsi] 5728fa: Refactor AccountIDs
Date: June 3, 2013 5:44:16 PM GMT+02:00
To: commits@jitsi.org
Reply-To: dev@jitsi.org, paweldomas <pawel.domas@jitsi.org>

Branch: refs/heads/Android-settings
Home: https://github.com/jitsi/jitsi
Commit: 5728fa3ce7ad864bbd73ed91425320962012d474
     https://github.com/jitsi/jitsi/commit/5728fa3ce7ad864bbd73ed91425320962012d474
Author: paweldomas <pawel.domas@jitsi.org>
Date: 2013-06-03 (Mon, 03 Jun 2013)

Changed paths:
   M lib/jitsi-defaults.properties
   M src/net/java/sip/communicator/impl/protocol/jabber/IceUdpTransportManager.java
   R src/net/java/sip/communicator/impl/protocol/jabber/JabberAccountID.java
   A src/net/java/sip/communicator/impl/protocol/jabber/JabberAccountIDImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/JingleNodesServiceDiscovery.java
   M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderFactoryJabberImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/TransportManagerGTalkImpl.java
   M src/net/java/sip/communicator/impl/protocol/jabber/jabber.provider.manifest.mf
   M src/net/java/sip/communicator/impl/protocol/sip/OperationSetPresenceSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderFactorySipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ServerStoredContactListSipImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/ServerStoredContactListXivoImpl.java
   R src/net/java/sip/communicator/impl/protocol/sip/SipAccountID.java
   A src/net/java/sip/communicator/impl/protocol/sip/SipAccountIDImpl.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/AutoProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/ManualProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/ProxyConnection.java
   M src/net/java/sip/communicator/impl/protocol/sip/net/SslNetworkLayer.java
   M src/net/java/sip/communicator/impl/protocol/sip/sip.provider.manifest.mf
   M src/net/java/sip/communicator/plugin/desktoputil/wizard/EncodingsPanel.java
   M src/net/java/sip/communicator/plugin/desktoputil/wizard/SecurityPanel.java
   M src/net/java/sip/communicator/plugin/facebookaccregwizz/FacebookAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/facebookaccregwizz/facebookaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/googletalkaccregwizz/GoogleTalkAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/googletalkaccregwizz/googletalkaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/ippiaccregwizz/IppiAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/ippiaccregwizz/ippiaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/iptelaccregwizz/IptelAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/iptelaccregwizz/iptelaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/ConnectionPanel.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/FirstWizardPage.java
   R src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistration.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistrationForm.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/JabberAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/jabberaccregwizz/jabberaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/sip2sipaccregwizz/Sip2SipAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/sip2sipaccregwizz/sip2sipaccregwizz.manifest.mf
   M src/net/java/sip/communicator/plugin/sipaccregwizz/ConnectionPanel.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/PresencePanel.java
   R src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistration.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationForm.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationWizard.java
   M src/net/java/sip/communicator/plugin/sipaccregwizz/sipaccregwizz.manifest.mf
   M src/net/java/sip/communicator/service/protocol/AccountID.java
   A src/net/java/sip/communicator/service/protocol/EncodingsRegistrationUtil.java
   M src/net/java/sip/communicator/service/protocol/JingleNodeDescriptor.java
   M src/net/java/sip/communicator/service/protocol/ProtocolProviderActivator.java
   M src/net/java/sip/communicator/service/protocol/ProtocolProviderFactory.java
   A src/net/java/sip/communicator/service/protocol/SecurityAccountRegistration.java
   A src/net/java/sip/communicator/service/protocol/jabber/JabberAccountID.java
   A src/net/java/sip/communicator/service/protocol/jabber/JabberAccountRegistration.java
   M src/net/java/sip/communicator/service/protocol/protocol.provider.manifest.mf
   A src/net/java/sip/communicator/service/protocol/sip/SIPAccountRegistration.java
   A src/net/java/sip/communicator/service/protocol/sip/SipAccountID.java
   R src/net/java/sip/communicator/util/wizard/EncodingsRegistrationUtil.java
   R src/net/java/sip/communicator/util/wizard/SecurityAccountRegistration.java
   M test/net/java/sip/communicator/slick/protocol/sip/SipProtocolProviderServiceLick.java
   M test/net/java/sip/communicator/slick/protocol/sip/TestAccountInstallation.java
   M test/net/java/sip/communicator/slick/protocol/sip/TestAutoProxyDetection.java

Log Message:
-----------
Refactor AccountIDs

Created SipAccountID and JabberAccountID from wizard registration
objects(work in progress).

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev