[jitsi-dev] Fwd: [jitsi-commits] master: Updates ice4j : It is now possible to define (lists of) blocked/allowed interfaces for host candidate allocation (0e4e786)


#1

Hey George,

A couple of notes here:

Currently running "ant run-sample" causes an exception because the stack has not been initialised. This shouldn't be happening. I suppose that the best way to go here would be to keep the initialize method callable so that using applications can for exceptions, but also make sure that it also gets called when someone uses the stack for the first time.

The second issue is that there are no javadocs for the initialize method. Could you please fix that tomorrow?

Thanks!
Emil

···

-------- Original Message --------
Subject: [jitsi-commits] master: Updates ice4j : It is now possible to define (lists of) blocked/allowed interfaces for host candidate allocation (0e4e786)
Date: Wed, 28 May 2014 16:35:02 +0200
From: gp@jitsi.org
Reply-To: dev@jitsi.org
To: commits@jitsi.org

Repository : ssh://lists.jitsi.org/jitsi-videobridge

On branch : master
Link : https://github.com/jitsi/jitsi-videobridge/compare/c6558b097eb8e94161378e0c8b51b90803ebb782...0e4e7868973b04b5cbf48eaa8723a1b1a0f70765

---------------------------------------------------------------

commit 0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
Author: George Politis <gp@jitsi.org>
Date: Wed May 28 16:30:03 2014 +0200

     Updates ice4j : It is now possible to define (lists of) blocked/allowed interfaces for host candidate allocation

---------------------------------------------------------------

0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
  lib/netaddr.jar | Bin 781722 -> 798498 bytes
  src/org/jitsi/videobridge/Main.java | 4 ++++
  2 files changed, 4 insertions(+)

diff --git a/lib/netaddr.jar b/lib/netaddr.jar
index 6eec540..3582890 100644
Binary files a/lib/netaddr.jar and b/lib/netaddr.jar differ
diff --git a/src/org/jitsi/videobridge/Main.java b/src/org/jitsi/videobridge/Main.java
index 6c8098a..d3b4394 100644
--- a/src/org/jitsi/videobridge/Main.java
+++ b/src/org/jitsi/videobridge/Main.java
@@ -10,6 +10,7 @@ import java.util.*;

  import net.java.sip.communicator.service.protocol.*;

+import org.ice4j.*;
  import org.jitsi.service.neomedia.*;
  import org.jitsi.videobridge.osgi.*;
  import org.jitsi.videobridge.xmpp.*;
@@ -225,6 +226,9 @@ public class Main
                      minPort);
          }

+ // Initialize the ice4j stack.
+ StackProperties.initialize();
+
          /*
           * Start OSGi. It will invoke the application programming interfaces
           * (APIs) of Jitsi Videobridge. Each of them will keep the application

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits


#2

Looking further into this there also appear to be code convention problems in there with column 80 transgressions and opening accolades. Could you please fix those as well?

Also, this "initialize" method seems to only init interface lists, so could we please reflect that in the name? initializeInterfaceFilters() for example.

Also, StackProperties has so far only been used as a property name holder. So I don't know if I'd like us to be adding other code in there. All of this is only of use to the host candidate harvester so we can either move it there or in a related HostHarvesterConfiguration object.

We can discuss this further offlist if you wish.

Cheers,
Emil

···

On 29.05.14, 16:46, Emil Ivov wrote:

Hey George,

A couple of notes here:

Currently running "ant run-sample" causes an exception because the stack
has not been initialised. This shouldn't be happening. I suppose that
the best way to go here would be to keep the initialize method callable
so that using applications can for exceptions, but also make sure that
it also gets called when someone uses the stack for the first time.

The second issue is that there are no javadocs for the initialize
method. Could you please fix that tomorrow?

Thanks!
Emil

-------- Original Message --------
Subject: [jitsi-commits] master: Updates ice4j : It is now possible to
define (lists of) blocked/allowed interfaces for host candidate
allocation (0e4e786)
Date: Wed, 28 May 2014 16:35:02 +0200
From: gp@jitsi.org
Reply-To: dev@jitsi.org
To: commits@jitsi.org

Repository : ssh://lists.jitsi.org/jitsi-videobridge

On branch : master
Link :
https://github.com/jitsi/jitsi-videobridge/compare/c6558b097eb8e94161378e0c8b51b90803ebb782...0e4e7868973b04b5cbf48eaa8723a1b1a0f70765

---------------------------------------------------------------

commit 0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
Author: George Politis <gp@jitsi.org>
Date: Wed May 28 16:30:03 2014 +0200

     Updates ice4j : It is now possible to define (lists of)
blocked/allowed interfaces for host candidate allocation

---------------------------------------------------------------

0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
  lib/netaddr.jar | Bin 781722 -> 798498 bytes
  src/org/jitsi/videobridge/Main.java | 4 ++++
  2 files changed, 4 insertions(+)

diff --git a/lib/netaddr.jar b/lib/netaddr.jar
index 6eec540..3582890 100644
Binary files a/lib/netaddr.jar and b/lib/netaddr.jar differ
diff --git a/src/org/jitsi/videobridge/Main.java
b/src/org/jitsi/videobridge/Main.java
index 6c8098a..d3b4394 100644
--- a/src/org/jitsi/videobridge/Main.java
+++ b/src/org/jitsi/videobridge/Main.java
@@ -10,6 +10,7 @@ import java.util.*;

  import net.java.sip.communicator.service.protocol.*;

+import org.ice4j.*;
  import org.jitsi.service.neomedia.*;
  import org.jitsi.videobridge.osgi.*;
  import org.jitsi.videobridge.xmpp.*;
@@ -225,6 +226,9 @@ public class Main
                      minPort);
          }

+ // Initialize the ice4j stack.
+ StackProperties.initialize();
+
          /*
           * Start OSGi. It will invoke the application programming
interfaces
           * (APIs) of Jitsi Videobridge. Each of them will keep the
application

_______________________________________________
commits mailing list
commits@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/commits

--
https://jitsi.org


#3

The issues have been fixed. Please let me know if there's anything that I've
missed. I'm sorry for any inconvenience this may have caused.

Cheers,
George

···

On Thursday 29 May 2014 17:00:15 Emil Ivov wrote:

Looking further into this there also appear to be code convention
problems in there with column 80 transgressions and opening accolades.
Could you please fix those as well?

Also, this "initialize" method seems to only init interface lists, so
could we please reflect that in the name? initializeInterfaceFilters()
for example.

Also, StackProperties has so far only been used as a property name
holder. So I don't know if I'd like us to be adding other code in there.
All of this is only of use to the host candidate harvester so we can
either move it there or in a related HostHarvesterConfiguration object.

We can discuss this further offlist if you wish.

Cheers,
Emil

On 29.05.14, 16:46, Emil Ivov wrote:
> Hey George,
>
> A couple of notes here:
>
> Currently running "ant run-sample" causes an exception because the stack
> has not been initialised. This shouldn't be happening. I suppose that
> the best way to go here would be to keep the initialize method callable
> so that using applications can for exceptions, but also make sure that
> it also gets called when someone uses the stack for the first time.
>
> The second issue is that there are no javadocs for the initialize
> method. Could you please fix that tomorrow?
>
> Thanks!
> Emil
>
>
> -------- Original Message --------
> Subject: [jitsi-commits] master: Updates ice4j : It is now possible to
> define (lists of) blocked/allowed interfaces for host candidate
> allocation (0e4e786)
> Date: Wed, 28 May 2014 16:35:02 +0200
> From: gp@jitsi.org
> Reply-To: dev@jitsi.org
> To: commits@jitsi.org
>
> Repository : ssh://lists.jitsi.org/jitsi-videobridge
>
> On branch : master
> Link :
> https://github.com/jitsi/jitsi-videobridge/compare/c6558b097eb8e94161378e
> 0c8b51b90803ebb782...0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
>
>> ---------------------------------------------------------------
>
> commit 0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
> Author: George Politis <gp@jitsi.org>
> Date: Wed May 28 16:30:03 2014 +0200
>
> Updates ice4j : It is now possible to define (lists of)
>
> blocked/allowed interfaces for host candidate allocation
>
>> ---------------------------------------------------------------
>
> 0e4e7868973b04b5cbf48eaa8723a1b1a0f70765
>
> lib/netaddr.jar | Bin 781722 -> 798498 bytes
> src/org/jitsi/videobridge/Main.java | 4 ++++
> 2 files changed, 4 insertions(+)
>
> diff --git a/lib/netaddr.jar b/lib/netaddr.jar
> index 6eec540..3582890 100644
> Binary files a/lib/netaddr.jar and b/lib/netaddr.jar differ
> diff --git a/src/org/jitsi/videobridge/Main.java
> b/src/org/jitsi/videobridge/Main.java
> index 6c8098a..d3b4394 100644
> --- a/src/org/jitsi/videobridge/Main.java
> +++ b/src/org/jitsi/videobridge/Main.java
> @@ -10,6 +10,7 @@ import java.util.*;
>
> import net.java.sip.communicator.service.protocol.*;
>
> +import org.ice4j.*;
>
> import org.jitsi.service.neomedia.*;
> import org.jitsi.videobridge.osgi.*;
> import org.jitsi.videobridge.xmpp.*;
>
> @@ -225,6 +226,9 @@ public class Main
>
> minPort);
>
> }
>
> + // Initialize the ice4j stack.
> + StackProperties.initialize();
> +
>
> /*
>
> * Start OSGi. It will invoke the application programming
>
> interfaces
>
> * (APIs) of Jitsi Videobridge. Each of them will keep the
>
> application
>
>
> _______________________________________________
> commits mailing list
> commits@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/commits