[jitsi-dev] fragmentation support pushed to OTR4J - Jitsi soon


#1

Hi all,

I have pushed fragmentation support for outgoing messages to
github.com/jitsi/otr4j and I have the changes for Jitsi ready at
github.com/cobratbq/jitsi/tree/otr-fragmentation.

Is it okay to just build the libraries and update them in Jitsi or does
someone want to have a look at the code first? (Given that it's OTR and
all ...)

There were some other changes to otr4j too. I have correct the API
interface changes as George already pointed out to me.

Kind regards,
Danny


#2

Hello Danny,

That's great! Please let me know if you're having any problems or
questions with the implementation in Jitsi.

Just to let you know, there is at least one known problem on the Jitsi
side of the implementation where the toolbar icon looses track of the
actual otr4j session status and so it displays the wrong icon and
executes the wrong actions. Don't get confused by that, it's not a
problem introduced by your changes.

Also, you're a Jitsi dev now, and as we have discussed this previously
on the list, please feel free to push your changes, no code review
required :slight_smile: At least I don't see it necessary.

Cheers,
George

···

On 29/09/2014 21:49, Danny van Heumen wrote:

Hi all,

I have pushed fragmentation support for outgoing messages to
github.com/jitsi/otr4j and I have the changes for Jitsi ready at
github.com/cobratbq/jitsi/tree/otr-fragmentation.

Is it okay to just build the libraries and update them in Jitsi or does
someone want to have a look at the code first? (Given that it's OTR and
all ...)

There were some other changes to otr4j too. I have correct the API
interface changes as George already pointed out to me.

Kind regards,
Danny


#3

I have pushed OTR fragmentation support (for outgoing messages) and IRC
OTR support to Jitsi.
I have tested the implementation against peers using:
- Jitsi (2nd instance)
- Pidgin with OTR
- irssi with OTR

As a consequence of implementing OTR fragmentation I have had to modify
the code surrounding the interfaces
OperationSetInstantMessagingTransform and TransformLayer such that they
support returning multiple messages, since we may now receive more than
one message (-part).

As a consequence of above changes, I've had to modify the following
protocols:
* ICQ
* IRC
* Jabber
* MSN
* SIP
* Yahoo
although modifications were only very small. (Loop and send all message
parts individually.)

OperationSetBasicInstantMessagingTransport has been introduced for
querying the protocol for its requirements for message size and number.
This is used by the OTR plugin for determining the correct fragmentation
instructions. OTR plugin will assume unlimited capabilities if no
implementation has been found. The same as it would have before.

Danny

···

On 09/29/2014 09:49 PM, Danny van Heumen wrote:

Hi all,

I have pushed fragmentation support for outgoing messages to
github.com/jitsi/otr4j and I have the changes for Jitsi ready at
github.com/cobratbq/jitsi/tree/otr-fragmentation.

Is it okay to just build the libraries and update them in Jitsi or does
someone want to have a look at the code first? (Given that it's OTR and
all ...)

There were some other changes to otr4j too. I have correct the API
interface changes as George already pointed out to me.

Kind regards,
Danny

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hi George,

Hello Danny,

That's great! Please let me know if you're having any problems or
questions with the implementation in Jitsi.

I've already got it working for a week or so. No problems there. I've
just been testing and defining the operation set necessary for querying
the necessary information about the IM protocol. Also, I've been playing
around with it using different clients to see whether there would be any
problems, but so far it looks pretty good.

Just to let you know, there is at least one known problem on the Jitsi
side of the implementation where the toolbar icon looses track of the
actual otr4j session status and so it displays the wrong icon and
executes the wrong actions. Don't get confused by that, it's not a
problem introduced by your changes.

Hmmm... I can't recall seeing anything like that. I'll keep an eye out
in case I encounter this issue.

Also, you're a Jitsi dev now, and as we have discussed this previously
on the list, please feel free to push your changes, no code review
required :slight_smile: At least I don't see it necessary.

Okay, sure. Just wanted to make sure that you're aware I'm fiddling with
your privacy thingies :stuck_out_tongue:

Danny

···

On 09/30/2014 10:17 AM, George Politis wrote:

Cheers,
George

On 29/09/2014 21:49, Danny van Heumen wrote:

Hi all,

I have pushed fragmentation support for outgoing messages to
github.com/jitsi/otr4j and I have the changes for Jitsi ready at
github.com/cobratbq/jitsi/tree/otr-fragmentation.

Is it okay to just build the libraries and update them in Jitsi or does
someone want to have a look at the code first? (Given that it's OTR and
all ...)

There were some other changes to otr4j too. I have correct the API
interface changes as George already pointed out to me.

Kind regards,
Danny