[jitsi-dev] Fork of Strophe?


#1

Hello,

When looking at the dependencies of Jitsi Meet, I noticed that you're
depending on your own fork of Strophe. That fork seems to be pretty much in
sync with upstream. I'm interested in finding any functional differences
between upstream and your version of Strophe (but can't find any) What's
the reason for you to use that fork?

Regards,

  Guus


#2

Hi Guus,

So there is a branch in that fork that we use. The reason for the fork is
that strophe hasn't pushed a new release after merging two PRs that I had
created and the way that it is built, basically it uses a prebuilt version
committed in the repo. So we were not able to simply point it to their
github repo in our package.json without a release on their side.

Regards
damencho

···

On Mon, May 7, 2018, 07:05 Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Hello,

When looking at the dependencies of Jitsi Meet, I noticed that you're
depending on your own fork of Strophe. That fork seems to be pretty much in
sync with upstream. I'm interested in finding any functional differences
between upstream and your version of Strophe (but can't find any) What's
the reason for you to use that fork?

Regards,

  Guus
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Ah, so there are no functional differences? That solves that mystery. :slight_smile:

I'm in frequent contact with one of the Strophe devs. If having a release
on their end helps you, I can ping him directly to see if that's possible.

···

On 7 May 2018 at 14:39, Damian Minkov <damencho@jitsi.org> wrote:

Hi Guus,

So there is a branch in that fork that we use. The reason for the fork is
that strophe hasn't pushed a new release after merging two PRs that I had
created and the way that it is built, basically it uses a prebuilt version
committed in the repo. So we were not able to simply point it to their
github repo in our package.json without a release on their side.

Regards
damencho

On Mon, May 7, 2018, 07:05 Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

Hello,

When looking at the dependencies of Jitsi Meet, I noticed that you're
depending on your own fork of Strophe. That fork seems to be pretty much in
sync with upstream. I'm interested in finding any functional differences
between upstream and your version of Strophe (but can't find any) What's
the reason for you to use that fork?

Regards,

  Guus
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hi again Guus,

Yep, ping him for a release, that will be nice. I asked about it
(https://github.com/strophe/strophejs/issues/274) and they said they
will make one in two weeks, but this was mid-December :stuck_out_tongue:

Regards
damencho

···

On Mon, May 7, 2018 at 8:00 AM, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Ah, so there are no functional differences? That solves that mystery. :slight_smile:

I'm in frequent contact with one of the Strophe devs. If having a release on
their end helps you, I can ping him directly to see if that's possible.

On 7 May 2018 at 14:39, Damian Minkov <damencho@jitsi.org> wrote:

Hi Guus,

So there is a branch in that fork that we use. The reason for the fork is
that strophe hasn't pushed a new release after merging two PRs that I had
created and the way that it is built, basically it uses a prebuilt version
committed in the repo. So we were not able to simply point it to their
github repo in our package.json without a release on their side.

Regards
damencho

On Mon, May 7, 2018, 07:05 Guus der Kinderen <guus.der.kinderen@gmail.com> >> wrote:

Hello,

When looking at the dependencies of Jitsi Meet, I noticed that you're
depending on your own fork of Strophe. That fork seems to be pretty much in
sync with upstream. I'm interested in finding any functional differences
between upstream and your version of Strophe (but can't find any) What's the
reason for you to use that fork?

Regards,

  Guus
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Ah, JC is also the person that I was going to ping myself. I've just send
him a friendly reminder. :slight_smile:

···

On 7 May 2018 at 15:34, Damian Minkov <damencho@jitsi.org> wrote:

Hi again Guus,

Yep, ping him for a release, that will be nice. I asked about it
(https://github.com/strophe/strophejs/issues/274) and they said they
will make one in two weeks, but this was mid-December :stuck_out_tongue:

Regards
damencho

On Mon, May 7, 2018 at 8:00 AM, Guus der Kinderen > <guus.der.kinderen@gmail.com> wrote:
> Ah, so there are no functional differences? That solves that mystery. :slight_smile:
>
> I'm in frequent contact with one of the Strophe devs. If having a
release on
> their end helps you, I can ping him directly to see if that's possible.
>
> On 7 May 2018 at 14:39, Damian Minkov <damencho@jitsi.org> wrote:
>>
>> Hi Guus,
>>
>> So there is a branch in that fork that we use. The reason for the fork
is
>> that strophe hasn't pushed a new release after merging two PRs that I
had
>> created and the way that it is built, basically it uses a prebuilt
version
>> committed in the repo. So we were not able to simply point it to their
>> github repo in our package.json without a release on their side.
>>
>> Regards
>> damencho
>>
>> On Mon, May 7, 2018, 07:05 Guus der Kinderen < > guus.der.kinderen@gmail.com> > >> wrote:
>>>
>>> Hello,
>>>
>>> When looking at the dependencies of Jitsi Meet, I noticed that you're
>>> depending on your own fork of Strophe. That fork seems to be pretty
much in
>>> sync with upstream. I'm interested in finding any functional
differences
>>> between upstream and your version of Strophe (but can't find any)
What's the
>>> reason for you to use that fork?
>>>
>>> Regards,
>>>
>>> Guus
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

\o/

https://github.com/strophe/strophejs/releases/tag/v1.2.15

···

On Mon, 7 May 2018, 15:44 Guus der Kinderen, <guus.der.kinderen@gmail.com> wrote:

Ah, JC is also the person that I was going to ping myself. I've just send
him a friendly reminder. :slight_smile:

On 7 May 2018 at 15:34, Damian Minkov <damencho@jitsi.org> wrote:

Hi again Guus,

Yep, ping him for a release, that will be nice. I asked about it
(https://github.com/strophe/strophejs/issues/274) and they said they
will make one in two weeks, but this was mid-December :stuck_out_tongue:

Regards
damencho

On Mon, May 7, 2018 at 8:00 AM, Guus der Kinderen >> <guus.der.kinderen@gmail.com> wrote:
> Ah, so there are no functional differences? That solves that mystery. :slight_smile:
>
> I'm in frequent contact with one of the Strophe devs. If having a
release on
> their end helps you, I can ping him directly to see if that's possible.
>
> On 7 May 2018 at 14:39, Damian Minkov <damencho@jitsi.org> wrote:
>>
>> Hi Guus,
>>
>> So there is a branch in that fork that we use. The reason for the fork
is
>> that strophe hasn't pushed a new release after merging two PRs that I
had
>> created and the way that it is built, basically it uses a prebuilt
version
>> committed in the repo. So we were not able to simply point it to their
>> github repo in our package.json without a release on their side.
>>
>> Regards
>> damencho
>>
>> On Mon, May 7, 2018, 07:05 Guus der Kinderen < >> guus.der.kinderen@gmail.com> >> >> wrote:
>>>
>>> Hello,
>>>
>>> When looking at the dependencies of Jitsi Meet, I noticed that you're
>>> depending on your own fork of Strophe. That fork seems to be pretty
much in
>>> sync with upstream. I'm interested in finding any functional
differences
>>> between upstream and your version of Strophe (but can't find any)
What's the
>>> reason for you to use that fork?
>>>
>>> Regards,
>>>
>>> Guus
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Thanks Guus,

I just saw it and will creat PRs today or tomorrow to get rid of our fork.

Regards
damencho

···

On Mon, May 21, 2018, 11:30 Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

\o/

https://github.com/strophe/strophejs/releases/tag/v1.2.15

On Mon, 7 May 2018, 15:44 Guus der Kinderen, <guus.der.kinderen@gmail.com> > wrote:

Ah, JC is also the person that I was going to ping myself. I've just send
him a friendly reminder. :slight_smile:

On 7 May 2018 at 15:34, Damian Minkov <damencho@jitsi.org> wrote:

Hi again Guus,

Yep, ping him for a release, that will be nice. I asked about it
(https://github.com/strophe/strophejs/issues/274) and they said they
will make one in two weeks, but this was mid-December :stuck_out_tongue:

Regards
damencho

On Mon, May 7, 2018 at 8:00 AM, Guus der Kinderen >>> <guus.der.kinderen@gmail.com> wrote:
> Ah, so there are no functional differences? That solves that mystery.
:slight_smile:
>
> I'm in frequent contact with one of the Strophe devs. If having a
release on
> their end helps you, I can ping him directly to see if that's possible.
>
> On 7 May 2018 at 14:39, Damian Minkov <damencho@jitsi.org> wrote:
>>
>> Hi Guus,
>>
>> So there is a branch in that fork that we use. The reason for the
fork is
>> that strophe hasn't pushed a new release after merging two PRs that I
had
>> created and the way that it is built, basically it uses a prebuilt
version
>> committed in the repo. So we were not able to simply point it to their
>> github repo in our package.json without a release on their side.
>>
>> Regards
>> damencho
>>
>> On Mon, May 7, 2018, 07:05 Guus der Kinderen < >>> guus.der.kinderen@gmail.com> >>> >> wrote:
>>>
>>> Hello,
>>>
>>> When looking at the dependencies of Jitsi Meet, I noticed that you're
>>> depending on your own fork of Strophe. That fork seems to be pretty
much in
>>> sync with upstream. I'm interested in finding any functional
differences
>>> between upstream and your version of Strophe (but can't find any)
What's the
>>> reason for you to use that fork?
>>>
>>> Regards,
>>>
>>> Guus
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________

dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev