[jitsi-dev] Flags


#1

Hiya

Just going through my to do list. The flags used for the spellchecker are ... not helpful. I think they should be more language specific or, failing that, be removed. In our cases we ended up with the Union Jack for Gaelic. Now, any sensitivities aside, that's just misleading from a language point of view as the only linguistic association people have with that flag is "English". Similarly, you also would end up lumping Welsh under the same flag.

I'm not sure if this is to avoid political... debates around which flag to use but the use of the Scottish and Welsh flag in the UK context to indicate Gaelic or Welsh is not controversial and commonly done. It may be more of a politcal hotball for languages like Kurdish though.

Could we use the Scottish flag for Gaelic or failing that, no flag at all please?

Michael


#2

Just going through my to do list. The flags used for the spellchecker
are ... not helpful. I think they should be more language specific or,
failing that, be removed. In our cases we ended up with the Union Jack
for Gaelic. Now, any sensitivities aside, that's just misleading from a
language point of view as the only linguistic association people have
with that flag is "English". Similarly, you also would end up lumping
Welsh under the same flag.

I'm not sure if this is to avoid political... debates around which flag
to use but the use of the Scottish and Welsh flag in the UK context to
indicate Gaelic or Welsh is not controversial and commonly done. It may
be more of a politcal hotball for languages like Kurdish though.

Could we use the Scottish flag for Gaelic or failing that, no flag at
all please?

(All) the flags are drawn from the country code in the languages'
definition. For Gaelic this currently (and AFAIK correctly) is gd_GB, hence
the UK flag. I'm not sure how to proceed here:
a) adding a Scottish flag (which doesn't have a country code in ISO
   3166-1) and changing the language definition to gd_X?, which would
   make no sense to Java's locale
b) removing the country for Gaelic entirely to force no flag
c) ?

(From a political standpoint, if I'm not messing things up now, IMO the UK
flag would not be wrong as long as Scotland is a part of the UK.)

Michael

Ingo


#3

11/04/2014 14:16, sgrìobh Ingo Bauersachs:

(All) the flags are drawn from the country code in the languages'
definition. For Gaelic this currently (and AFAIK correctly) is gd_GB, hence
the UK flag. I'm not sure how to proceed here:
a) adding a Scottish flag (which doesn't have a country code in ISO
    3166-1) and changing the language definition to gd_X?, which would
    make no sense to Java's locale

Is there no other code sheet Jitsi could pull these flags from?

b) removing the country for Gaelic entirely to force no flag
c) ?

(From a political standpoint, if I'm not messing things up now, IMO the UK
flag would not be wrong as long as Scotland is a part of the UK.)

I'm NOT trying to be political. How can I explain this... having the UK flag for Welsh, Gaelic, Cornish, Manx and (potentially) Irish (Northern Ireland, remember) would be like having the EU flag for German, French and Spanish etc. It would not technically be wrong (after all they're all EU member states) but in terms of a visual clue to the type of spellchecking done, it's not helpful but misleading.

So unless the flags can be tied more specifically to languages by using a different code sheet, I think they ought to be dropped across the board.

Michael<http://www.iGaidhlig.net/>


#4

11/04/2014 14:16, sgrìobh Ingo Bauersachs:

  (All) the flags are drawn from the country code in the languages'
  definition. For Gaelic this currently (and AFAIK correctly) is gd_GB,
hence the UK flag. I'm not sure how to proceed here: a) adding a
Scottish flag (which doesn't have a country code in ISO 3166-1) and
changing the language definition to gd_X?, which would make no sense
to Java's locale

Is there no other code sheet Jitsi could pull these flags from?

It would need to be changed. Currently the available languages and the corresponding dictionary are defined in an XML file. This could be extended to specify the flag.

  b) removing the country for Gaelic entirely to force no flag
  c) ?

  (From a political standpoint, if I'm not messing things up now, IMO
the UK
  flag would not be wrong as long as Scotland is a part of the UK.)

I'm NOT trying to be political. How can I explain this... having the UK flag
for Welsh, Gaelic, Cornish, Manx and (potentially) Irish (Northern Ireland,
remember) would be like having the EU flag for German, French and Spanish
etc. It would not technically be wrong (after all they're all EU member
states) but in terms of a visual clue to the type of spellchecking done, it's
not helpful but misleading.

I got that and I wasn't trying to use it as an argument to keep it the way it is.

So unless the flags can be tied more specifically to languages by using a
different code sheet, I think they ought to be dropped across the board.

That can certainly be done, however I currently simply don't have the time to do that, and I doubt someone else from the team has. If you can write a patch though, I'll take the time to review it.

Michael <http://www.iGaidhlig.net/>

Ingo


#5

11/04/2014 15:12, sgrìobh Ingo Bauersachs:

I got that and I wasn't trying to use it as an argument to keep it the way it is.

Oh ok, sorry for misreading that :slight_smile:

That can certainly be done, however I currently simply don't have the time to do that, and I doubt someone else from the team has. If you can write a patch though, I'll take the time to review it.

I'll speak to a colleague and see if she has time - I stand a better chance of programming the space shuttle than composing a patch that works >.<

Could you point me at the general part of the code where that's determined so I can ask her to take a look?

Cheers

Michael


#6

That can certainly be done, however I currently simply don't have the
time to do that, and I doubt someone else from the team has. If you
can write a patch though, I'll take the time to review it.

I'll speak to a colleague and see if she has time - I stand a better
chance of programming the space shuttle than composing a patch that
works >.<

Could you point me at the general part of the code where that's
determined so I can ask her to take a look?

Around here:

https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/plugin/spellcheck/LanguageMenuBar.java#L284

and

https://github.com/jitsi/jitsi/blob/master/resources/config/spellcheck/parameters.xml

Cheers
Michael

Ingo


#7

Thanks for the hints, Ingo. Pull request:

https://github.com/jitsi/jitsi/pull/22

Still needs compiling & testing, because Eclipse just blew up in my face
and I have no idea why. The code should work though unless I have a
silly typo someplace.

13/04/2014 15:40, sgrìobh Michael Bauer:

···

-------- An teachdaireachd thùsail --------
Cuspair: RE: [jitsi-dev] Flags
Ceann-là: Fri, 11 Apr 2014 18:31:11 +0200
O: Ingo Bauersachs <ingo@jitsi.org>
Gu: 'Jitsi Developers' <dev@jitsi.org>
CC: <fios@akerbeltz.org>

That can certainly be done, however I currently simply don't have the
time to do that, and I doubt someone else from the team has. If you
can write a patch though, I'll take the time to review it.

I'll speak to a colleague and see if she has time - I stand a better
chance of programming the space shuttle than composing a patch that
works >.<

Could you point me at the general part of the code where that's
determined so I can ask her to take a look?

Around here:

https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/plugin/spellcheck/LanguageMenuBar.java#L284

and

https://github.com/jitsi/jitsi/blob/master/resources/config/spellcheck/parameters.xml

Cheers
Michael

Ingo

---------------------------------------------------------------------------------------------------
Text inserted by Panda IS 2014:

This message has NOT been classified as spam. If it is unsolicited mail (spam), click on the following link to reclassify it: http://localhost:6083/Panda?ID=pav_7037&SPAM=true&path=C:\WINDOWS\system32\config\systemprofile\AppData\Local\Panda%20Security\Panda%20Internet%20Security%202014\AntiSpam
---------------------------------------------------------------------------------------------------

No virus found in this message.
Checked by AVG - www.avg.com <http://www.avg.com>
Version: 2014.0.4355 / Virus Database: 3882/7338 - Release Date: 04/13/14