[jitsi-dev] Fix issue with OTR after restore from system stand-by


#1

Hi all,

I've managed to fix an issue with OTR that occurs after a system - that
has Jitsi running - restores from standby/suspend.

You may still get a second OTR session after restoring from stand-by.
This is due to a new OTR session being initiated.

For devs and interested, some details:
ContactResource did not have equality defined. After re-establishing the
network connection (or at least, I am assuming this is the root reason)
new instances for ContactResource are used. Since ContactResource had
equality defined by instance address only, Some Jitsi GUI operations
broke down. Specifically, OTR's session switcher menu did not correctly
switch sessions as it never found the active contact (resource).

I have now defined equality based on resourceName.

Danny


#2

Hi Danny,

thank you VERY VERY much, that after such long time these nasty issues
have been taken now seriously/given priority and that you could now
reproduce/fix it, this is really great!!!

once your patch is available in the nighties I will test and provide
feedback, if issues would still occur...

kind regards, many thx again,
MS

PGP.sig (489 Bytes)

···

On 5/24/15 1:30 AM, Danny van Heumen wrote:

* PGP Signed: 5/24/15 at 1:30:42 AM

Hi all,

I've managed to fix an issue with OTR that occurs after a system - that
has Jitsi running - restores from standby/suspend.

You may still get a second OTR session after restoring from stand-by.
This is due to a new OTR session being initiated.

For devs and interested, some details:
ContactResource did not have equality defined. After re-establishing the
network connection (or at least, I am assuming this is the root reason)
new instances for ContactResource are used. Since ContactResource had
equality defined by instance address only, Some Jitsi GUI operations
broke down. Specifically, OTR's session switcher menu did not correctly
switch sessions as it never found the active contact (resource).

I have now defined equality based on resourceName.

Danny

* Danny van Heumen <danny@dannyvanheumen.nl>
* 0x911958D0:0x5ED42CC4

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

This is great, thanks very much for taking care of this Danny! This potentially fixes other hidden or unexplained bugs as well, if the equality is used elsewhere.

···

On 24 May 2015, at 8:19, Mr.Smith wrote:

Hi Danny,

thank you VERY VERY much, that after such long time these nasty issues
have been taken now seriously/given priority and that you could now
reproduce/fix it, this is really great!!!

once your patch is available in the nighties I will test and provide
feedback, if issues would still occur...

kind regards, many thx again,
MS

On 5/24/15 1:30 AM, Danny van Heumen wrote:

* PGP Signed: 5/24/15 at 1:30:42 AM

Hi all,

I've managed to fix an issue with OTR that occurs after a system - that
has Jitsi running - restores from standby/suspend.

You may still get a second OTR session after restoring from stand-by.
This is due to a new OTR session being initiated.

For devs and interested, some details:
ContactResource did not have equality defined. After re-establishing the
network connection (or at least, I am assuming this is the root reason)
new instances for ContactResource are used. Since ContactResource had
equality defined by instance address only, Some Jitsi GUI operations
broke down. Specifically, OTR's session switcher menu did not correctly
switch sessions as it never found the active contact (resource).

I have now defined equality based on resourceName.

Danny

* Danny van Heumen <danny@dannyvanheumen.nl>
* 0x911958D0:0x5ED42CC4

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev