[jitsi-dev] Failed Unit test TestCallHistoryService.readRecords


#1

Hey

After I committed a change in the SIP account wizard, the unit test
TestCallHistoryService.readRecords failed. I think this is unrelated
because:
- The changes are in completely different code sections
- The same test failed previously (also after unrelated changes,
http://java.net/nonav/projects/jitsi/lists/cruisecontrol/archive/2011-0
3/message/68)
- The test (sometimes) fails locally before and after my change

After looking at the failing test code and executing it multiple times,
I believe that either the test or the history service implementation is
timing dependent. Some of the history tests sometimes execute
successfully and sometimes they fail.

Can somebody confirm this?
How should I behave in such a situation?

Regards,
Ingo


#2

Hey Ingo,

На 16.04.11 18:38, ingo@rankweg.ch написа:

Hey

After I committed a change in the SIP account wizard, the unit test
TestCallHistoryService.readRecords failed. I think this is unrelated
because:
- The changes are in completely different code sections
- The same test failed previously (also after unrelated changes,
http://java.net/nonav/projects/jitsi/lists/cruisecontrol/archive/2011-0
3/message/68)
- The test (sometimes) fails locally before and after my change

After looking at the failing test code and executing it multiple times,
I believe that either the test or the history service implementation is
timing dependent. Some of the history tests sometimes execute
successfully and sometimes they fail.

Can somebody confirm this?

This can happen ineed.

How should I behave in such a situation?

Like you did. If after you analyse the problem it appears to be
unrelated to your commit and the tests pass ok at your box then it's
probably a problem with the test itself. You are of course welcome to
continue the analysis in that direction but you don't absolutely have to
if you don't feel like it.

Cheers,
Emil

···

Regards,
Ingo

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
http://jitsi.org FAX: +33.1.77.62.47.31