[jitsi-dev] Exception when trying to listen to a voice message


#1

Hi guys,

It's nice to see MWI support in the new release, however it does not appear to be working properly for me. I can see the new message, but when I click on the button to listen to it, nothing happens in the interface and I can see the following exception in the log file:

16:21:41.323 SEVERE: util.UtilActivator.uncaughtException().88 An uncaught exception occurred in thread=Thread[Thread-72,6,main] and message was: null
java.lang.NullPointerException
     at net.java.sip.communicator.util.StringUtils.containsLetters(StringUtils.java:207)
     at net.java.sip.communicator.impl.gui.main.call.CallManager.normalizePhoneNumbers(CallManager.java:2218)
     at net.java.sip.communicator.impl.gui.main.call.CallManager.access$400(CallManager.java:35)
     at net.java.sip.communicator.impl.gui.main.call.CallManager$CreateCallThread.run(CallManager.java:1213)

This is a fragment from the pcap file showing the notify message:

NOTIFY sip:dop@10.0.0.19:60733;transport=tcp;maddr=10.0.0.19;registering_acc=xxxxx SIP/2.0
Via: SIP/2.0/TCP 10.0.0.1:5060;branch=z9hG4bK83862;rport=5060;received=10.0.0.1
Max-Forwards: 69

From: <sip:dop@xxxxxx>;tag=A4A07F8931896732

Call-ID: 2240d33f8115da800e20a9506e9cc1ac@0:0:0:0:0:0:0:0
CSeq: 1 NOTIFY
Subscription-State: active;expires=3600
Event: message-summary
Contact: <sip:dop@xxxxxx>
User-Agent: CommuniGatePro-notify/5.4.2
Content-Type: application/simple-message-summary
Content-Length: 85

Messages-Waiting: yes
Message-Account: sip:dop@xxxxxxx
Voice-Message: 1/11

I haven't looked at the code but I suspect it has something to do with the message account. Could you please have a look?

Many thanks.

···

To: <sip:dop@xxxxxx>;tag=14c64d4

--
Dmitry Panov


#2

Hi,

its strange, I was testing it and when the account is in the received
Notify from the server there is no problem.
There is a known issue when there is 'Messages-Waiting: yes' and no
account and then you get this NPE.
I think your exception is in this situation, where there is no account
info, maybe we should make in that situation the call button disappear
cause there is no info where to call to listen for the messages. WDYT?

Regards
damencho

···

On Sun, Apr 8, 2012 at 6:30 PM, Dmitry Panov <dmitry.panov@yahoo.co.uk> wrote:

Hi guys,

It's nice to see MWI support in the new release, however it does not appear
to be working properly for me. I can see the new message, but when I click
on the button to listen to it, nothing happens in the interface and I can
see the following exception in the log file:

16:21:41.323 SEVERE: util.UtilActivator.uncaughtException().88 An uncaught
exception occurred in thread=Thread[Thread-72,6,main] and message was: null
java.lang.NullPointerException
at
net.java.sip.communicator.util.StringUtils.containsLetters(StringUtils.java:207)
at
net.java.sip.communicator.impl.gui.main.call.CallManager.normalizePhoneNumbers(CallManager.java:2218)
at
net.java.sip.communicator.impl.gui.main.call.CallManager.access$400(CallManager.java:35)
at
net.java.sip.communicator.impl.gui.main.call.CallManager$CreateCallThread.run(CallManager.java:1213)

This is a fragment from the pcap file showing the notify message:

NOTIFY
sip:dop@10.0.0.19:60733;transport=tcp;maddr=10.0.0.19;registering_acc=xxxxx
SIP/2.0
Via: SIP/2.0/TCP
10.0.0.1:5060;branch=z9hG4bK83862;rport=5060;received=10.0.0.1
Max-Forwards: 69
From: <sip:dop@xxxxxx>;tag=A4A07F8931896732
To: <sip:dop@xxxxxx>;tag=14c64d4
Call-ID: 2240d33f8115da800e20a9506e9cc1ac@0:0:0:0:0:0:0:0
CSeq: 1 NOTIFY
Subscription-State: active;expires=3600
Event: message-summary
Contact: <sip:dop@xxxxxx>
User-Agent: CommuniGatePro-notify/5.4.2
Content-Type: application/simple-message-summary
Content-Length: 85

Messages-Waiting: yes
Message-Account: sip:dop@xxxxxxx
Voice-Message: 1/11

I haven't looked at the code but I suspect it has something to do with the
message account. Could you please have a look?

Many thanks.

--
Dmitry Panov


#3

FYI: After an offlist discussion, we decided to add the option of manually
configuring a "check voicemail" URI. We'll use that if available and hide
the button if neither that nor the NOTIFY request contain it.

Objections anyone?

--sent from my mobile

···

On Apr 10, 2012 9:22 AM, "Damian Minkov" <damencho@jitsi.org> wrote:

Hi,

its strange, I was testing it and when the account is in the received
Notify from the server there is no problem.
There is a known issue when there is 'Messages-Waiting: yes' and no
account and then you get this NPE.
I think your exception is in this situation, where there is no account
info, maybe we should make in that situation the call button disappear
cause there is no info where to call to listen for the messages. WDYT?

Regards
damencho

On Sun, Apr 8, 2012 at 6:30 PM, Dmitry Panov <dmitry.panov@yahoo.co.uk> > wrote:
> Hi guys,
>
> It's nice to see MWI support in the new release, however it does not
appear
> to be working properly for me. I can see the new message, but when I
click
> on the button to listen to it, nothing happens in the interface and I can
> see the following exception in the log file:
>
> 16:21:41.323 SEVERE: util.UtilActivator.uncaughtException().88 An
uncaught
> exception occurred in thread=Thread[Thread-72,6,main] and message was:
null
> java.lang.NullPointerException
> at
>
net.java.sip.communicator.util.StringUtils.containsLetters(StringUtils.java:207)
> at
>
net.java.sip.communicator.impl.gui.main.call.CallManager.normalizePhoneNumbers(CallManager.java:2218)
> at
>
net.java.sip.communicator.impl.gui.main.call.CallManager.access$400(CallManager.java:35)
> at
>
net.java.sip.communicator.impl.gui.main.call.CallManager$CreateCallThread.run(CallManager.java:1213)
>
> This is a fragment from the pcap file showing the notify message:
>
> NOTIFY
> sip:dop@10.0.0.19:60733
;transport=tcp;maddr=10.0.0.19;registering_acc=xxxxx
> SIP/2.0
> Via: SIP/2.0/TCP
> 10.0.0.1:5060;branch=z9hG4bK83862;rport=5060;received=10.0.0.1
> Max-Forwards: 69
> From: <sip:dop@xxxxxx>;tag=A4A07F8931896732
> To: <sip:dop@xxxxxx>;tag=14c64d4
> Call-ID: 2240d33f8115da800e20a9506e9cc1ac@0:0:0:0:0:0:0:0
> CSeq: 1 NOTIFY
> Subscription-State: active;expires=3600
> Event: message-summary
> Contact: <sip:dop@xxxxxx>
> User-Agent: CommuniGatePro-notify/5.4.2
> Content-Type: application/simple-message-summary
> Content-Length: 85
>
> Messages-Waiting: yes
> Message-Account: sip:dop@xxxxxxx
> Voice-Message: 1/11
>
>
> I haven't looked at the code but I suspect it has something to do with
the
> message account. Could you please have a look?
>
>
> Many thanks.
>
> --
> Dmitry Panov
>


#4

Hi Damian,

I'm not sure what you mean by no 'account info'. The NOTIFY message I quoted looks quite normal to me. Can you see anything wrong with it?

···

On 10/04/2012 08:21, Damian Minkov wrote:

Hi,

its strange, I was testing it and when the account is in the received
Notify from the server there is no problem.
There is a known issue when there is 'Messages-Waiting: yes' and no
account and then you get this NPE.
I think your exception is in this situation, where there is no account
info, maybe we should make in that situation the call button disappear
cause there is no info where to call to listen for the messages. WDYT?

Regards
damencho

On Sun, Apr 8, 2012 at 6:30 PM, Dmitry Panov<dmitry.panov@yahoo.co.uk> wrote:

Hi guys,

It's nice to see MWI support in the new release, however it does not appear
to be working properly for me. I can see the new message, but when I click
on the button to listen to it, nothing happens in the interface and I can
see the following exception in the log file:

16:21:41.323 SEVERE: util.UtilActivator.uncaughtException().88 An uncaught
exception occurred in thread=Thread[Thread-72,6,main] and message was: null
java.lang.NullPointerException
    at
net.java.sip.communicator.util.StringUtils.containsLetters(StringUtils.java:207)
    at
net.java.sip.communicator.impl.gui.main.call.CallManager.normalizePhoneNumbers(CallManager.java:2218)
    at
net.java.sip.communicator.impl.gui.main.call.CallManager.access$400(CallManager.java:35)
    at
net.java.sip.communicator.impl.gui.main.call.CallManager$CreateCallThread.run(CallManager.java:1213)

This is a fragment from the pcap file showing the notify message:

NOTIFY
sip:dop@10.0.0.19:60733;transport=tcp;maddr=10.0.0.19;registering_acc=xxxxx
SIP/2.0
Via: SIP/2.0/TCP
10.0.0.1:5060;branch=z9hG4bK83862;rport=5060;received=10.0.0.1
Max-Forwards: 69
From:<sip:dop@xxxxxx>;tag=A4A07F8931896732
To:<sip:dop@xxxxxx>;tag=14c64d4
Call-ID: 2240d33f8115da800e20a9506e9cc1ac@0:0:0:0:0:0:0:0
CSeq: 1 NOTIFY
Subscription-State: active;expires=3600
Event: message-summary
Contact:<sip:dop@xxxxxx>
User-Agent: CommuniGatePro-notify/5.4.2
Content-Type: application/simple-message-summary
Content-Length: 85

Messages-Waiting: yes
Message-Account: sip:dop@xxxxxxx
Voice-Message: 1/11

I haven't looked at the code but I suspect it has something to do with the
message account. Could you please have a look?

Many thanks.

--
Dmitry Panov

--
Dmitry Panov


#5

Hey Dmitry

Hi Damian,

I'm not sure what you mean by no 'account info'. The NOTIFY message I
quoted looks quite normal to me. Can you see anything wrong with it?

I suppose Damian might have assumed the exception was caused by another
NOTIFY. Can we have a look at your entire log file?

Are you still having the issue with the new version by the way (after
setting an URI that is)?

Emil

···

On 10.04.12 22:13, Dmitry Panov wrote:

On 10/04/2012 08:21, Damian Minkov wrote:

Hi,

its strange, I was testing it and when the account is in the received
Notify from the server there is no problem.
There is a known issue when there is 'Messages-Waiting: yes' and no
account and then you get this NPE.
I think your exception is in this situation, where there is no account
info, maybe we should make in that situation the call button disappear
cause there is no info where to call to listen for the messages. WDYT?

Regards
damencho

On Sun, Apr 8, 2012 at 6:30 PM, Dmitry Panov<dmitry.panov@yahoo.co.uk> wrote:

Hi guys,

It's nice to see MWI support in the new release, however it does not appear
to be working properly for me. I can see the new message, but when I click
on the button to listen to it, nothing happens in the interface and I can
see the following exception in the log file:

16:21:41.323 SEVERE: util.UtilActivator.uncaughtException().88 An uncaught
exception occurred in thread=Thread[Thread-72,6,main] and message was: null
java.lang.NullPointerException
    at
net.java.sip.communicator.util.StringUtils.containsLetters(StringUtils.java:207)
    at
net.java.sip.communicator.impl.gui.main.call.CallManager.normalizePhoneNumbers(CallManager.java:2218)
    at
net.java.sip.communicator.impl.gui.main.call.CallManager.access$400(CallManager.java:35)
    at
net.java.sip.communicator.impl.gui.main.call.CallManager$CreateCallThread.run(CallManager.java:1213)

This is a fragment from the pcap file showing the notify message:

NOTIFY
sip:dop@10.0.0.19:60733;transport=tcp;maddr=10.0.0.19;registering_acc=xxxxx
SIP/2.0
Via: SIP/2.0/TCP
10.0.0.1:5060;branch=z9hG4bK83862;rport=5060;received=10.0.0.1
Max-Forwards: 69
From:<sip:dop@xxxxxx>;tag=A4A07F8931896732
To:<sip:dop@xxxxxx>;tag=14c64d4
Call-ID: 2240d33f8115da800e20a9506e9cc1ac@0:0:0:0:0:0:0:0
CSeq: 1 NOTIFY
Subscription-State: active;expires=3600
Event: message-summary
Contact:<sip:dop@xxxxxx>
User-Agent: CommuniGatePro-notify/5.4.2
Content-Type: application/simple-message-summary
Content-Length: 85

Messages-Waiting: yes
Message-Account: sip:dop@xxxxxxx
Voice-Message: 1/11

I haven't looked at the code but I suspect it has something to do with the
message account. Could you please have a look?

Many thanks.

--
Dmitry Panov

--
Dmitry Panov

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
http://jitsi.org FAX: +33.1.77.62.47.31


#6

Hi Emil,

Hey Dmitry

Hi Damian,

I'm not sure what you mean by no 'account info'. The NOTIFY message I
quoted looks quite normal to me. Can you see anything wrong with it?

I suppose Damian might have assumed the exception was caused by another
NOTIFY. Can we have a look at your entire log file?

The exception is not caused by the notify message indeed, it occurs whenever I click on the button to listen to a message. I'm attaching the log file, but I'm not sure if you can find anything useful there.

Are you still having the issue with the new version by the way (after
setting an URI that is)?

Sorry, what new version and what URI do you mean? I'm using 1.0-build.3967

Best regards,

jitsi0.log.0 (43.2 KB)

···

On 10/04/2012 21:25, Emil Ivov wrote:

On 10.04.12 22:13, Dmitry Panov wrote:

--
Dmitry Panov


#7

Hi,

Hi Emil,

Hey Dmitry

Hi Damian,

I'm not sure what you mean by no 'account info'. The NOTIFY message I
quoted looks quite normal to me. Can you see anything wrong with it?

I suppose Damian might have assumed the exception was caused by another
NOTIFY. Can we have a look at your entire log file?

The exception is not caused by the notify message indeed, it occurs whenever
I click on the button to listen to a message. I'm attaching the log file,
but I'm not sure if you can find anything useful there.

Yes, the Notify don't trigger the exception, but is the cause for it,
for example when missing the account info in it, and later when you
press the button the exception occurs cause of missing that info.
Thats why we asked for all logs as described here:
http://jitsi.org/faq/logs so we can check all notifies and see what
really happened.

Are you still having the issue with the new version by the way (after
setting an URI that is)?

Sorry, what new version and what URI do you mean? I'm using 1.0-build.3967

Sorry for not mentioning earlier, we mean that this was added to the
nightly build, you can check the nightlies at
http://download.jitsi.org/jitsi/nightly/. This option has been added
starting build.3987.
You can set the address for calling to check voicemail in the account
wizard when editing the account.

Regards
damencho

···

On Wed, Apr 11, 2012 at 11:07 PM, Dmitry Panov <dmitry.panov@yahoo.co.uk> wrote:

On 10/04/2012 21:25, Emil Ivov wrote:

On 10.04.12 22:13, Dmitry Panov wrote:

Best regards,

--
Dmitry Panov


#8

Hi Damian,

See attached.

BTW, for me Options are not under Tools, but under Jitsi -> Preferences. Perhaps it's because I'm using Mac version. I think it worth mentioning in the FAQ.

2012-04-12@11.52.28-logs.zip (8.4 KB)

···

On 12/04/2012 06:27, Damian Minkov wrote:

Hi,

On Wed, Apr 11, 2012 at 11:07 PM, Dmitry Panov<dmitry.panov@yahoo.co.uk> wrote:

Hi Emil,

On 10/04/2012 21:25, Emil Ivov wrote:

Hey Dmitry

On 10.04.12 22:13, Dmitry Panov wrote:

Hi Damian,

I'm not sure what you mean by no 'account info'. The NOTIFY message I
quoted looks quite normal to me. Can you see anything wrong with it?

I suppose Damian might have assumed the exception was caused by another
NOTIFY. Can we have a look at your entire log file?

The exception is not caused by the notify message indeed, it occurs whenever
I click on the button to listen to a message. I'm attaching the log file,
but I'm not sure if you can find anything useful there.

Yes, the Notify don't trigger the exception, but is the cause for it,
for example when missing the account info in it, and later when you
press the button the exception occurs cause of missing that info.
Thats why we asked for all logs as described here:
http://jitsi.org/faq/logs so we can check all notifies and see what
really happened.

Are you still having the issue with the new version by the way (after
setting an URI that is)?

Sorry, what new version and what URI do you mean? I'm using 1.0-build.3967

Sorry for not mentioning earlier, we mean that this was added to the
nightly build, you can check the nightlies at
http://download.jitsi.org/jitsi/nightly/. This option has been added
starting build.3987.
You can set the address for calling to check voicemail in the account
wizard when editing the account.

Regards
damencho

Best regards,

--
Dmitry Panov