At the moment in Chat window SIP URI is displayed. I would suggest to
change this to "Display Name" (if available in 'From:' header). Please
see PDF below for more details:
I'm not a SIP expert, but what happens if James has more than one SIP account and keeps the same display name for all his accounts. Then, if we have a "meta contact" for James in Jitsi, containing all his SIP contacts and we open a chat with him, we won't be able to distinguish the specific protocol contact from which he's writing. In the chat window we explicitly show the protocol contact address and not the display name in order to show which is the exact contact we're writing to at the moment.
At the moment in Chat window SIP URI is displayed. I would suggest to
change this to "Display Name" (if available in 'From:' header). Please
see PDF below for more details:
When I look at Chris' Screenshots again, I think the specific account where a buddy writes from doesn't matter in the notification popup (and in the chat log too). To be able to distinguish multiple accounts we could change the chat window title: instead of showing just the display name or the address, show both. E.g. "James (xyz33441@sip.example.com)"
Regards,
Ingo
···
-----Original Message-----
From: Yana Stamcheva [mailto:yana@jitsi.org]
Sent: Sonntag, 12. Juni 2011 13:36
To: dev@jitsi.java.net
Subject: [jitsi-dev] Re: Display Name instead of SIP URI
Hey Chris,
I'm not a SIP expert, but what happens if James has more than one SIP
account and keeps the same display name for all his accounts. Then, if we
have a "meta contact" for James in Jitsi, containing all his SIP contacts
and we open a chat with him, we won't be able to distinguish the specific
protocol contact from which he's writing. In the chat window we explicitly
show the protocol contact address and not the display name in order to
show which is the exact contact we're writing to at the moment.
At the moment in Chat window SIP URI is displayed. I would suggest to
change this to "Display Name" (if available in 'From:' header). Please
see PDF below for more details:
Your patch is now committed (r8776) and ack-ed on our contributors page!
I've just made some minor modifications that fix the same problem when a typing notification is received before the actual message and adds the displayName parameter directly to the createContact, instead of calling renameContact.
Thanks!!!
Yana
···
On Jul 7, 2011, at 11:08 AM, Chris Maciejewski wrote:
Hey,
A small patch which solves (I hope) "Display name" issue for incoming
SIP Chat from unknown contacts: