[jitsi-dev] Different audio codecs per account


#1

Hi,

I noticed that VoipBuster has a rather peculiar opinion on how to
negotiate for the audio codec. For instance, I can only place a call if
I disable Speex. According to some posts it has been proven that
VoipBuster uses a faulty configured sip platform and doesn't follow
standards. Considering the fact the standards are only useful if you
stick to them, I expect more voip providers have platform issues.

Which brings me to my point.

I am thinking about moving the audio codec preferences from top level
preference to account preference. That is, each account gets to set his
own codec preferences. This gives me top Speex quality for the iptel
account, while I can retain PCMA for Voipbuster. Any opinions on this one?

Thanks,
Koos

···

--
http://www.malarianomore.org
For $10 a mosquito net + distribution + education + monitoring + evaluation.


#2

Hey Koos,

Hi,

I noticed that VoipBuster has a rather peculiar opinion on how to
negotiate for the audio codec. For instance, I can only place a call if
I disable Speex. According to some posts it has been proven that
VoipBuster uses a faulty configured sip platform and doesn't follow
standards. Considering the fact the standards are only useful if you
stick to them, I expect more voip providers have platform issues.

Which brings me to my point.

I am thinking about moving the audio codec preferences from top level
preference to account preference. That is, each account gets to set his
own codec preferences. This gives me top Speex quality for the iptel
account, while I can retain PCMA for Voipbuster. Any opinions on this one?

This definitely makes sense and I've personally felt the need to be able
to have different codec preferences depending on my accounts.

Now, ideally, we wouldn't move them there but rather add the possibility
to override them. If codecs have been configured for a particular
account we use that configuration. Otherwise we go for the global.

All this happens in the various media handler implementations. For SIP
for example it happens in CallPeerMediaHandlerSipImpl. In there we use
MediaDevice.getSupportedFormats() to retrieve locally supported formats
in order of preference.

I suppose we could introduce a wrapper method (if possible in the
abstract MediaHandler parent), have it check for account specific
preferences, and then continue as we currently do.

Does this make sense to you?

Emil

···

On 11.06.12 10:03, Koos Pol wrote:

--
http://jitsi.org


#3

Op 11-06-12 11:02, Emil Ivov schreef:

I am thinking about moving the audio codec preferences from top level
preference to account preference. That is, each account gets to set his
own codec preferences. This gives me top Speex quality for the iptel
account, while I can retain PCMA for Voipbuster. Any opinions on this one?

This definitely makes sense and I've personally felt the need to be able
to have different codec preferences depending on my accounts.

Now, ideally, we wouldn't move them there but rather add the possibility
to override them. If codecs have been configured for a particular
account we use that configuration. Otherwise we go for the global.

All this happens in the various media handler implementations. For SIP
for example it happens in CallPeerMediaHandlerSipImpl. In there we use
MediaDevice.getSupportedFormats() to retrieve locally supported formats
in order of preference.

I suppose we could introduce a wrapper method (if possible in the
abstract MediaHandler parent), have it check for account specific
preferences, and then continue as we currently do.

Does this make sense to you?

To be honest, Emil, I've only glared at the code yet :wink:
Glad you agree to the basic idea, though. I'll start digging in the code and
follow your pointers. Let's see where this balls rolls to.

Cheers,
Koos

···

--
http://www.malarianomore.org
For $10 a mosquito net + distribution + education + monitoring + evaluation.