[jitsi-dev] Deprecated method getSendingBitrate


#1

Hi,

In the latest MediaStreamStats.java, the method getSendingBitrate is
deprecated (the implementation is kept in MediaStreamStatsImpl though). In
jitsi-videobridge, this method is still used for determining which layer to
send in AdaptiveSimulcastBitrateController. Is it expected?

Thanks!


#2

The jitsi-videobridge code hasn't been updated (but I think George Politis has uncommitted changes there).

Boris

···

On 01/12/2016 00:58, Ethan Lin wrote:

Hi,

In the latest MediaStreamStats.java, the method getSendingBitrate is
deprecated (the implementation is kept in MediaStreamStatsImpl though).
In jitsi-videobridge, this method is still used for determining which
layer to send in AdaptiveSimulcastBitrateController. Is it expected?


#3

Thanks Boris! Do we know when the code change will be landed? It seems the
method was flagged as "Deprecated" in August.

···

On Thu, Dec 1, 2016 at 7:13 AM, Boris Grozev <boris@jitsi.org> wrote:

On 01/12/2016 00:58, Ethan Lin wrote:

Hi,

In the latest MediaStreamStats.java, the method getSendingBitrate is
deprecated (the implementation is kept in MediaStreamStatsImpl though).
In jitsi-videobridge, this method is still used for determining which
layer to send in AdaptiveSimulcastBitrateController. Is it expected?

The jitsi-videobridge code hasn't been updated (but I think George Politis
has uncommitted changes there).

Boris

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Thanks Boris! Do we know when the code change will be landed? It seems
the method was flagged as "Deprecated" in August.

Next few weeks. The method was marked as deprecated to discourage it's use in new code, but it should still be working. If you are making modifications to the adaptivity code, definitely wait until the changes are in.

Boris

···

On 01/12/2016 15:29, Ethan Lin wrote:

On Thu, Dec 1, 2016 at 7:13 AM, Boris Grozev <boris@jitsi.org > <mailto:boris@jitsi.org>> wrote:

    On 01/12/2016 00:58, Ethan Lin wrote:

        Hi,

        In the latest MediaStreamStats.java, the method getSendingBitrate is
        deprecated (the implementation is kept in MediaStreamStatsImpl
        though).
        In jitsi-videobridge, this method is still used for determining
        which
        layer to send in AdaptiveSimulcastBitrateController. Is it expected?

    The jitsi-videobridge code hasn't been updated (but I think George
    Politis has uncommitted changes there).

    Boris

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>
    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev
    <http://lists.jitsi.org/mailman/listinfo/dev>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev