[jitsi-dev] CUSAX and presence disabled SIP


#1

Hey

I'm about to deploy CUSAX and was confused not to have the possibility for
adding SIP contacts anymore. The patch below would fix that, however I'm not
sure if I'm missing something.
When I'm talking about adding a SIP contact, this is obviously not for
presence anymore but rather for having some external contacts as a favorite.

Ingo

diff --git
a/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
b/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
index da36c7c..afb65f8 100644

···

---
a/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
+++
b/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
@@ -556,13 +556,14 @@
                 }
             }

+ //init presence op set, which also provides the possibility to
+ //have contacts (which in itself have nothing to do with
presence)
+ this.opSetPersPresence
+ = new OperationSetPresenceSipImpl(this, enablePresence,
+ forceP2P, pollingValue, subscriptionExpiration);
+
             if (enablePresence)
             {
- //init presence op set.
- this.opSetPersPresence
- = new OperationSetPresenceSipImpl(this, enablePresence,
- forceP2P, pollingValue,
subscriptionExpiration);
-
                 addSupportedOperationSet(
                     OperationSetPersistentPresence.class,
                     opSetPersPresence);


#2

I don't think it was our intent with CUSAX to disallow SIP contacts, so +1.

Peter

···

On 11/25/14, 10:15 AM, Ingo Bauersachs wrote:

Hey

I'm about to deploy CUSAX and was confused not to have the possibility for
adding SIP contacts anymore. The patch below would fix that, however I'm not
sure if I'm missing something.
When I'm talking about adding a SIP contact, this is obviously not for
presence anymore but rather for having some external contacts as a favorite.

--
Peter Saint-Andre
https://andyet.com/


#3

Hey Ingo,

The point of removing that as an option is to simplify user experience. The
point of CUSAX is to give people the impression that they are dealing with
a single service.

Having to choose between protocols is something that would confuse most
non-tech users.

That said, if you want to be able to do it, why don't you just leave
presence on for your SIP account?

--sent from my mobile

···

On 25 Nov 2014 6:16 PM, "Ingo Bauersachs" <ingo@jitsi.org> wrote:

Hey

I'm about to deploy CUSAX and was confused not to have the possibility for
adding SIP contacts anymore. The patch below would fix that, however I'm
not
sure if I'm missing something.
When I'm talking about adding a SIP contact, this is obviously not for
presence anymore but rather for having some external contacts as a
favorite.

Ingo

diff --git

a/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java

b/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
index da36c7c..afb65f8 100644
---

a/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
+++

b/src/net/java/sip/communicator/impl/protocol/sip/ProtocolProviderServiceSip
Impl.java
@@ -556,13 +556,14 @@
                 }
             }

+ //init presence op set, which also provides the possibility to
+ //have contacts (which in itself have nothing to do with
presence)
+ this.opSetPersPresence
+ = new OperationSetPresenceSipImpl(this, enablePresence,
+ forceP2P, pollingValue, subscriptionExpiration);
+
             if (enablePresence)
             {
- //init presence op set.
- this.opSetPersPresence
- = new OperationSetPresenceSipImpl(this,
enablePresence,
- forceP2P, pollingValue,
subscriptionExpiration);
-
                 addSupportedOperationSet(
                     OperationSetPersistentPresence.class,
                     opSetPersPresence);

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

The point of removing that as an option is to simplify user experience. The
point of CUSAX is to give people the impression that they are dealing with a
single service.

I agree with that point and I'd love to remove that complexity. But this would remove the possibility of having any external contact.

Having to choose between protocols is something that would confuse most non-
tech users.

I was thinking about an adapted add contact dialog box which takes CUSAX into account, e.g. by checking for numbers vs. JIDs and send them automatically to the corresponding protocol. This obviously won't work for e-mail like SIP addresses though.

That said, if you want to be able to do it, why don't you just leave presence
on for your SIP account?

Our users have SIP internal and external contacts in their list. Seeing the SIP contacts with different online/busy statuses than the XMPP accounts would likely confuse them even more than the accounts. By showing the contacts as always offline they'd have a motivation to delete the internal users.

What about a new property that allows to enable/disable SIP contacts, which by default follows PRESENCE_ENABLED?

Ingo